Skip to content

Comments

[5.0] TinyMCE plugins#41592

Merged
HLeithner merged 3 commits intojoomla:5.0-devfrom
brianteeman:tinypluginhelp
Sep 12, 2023
Merged

[5.0] TinyMCE plugins#41592
HLeithner merged 3 commits intojoomla:5.0-devfrom
brianteeman:tinypluginhelp

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Sep 4, 2023

Pull Request for Issue # .

Summary of Changes

When displaying the help page inside tinymce there is a list of the plugins being used and links to more information
This PR updates the three external plugins with a correct name and a link to joomla.org. The link itself can always be updated to a specific page in the future.

Testing Instructions

Enable the help btton in the tinymce plugin

image

In an article select the help button

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 4, 2023
@wilsonge
Copy link
Contributor

wilsonge commented Sep 4, 2023

Should these not be translatable strings as they're being rendered?

@brianteeman
Copy link
Contributor Author

Should these not be translatable strings as they're being rendered?

i dont think any of the strings on that tab are translated

@Fedik
Copy link
Member

Fedik commented Sep 5, 2023

I have tested this item ✅ successfully on 39561f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41592.

@Fedik Fedik added the bug label Sep 5, 2023
…gin.es6.js

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@ceford
Copy link
Contributor

ceford commented Sep 12, 2023

I must be doing something wrong. With 5.0.0-beta-2 I apply the patch and npm ci - I get a different set of Help links but not like in the illustration:

screen shot 2023-09-12 at 04 37 56


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41592.

@ceford
Copy link
Contributor

ceford commented Sep 12, 2023

I have tested this item ✅ successfully on 159deff

For my previous test I neglected to bring my clone up to data. I now see the links as in the illustration.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41592.

@HLeithner HLeithner merged commit 0c94047 into joomla:5.0-dev Sep 12, 2023
@ceford
Copy link
Contributor

ceford commented Sep 12, 2023

I have not tested this item.

For my previous test I neglected to bring my clone up to data. I now see the links as in the illustration.

Actually - two new links point to docs.joomla.org - surely that should be fixed before approval.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41592.

@brianteeman brianteeman deleted the tinypluginhelp branch September 12, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants