Skip to content

Comments

[5.0] Rework the com_messages message view#42135

Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom
wilsonge:rework/messages-html
Oct 18, 2023
Merged

[5.0] Rework the com_messages message view#42135
HLeithner merged 2 commits intojoomla:5.0-devfrom
wilsonge:rework/messages-html

Conversation

@wilsonge
Copy link
Contributor

Pull Request for Issue #42124 .

Summary of Changes

Rework of the HTML structure towards something geared towards more input'less elements. Physically separates the invisible form from the rendered HTML content.

Testing Instructions

Whilst this ensures the view looks better in dark mode. It obviously changes the structure in light mode too. This too should be validated. Check with longer and shorter message lengths.

Actual result BEFORE applying this Pull Request

dark-private-messages

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@toivo
Copy link
Contributor

toivo commented Oct 14, 2023

I have tested this item ✅ successfully on 93a717f

Tested successfully in 5.0.0-rc3-dev of 14 October using PHP 8.2.11 in Wampserver 3.3.1, in Light mode and Dark mode in Chrome.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42135.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 93a717f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42135.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42135.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 14, 2023
@wilsonge
Copy link
Contributor Author

If we want to treat this like a form field we should use formal input fields with labels as @dgrammatiko mentioned, close this PR and once #42124 is amended merge that one

If we’re happy rendering this without form field style rendering we should merge this PR and maintainers or a release lead should decide which approach

@dgrammatiko
Copy link
Contributor

FWIW I'm in favour of this one

@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev October 15, 2023 09:44
@HLeithner HLeithner requested a review from laoneo as a code owner October 15, 2023 09:44
@HLeithner HLeithner changed the title [5.0] Rework the com_messages message view [5.1] Rework the com_messages message view Oct 15, 2023
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Oct 15, 2023
@Quy
Copy link
Contributor

Quy commented Oct 17, 2023

@HLeithner Why not v5.0.1 as it is unreadable as of now in dark mode?

@HLeithner
Copy link
Member

because the screenshots looks like only refactorying the html and no dark mode fixes

@brianteeman
Copy link
Contributor

the html has to be refactored to enable the appropriate dark mode changes

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.0-dev October 18, 2023 15:23
@HLeithner HLeithner changed the title [5.1] Rework the com_messages message view [5.0] Rework the com_messages message view Oct 18, 2023
@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester labels Oct 18, 2023
@HLeithner HLeithner merged commit 0b8e9f7 into joomla:5.0-dev Oct 18, 2023
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 18, 2023
@HLeithner HLeithner added RTC This Pull Request is Ready To Commit Dark Mode labels Oct 18, 2023
@Quy Quy removed the PR-5.1-dev label Oct 18, 2023
@Quy Quy added this to the Joomla! 5.0.1 milestone Oct 18, 2023
@wilsonge wilsonge deleted the rework/messages-html branch October 19, 2023 07:12
@Quy Quy removed the RTC This Pull Request is Ready To Commit label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants