fix(tool-stub): detect binary names from single-file downloads

[jdx]

Summary

• Fixed binary name detection for single-file downloads in tool-stub generation
• Added helper function to extract tool names from URLs by removing platform/arch suffixes
• Binary name detection now works even when --skip-download is used

Problem

When generating tool stubs for single binary files (not archives), the bin field was being left empty or set incorrectly. For example, a stub named "jq-test" downloading "jq-macos-arm64" should set bin="jq" since the actual binary command is "jq", not "jq-macos-arm64".

Solution

1. Added extract_tool_name_from_filename() function that removes common platform/architecture suffixes from filenames
2. Updated the tool-stub generation logic to detect binary names from URLs even when skipping downloads
3. For single binary files, the tool name is extracted from the URL and set as the bin field when it differs from the stub filename

Test Plan

• Added e2e test test_generate_tool_stub that verifies:
  • Single binary files get correct bin field detection
  • Archives are handled properly
  • Bin field is omitted when it matches the stub name
  • Explicit bin parameter works correctly
• All existing tests pass
• Manual testing with jq and other single-binary tools

🤖 Generated with Claude Code

[Copilot]

Pull Request Overview

This PR fixes binary name detection for single-file downloads in tool-stub generation, ensuring that the bin field is correctly set to the actual binary command name rather than the filename with platform/architecture suffixes.

• Added helper function to extract tool names from URLs by removing platform/arch suffixes
• Updated tool-stub generation logic to detect binary names even when --skip-download is used
• Enhanced binary name detection for single binary files vs archives

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/cli/generate/tool_stub.rs	Added extract_tool_name_from_filename() function and updated logic to detect binary names from URLs when skipping downloads
e2e/cli/test_generate_tool_stub	Added comprehensive e2e test covering single binary files, archives, explicit bin parameters, and download scenarios

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The hardcoded suffix array could be difficult to maintain as new platform/architecture combinations emerge. Consider extracting this to a constant or configuration file to improve maintainability and make it easier to add new suffixes in the future.

Suggested change

	let suffixes = [
	"-linux-x64",
	"-linux-x86_64",
	"-linux-amd64",
	"-linux-arm64",
	"-linux-aarch64",
	"-darwin-x64",
	"-darwin-x86_64",
	"-darwin-amd64",
	"-darwin-arm64",
	"-darwin-aarch64",
	"-macos-x64",
	"-macos-x86_64",
	"-macos-amd64",
	"-macos-arm64",
	"-macos-aarch64",
	"-windows-x64",
	"-windows-x86_64",
	"-windows-amd64",
	"-windows-arm64",
	"-windows-aarch64",
	"-win-x64",
	"-win-x86_64",
	"-win-amd64",
	"-win-arm64",
	"-win-aarch64",
	"-x86_64",
	"-x64",
	"-amd64",
	"-arm64",
	"-aarch64",
	"-linux",
	"-darwin",
	"-macos",
	"-windows",
	"-win",
	];
	let mut result = name.to_string();
	for suffix in &suffixes {
	let suffixes = &TOOL_NAME_SUFFIXES;
	let mut result = name.to_string();
	for suffix in suffixes {

[Copilot]

The current logic only removes the first matching suffix found, but this could lead to incorrect results. For example, a filename like 'tool-linux-x64-linux' would only remove '-linux-x64' and leave '-linux' at the end. Consider iterating until no more suffixes can be removed or using a more sophisticated pattern matching approach.

Suggested change

	for suffix in &suffixes {
	if let Some(pos) = result.rfind(suffix) {
	result.truncate(pos);
	loop {
	let mut found = false;
	for suffix in &suffixes {
	if result.ends_with(suffix) {
	let len = result.len() - suffix.len();
	result.truncate(len);
	found = true;
	break;
	}
	}
	if !found {

[github-actions]

Hyperfine Performance

mise x -- echo

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.9.9 x -- echo	19.1 ± 0.3	18.7	21.6	1.00
mise x -- echo	19.2 ± 0.4	18.6	23.4	1.00 ± 0.03

mise env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.9.9 env	18.6 ± 0.3	18.2	21.8	1.00
mise env	18.9 ± 0.7	18.1	26.6	1.02 ± 0.04

mise hook-env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.9.9 hook-env	18.7 ± 0.5	17.8	22.2	1.02 ± 0.04
mise hook-env	18.3 ± 0.4	17.8	22.7	1.00

mise ls

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.9.9 ls	16.2 ± 0.3	15.7	17.7	1.00
mise ls	17.8 ± 1.6	15.9	45.6	1.10 ± 0.10

xtasks/test/perf

Command	mise-2025.9.9	mise	Variance
install (cached)	173ms	✅ 111ms	+55%
ls (cached)	63ms	63ms	+0%
bin-paths (cached)	69ms	70ms	-1%
task-ls (cached)	482ms	481ms	+0%

✅ Performance improvement: install cached is 55%