fix(env): allow nested env._.path directives by risu729 · Pull Request #6160 · jdx/mise

risu729 · 2025-08-30T07:18:47Z

This allows nested env directives. For example:

env._.path = [{ path = ["a", "b"], tools = true}, "c"]

will be parsed as the same as:

env._.path = [{ path = "a", tools = true}, { path = "b", tools = true}, "c"]

This had been documented but didn't work.

Copilot

Pull Request Overview

This PR fixes environment variable handling to allow complicated configuration for env._.path in mise configuration files. It adds support for object-based path configurations alongside the existing string and array formats.

Adds support for object-based path configuration with path and tools properties
Extends existing string and array path configurations
Adds comprehensive test coverage for all supported path configuration formats

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

jdx · 2025-09-05T10:53:44Z

idk if github is messed up but the only change is to e2e/env/test_env_path

risu729 · 2025-09-05T11:01:19Z

Sorry I just haven't done this, I forgot to make it as a draft.

jdx · 2025-09-05T11:24:08Z

I think this is the case for the other PR too

risu729 · 2025-09-05T12:20:40Z

Yes, I marked it as a draft.

risu729 · 2025-09-11T12:30:27Z

Sorry for taking a long time, serde was difficult to understand. It's now ready.

jdx · 2025-09-11T12:36:43Z

bugbot run

jdx · 2025-09-11T12:37:55Z

schema/mise-task.json

-                    "type": "string"
-                  },
-                  "type": "array"
+                    "oneOf": [


could we add this as a $def?

Done, not using it for env._.path as redact shouldn't be shown in the suggestion.
It's allowed in the Rust code but shouldn't be allowed in the schema.

cursor

✅ Bugbot reviewed your changes and found no bugs!

@jdx

### 🐛 Bug Fixes - **(backend)** make HTTP installs atomic and serialize with cache lock by @jdx in [#6259](#6259) - **(env)** allow nested env._.path directives by @risu729 in [#6160](#6160) - **(env)** disallow nested env objects by @risu729 in [#6268](#6268) - **(schema)** allow nested arrays in task.depends by @risu729 in [#6265](#6265) - **(task)** resolve jobs=1 hang and keep-order panic; improve Ctrl-C handling by @jdx in [#6264](#6264) - **(tasks)** stop CLI group after first failure without --continue-on-error by @jdx in [#6270](#6270) ### 📚 Documentation - fixed toml issues in URL replacements settings documentation by @ThomasSteinbach in [#6269](#6269) ### Chore - **(schema)** strict oneOf branches and DRY env_directive in schemas by @jdx in [#6271](#6271) - add schema linter by @risu729 in [#6267](#6267) Co-authored-by: mise-en-dev <release@mise.jdx.dev>

@jdx

## [2025.9.12](https://github.com/jdx/mise/compare/v2025.9.11..v2025.9.12) - 2025-09-16 ### 🐛 Bug Fixes - **(ci)** properly exclude aqua-registry files from hk linting by @jdx in [42d7758](jdx/mise@42d7758) ### Chore - **(release)** embed aqua-registry under crate and publish like vfox by @jdx in [#6306](jdx/mise#6306) - ignore aqua-registry assets from prettier by @jdx in [047d77b](jdx/mise@047d77b) - disable "useless cat" shellcheck by @jdx in [a6def59](jdx/mise@a6def59) ## [2025.9.11](https://github.com/jdx/mise/compare/v2025.9.10..v2025.9.11) - 2025-09-16 ### 📦 Registry - indicate aws-cli is v2 by @jayvdb in [#6300](jdx/mise#6300) ### 🚀 Features - **(ci)** run all registry tools when workflow_dispatch is triggered by @jdx in [#6295](jdx/mise#6295) - **(cli)** handle non-existent working directories gracefully by @jdx in [#6304](jdx/mise#6304) - **(set)** add -E/--env flag to mise set command by @jdx in [#6291](jdx/mise#6291) - **(tasks)** make auto outputs default by @risu729 in [#6137](jdx/mise#6137) ### 🐛 Bug Fixes - align crate versions to fix release-plz script by @jdx in [5a464e9](jdx/mise@5a464e9) ### 🚜 Refactor - **(aqua)** extract aqua registry into internal subcrate by @jdx in [#6293](jdx/mise#6293) ### 📚 Documentation - fix mkdir paths by @risu729 in [#6298](jdx/mise#6298) - fix rust profile default by @risu729 in [#6305](jdx/mise#6305) ### Chore - **(aqua-registry)** remove unused aqua-registry files by @jdx in [#6294](jdx/mise#6294) - **(release)** make release-plz idempotent for existing crate versions by @jdx in [dbdfd6a](jdx/mise@dbdfd6a) - **(release)** skip publishing mise when aqua-registry is a path dep by @jdx in [47efffd](jdx/mise@47efffd) - keep aqua-registry LICENSE file by @risu729 in [#6297](jdx/mise#6297) ### New Contributors - @jayvdb made their first contribution in [#6300](jdx/mise#6300) ## [2025.9.10](https://github.com/jdx/mise/compare/v2025.9.9..v2025.9.10) - 2025-09-13 ### 📦 Registry - use asdf to install semver-tool by @jylenhof in [#6233](jdx/mise#6233) ### 🐛 Bug Fixes - **(tool-stub)** detect binary names from single-file downloads by @jdx in [#6281](jdx/mise#6281) ### 🚜 Refactor - allow any collection types in deserialize_arr by @risu729 in [#6282](jdx/mise#6282) - use deserialize_arr for task runs by @risu729 in [#6253](jdx/mise#6253) ### 📚 Documentation - **(getting-started)** add backends step with diagram, github example, env vars and simple tasks by @jdx in [#6288](jdx/mise#6288) - simplify OS detection in tool plugin development by @jdx in [#6287](jdx/mise#6287) - update backend plugin template references by @jdx in [942f5eb](jdx/mise@942f5eb) ### 📦️ Dependency Updates - update rust crate chrono to v0.4.42 by @renovate[bot] in [#6274](jdx/mise#6274) - update taiki-e/install-action digest to 0154864 by @renovate[bot] in [#6273](jdx/mise#6273) ### Chore - **(schema)** fix schema for subtasks by @risu729 in [#6289](jdx/mise#6289) - update render:schema task by @risu729 in [#6275](jdx/mise#6275) ## [2025.9.9](https://github.com/jdx/mise/compare/v2025.9.8..v2025.9.9) - 2025-09-11 ### 🐛 Bug Fixes - **(backend)** make HTTP installs atomic and serialize with cache lock by @jdx in [#6259](jdx/mise#6259) - **(env)** allow nested env._.path directives by @risu729 in [#6160](jdx/mise#6160) - **(env)** disallow nested env objects by @risu729 in [#6268](jdx/mise#6268) - **(schema)** allow nested arrays in task.depends by @risu729 in [#6265](jdx/mise#6265) - **(task)** resolve jobs=1 hang and keep-order panic; improve Ctrl-C handling by @jdx in [#6264](jdx/mise#6264) - **(tasks)** stop CLI group after first failure without --continue-on-error by @jdx in [#6270](jdx/mise#6270) ### 📚 Documentation - fixed toml issues in URL replacements settings documentation by @ThomasSteinbach in [#6269](jdx/mise#6269) ### Chore - **(schema)** strict oneOf branches and DRY env_directive in schemas by @jdx in [#6271](jdx/mise#6271) - add schema linter by @risu729 in [#6267](jdx/mise#6267) ## [2025.9.8](https://github.com/jdx/mise/compare/v2025.9.7..v2025.9.8) - 2025-09-10 ### 🐛 Bug Fixes - **(tasks)** prevent hang when task fails in sequence by @jdx in [#6260](jdx/mise#6260) - **(version)** fetch mise version if cached version is older than the current by @risu729 in [#6252](jdx/mise#6252) ### 📦️ Dependency Updates - update rhysd/action-setup-vim action to v1.4.3 by @renovate[bot] in [#6249](jdx/mise#6249) ## [2025.9.7](https://github.com/jdx/mise/compare/v2025.9.6..v2025.9.7) - 2025-09-09 ### 🐛 Bug Fixes - **(env)** allow mixed map for env._.file by @risu729 in [#6148](jdx/mise#6148) - **(tasks)** restore parallel starts with poetry via list_paths cache and stable exec-env cache by @jdx in [#6237](jdx/mise#6237) - add 'unknown' to the list of OS patterns by @efussi in [#6235](jdx/mise#6235) - propagate errors from backend installs by @jdx in [#6236](jdx/mise#6236) ### 📦️ Dependency Updates - update taiki-e/install-action digest to 0c5db7f by @renovate[bot] in [#6244](jdx/mise#6244) - update golang docker tag to v1.25.1 by @renovate[bot] in [#6247](jdx/mise#6247) - update dependency vitepress to v1.6.4 by @renovate[bot] in [#6246](jdx/mise#6246) ### New Contributors - @efussi made their first contribution in [#6235](jdx/mise#6235)

Copilot AI review requested due to automatic review settings August 30, 2025 07:18

Copilot AI reviewed Aug 30, 2025

View reviewed changes

risu729 marked this pull request as draft September 5, 2025 11:01

risu729 force-pushed the env-path-fix branch from 4ad9415 to eb6c8bb Compare September 8, 2025 10:07

fix(env): allow complicated config for env._.path

db09624

risu729 force-pushed the env-path-fix branch from eb6c8bb to db09624 Compare September 8, 2025 23:23

risu729 added 6 commits September 9, 2025 10:11

test: add array of table test

06cafb9

test: add more cases

fed8fdc

fix: allow nested arrays for env directives

b1ccba9

test: reset mise.toml before subdir test

7f4b978

test: add nested test case for env._.file

2d8954e

fix(schema): allow nested env._.path and env._.source

b752927

risu729 marked this pull request as ready for review September 10, 2025 05:39

risu729 and others added 2 commits September 10, 2025 15:39

Merge branch 'main' into env-path-fix

dcacac0

[autofix.ci] apply automated fixes

02ebfb2

risu729 marked this pull request as draft September 10, 2025 10:11

risu729 added 2 commits September 11, 2025 12:02

refactor: simpify env directives deserialization

9f0d0b2

fix: remove unused change

dbf480e

risu729 changed the title ~~fix(env): allow complicated config for env._.path~~ fix(env): allow nested env._.path directives Sep 11, 2025

risu729 added 3 commits September 11, 2025 22:09

fix: use FromStr::parse in sequence deserializer

74deeeb

style: revert de::Deserialize import

d852afc

fix: add untagged

a81737b

risu729 marked this pull request as ready for review September 11, 2025 12:30

jdx reviewed Sep 11, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

cursor bot reviewed Sep 11, 2025

View reviewed changes

risu729 and others added 2 commits September 11, 2025 22:57

fix(schema): use def and allow paths

724aaaa

[autofix.ci] apply automated fixes

f895b33

jdx merged commit 8706f90 into jdx:main Sep 11, 2025
17 checks passed

risu729 deleted the env-path-fix branch September 11, 2025 16:08

jdx mentioned this pull request Sep 11, 2025

chore: release 2025.9.9 #6261

Merged

BrewTestBot mentioned this pull request Sep 11, 2025

mise 2025.9.9 Homebrew/homebrew-core#238533

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(env): allow nested env._.path directives#6160

fix(env): allow nested env._.path directives#6160
jdx merged 16 commits intojdx:mainfrom
risu729:env-path-fix

risu729 commented Aug 30, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

jdx commented Sep 5, 2025

Uh oh!

risu729 commented Sep 5, 2025

Uh oh!

jdx commented Sep 5, 2025

Uh oh!

risu729 commented Sep 5, 2025

Uh oh!

risu729 commented Sep 11, 2025

Uh oh!

jdx commented Sep 11, 2025

Uh oh!

jdx Sep 11, 2025

Uh oh!

risu729 Sep 11, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

risu729 commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

jdx commented Sep 5, 2025

Uh oh!

risu729 commented Sep 5, 2025

Uh oh!

jdx commented Sep 5, 2025

Uh oh!

risu729 commented Sep 5, 2025

Uh oh!

risu729 commented Sep 11, 2025

Uh oh!

jdx commented Sep 11, 2025

Uh oh!

jdx Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

risu729 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

✅ Bugbot reviewed your changes and found no bugs!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

risu729 commented Aug 30, 2025 •

edited

Loading