feat(aqua): extract aqua registry into internal subcrate

[jdx]

Summary

Extract src/aqua/aqua_registry.rs into crates/aqua-registry as a dedicated internal workspace crate to improve modularity and provide a clean API surface.

• Created crates/aqua-registry as internal, non-publishable workspace crate
• Implemented trait abstractions (RegistryFetcher, CacheStore) for dependency injection
• Decoupled platform-specific code with default parameters
• Feature-gated optional functionality (http, cache features)
• Maintained baked registry integration with build script
• Created compatibility wrapper preserving original API
• All existing functionality and tests preserved (271/271 passing)

Key Changes

• New crate structure: Clean separation with trait-based dependency injection
• Backward compatibility: Zero breaking changes to existing API
• Modularity: Platform-agnostic core with configurable backends
• Build integration: Compile-time registry baking maintained
• Feature flags: Optional HTTP and caching capabilities

Test Results

• ✅ All 271 unit tests passing
• ✅ Lint-fix completed successfully
• ✅ Build and compilation working
• ✅ E2E functionality preserved

🤖 Generated with Claude Code

[Copilot]

Pull Request Overview

Extracts the aqua registry implementation from the main codebase into a dedicated internal workspace crate crates/aqua-registry to improve modularity and provide better API abstraction. This refactoring maintains all existing functionality while introducing trait-based dependency injection for extensibility.

• Restructured aqua registry code into standalone internal crate with trait abstractions
• Maintained build-time registry baking functionality with dedicated build script
• Created compatibility wrapper preserving existing API surface for seamless integration

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/cli/doctor/mod.rs	Updated import path to use new aqua-registry crate
src/backend/aqua.rs	Updated imports and method calls to use wrapper API
src/aqua/mod.rs	Renamed module from aqua_registry to aqua_registry_wrapper
src/aqua/aqua_registry_wrapper.rs	New compatibility wrapper providing mise-specific functionality
crates/aqua-registry/src/types.rs	Core type definitions and package logic moved to dedicated crate
crates/aqua-registry/src/template.rs	Template parsing and rendering functionality
crates/aqua-registry/src/registry.rs	Main registry implementation with trait-based architecture
crates/aqua-registry/src/lib.rs	Public API and configuration for the aqua-registry crate
crates/aqua-registry/build.rs	Build script for baking registry files at compile time
crates/aqua-registry/Cargo.toml	Crate configuration with feature flags for optional functionality
Cargo.toml	Added new aqua-registry workspace member with http feature

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The with_version method signature has changed to require os and arch parameters. This API change should be documented to ensure consumers understand the new required parameters, especially since the method previously didn't require platform information.

[Copilot]

The asset_strs method signature has been updated to include os and arch parameters. This is a breaking change to the API that should be clearly documented, as it affects how checksum assets are resolved based on platform.

Suggested change

	let asset_strs = checksum.asset_strs(pkg, v, os(), arch())?;
	let asset_strs = checksum.asset_strs(pkg, v, OS, ARCH)?;

[Copilot]

The with_version method now requires os and arch parameters but doesn't validate these inputs. Consider adding validation to ensure these parameters contain expected values (e.g., known OS/architecture combinations) to prevent silent failures.

Suggested change

	pub fn with_version(mut self, versions: &[&str], os: &str, arch: &str) -> AquaPackage {
	pub fn with_version(mut self, versions: &[&str], os: &str, arch: &str) -> AquaPackage {
	// List of known OS and architecture values (can be expanded as needed)
	const VALID_OSES: &[&str] = &[
	"linux", "windows", "macos", "darwin", "freebsd", "openbsd", "netbsd", "dragonfly", "solaris", "android", "ios"
	];
	const VALID_ARCHS: &[&str] = &[
	"x86", "x86_64", "amd64", "arm", "arm64", "aarch64", "mips", "mips64", "powerpc", "powerpc64", "s390x", "riscv64"
	];
	if !VALID_OSES.contains(&os) {
	log::error!("Invalid OS parameter passed to with_version: '{}'", os);
	panic!("Invalid OS parameter passed to with_version: '{}'", os);
	}
	if !VALID_ARCHS.contains(&arch) {
	log::error!("Invalid architecture parameter passed to with_version: '{}'", arch);
	panic!("Invalid architecture parameter passed to with_version: '{}'", arch);
	}

[Copilot]

This method signature change introduces platform-specific parameters but doesn't validate the os and arch inputs. Consider adding validation or using an enum type to ensure only valid platform combinations are accepted.

[github-actions]

Hyperfine Performance

mise x -- echo

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.9.10 x -- echo	19.5 ± 0.4	18.9	21.7	1.00
mise x -- echo	19.8 ± 1.0	18.8	34.8	1.02 ± 0.05

mise env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.9.10 env	18.8 ± 0.3	18.3	20.7	1.00
mise env	19.0 ± 0.4	18.3	22.8	1.01 ± 0.03

mise hook-env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.9.10 hook-env	18.4 ± 0.3	17.8	20.6	1.00
mise hook-env	18.6 ± 0.9	17.9	33.7	1.01 ± 0.05

mise ls

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2025.9.10 ls	16.4 ± 0.3	15.8	17.6	1.00
mise ls	16.5 ± 0.3	15.8	17.5	1.01 ± 0.03

xtasks/test/perf

Command	mise-2025.9.10	mise	Variance
install (cached)	167ms	✅ 104ms	+60%
ls (cached)	64ms	62ms	+3%
bin-paths (cached)	69ms	70ms	-1%
task-ls (cached)	481ms	467ms	+2%

✅ Performance improvement: install cached is 60%