Skip to content

feat(tasks): make auto outputs default#6137

Merged
jdx merged 9 commits intojdx:mainfrom
risu729:task-outputs-default-auto
Sep 13, 2025
Merged

feat(tasks): make auto outputs default#6137
jdx merged 9 commits intojdx:mainfrom
risu729:task-outputs-default-auto

Conversation

@risu729
Copy link
Contributor

@risu729 risu729 commented Aug 27, 2025

This makes { auto = true } the default for task outputs.
Since only setting sources doesn't affect anything, I think we can safely make it the default.

Even if sources is not set, outputs is set to { auto = true }, but I don't think this is a problem.
The auto-tracked file won't be created if sources is empty, and it seems all related codes return early if sources is empty.

I preserved the { auto = true } syntax for backwards compatibility, but I think we don't need to make it deprecated, as it's useful to make it explicit in the config.
We can remove this for now, but should I?

toml::Value::Table(table) => {
let auto = table
.get("auto")
.and_then(|v| v.as_bool())
.unwrap_or_default();
if auto {
TaskOutputs::Auto
} else {
TaskOutputs::default()
}
}

This will change mise tasks info output; the auto-tracked outputs path will be printed every time.

@risu729
Copy link
Contributor Author

risu729 commented Aug 27, 2025

If there're no use-cases for outputs: [], maybe it's simpler to make { auto = true } the default behaviour for it.

@jdx
Copy link
Owner

jdx commented Sep 6, 2025

bugbot run

cursor[bot]

This comment was marked as outdated.

@jdx jdx enabled auto-merge (squash) September 6, 2025 12:27
@risu729
Copy link
Contributor Author

risu729 commented Sep 6, 2025

This doesn't work well with tests, so I think it's better to write a deserializer.

Copilot AI review requested due to automatic review settings September 12, 2025 08:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes auto = true the default behavior for task outputs in mise task configuration. Previously, the default was an empty file list, but now tasks will automatically track outputs using an internal hash-based system.

  • Changes the default TaskOutputs from Files(vec![]) to Auto
  • Updates freshness checking logic to handle the new default
  • Updates test expectations to reflect the new auto-tracking behavior

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/task/task_sources.rs Changes default TaskOutputs enum variant from Files to Auto using derive macro
src/cli/run.rs Simplifies sources freshness check by removing empty outputs condition
e2e/tasks/test_task_run_sources Adds test case for auto outputs behavior without explicit configuration
e2e/tasks/test_task_ls Updates JSON output expectations to show auto outputs instead of empty arrays
e2e/tasks/test_task_info Updates task info output expectations to include auto-tracked output paths
e2e/tasks/test_task_deps Updates task dependency output to include auto-tracked output paths
docs/tasks/task-configuration.md Documents the new default behavior and updates examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

auto-merge was automatically disabled September 12, 2025 08:55

Head branch was pushed to by a user without write access

@risu729 risu729 force-pushed the task-outputs-default-auto branch from 5f8688a to 813c871 Compare September 12, 2025 08:55
@risu729
Copy link
Contributor Author

risu729 commented Sep 12, 2025

I refactored to use render for postprocessing.
I don't like this, but it should work. Since serde doesn't support this kind of default value, it would be complicated.

@jdx
Copy link
Owner

jdx commented Sep 13, 2025

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@jdx jdx merged commit 1e33333 into jdx:main Sep 13, 2025
19 checks passed
@jdx jdx mentioned this pull request Sep 13, 2025
@risu729 risu729 deleted the task-outputs-default-auto branch September 13, 2025 20:38
@jdx jdx mentioned this pull request Sep 15, 2025
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 19, 2025
## [2025.9.12](https://github.com/jdx/mise/compare/v2025.9.11..v2025.9.12) - 2025-09-16

### 🐛 Bug Fixes

- **(ci)** properly exclude aqua-registry files from hk linting by @jdx in [42d7758](jdx/mise@42d7758)

### Chore

- **(release)** embed aqua-registry under crate and publish like vfox by @jdx in [#6306](jdx/mise#6306)
- ignore aqua-registry assets from prettier by @jdx in [047d77b](jdx/mise@047d77b)
- disable "useless cat" shellcheck by @jdx in [a6def59](jdx/mise@a6def59)

## [2025.9.11](https://github.com/jdx/mise/compare/v2025.9.10..v2025.9.11) - 2025-09-16

### 📦 Registry

- indicate aws-cli is v2 by @jayvdb in [#6300](jdx/mise#6300)

### 🚀 Features

- **(ci)** run all registry tools when workflow_dispatch is triggered by @jdx in [#6295](jdx/mise#6295)
- **(cli)** handle non-existent working directories gracefully by @jdx in [#6304](jdx/mise#6304)
- **(set)** add -E/--env flag to mise set command by @jdx in [#6291](jdx/mise#6291)
- **(tasks)** make auto outputs default by @risu729 in [#6137](jdx/mise#6137)

### 🐛 Bug Fixes

- align crate versions to fix release-plz script by @jdx in [5a464e9](jdx/mise@5a464e9)

### 🚜 Refactor

- **(aqua)** extract aqua registry into internal subcrate by @jdx in [#6293](jdx/mise#6293)

### 📚 Documentation

- fix mkdir paths by @risu729 in [#6298](jdx/mise#6298)
- fix rust profile default by @risu729 in [#6305](jdx/mise#6305)

### Chore

- **(aqua-registry)** remove unused aqua-registry files by @jdx in [#6294](jdx/mise#6294)
- **(release)** make release-plz idempotent for existing crate versions by @jdx in [dbdfd6a](jdx/mise@dbdfd6a)
- **(release)** skip publishing mise when aqua-registry is a path dep by @jdx in [47efffd](jdx/mise@47efffd)
- keep aqua-registry LICENSE file by @risu729 in [#6297](jdx/mise#6297)

### New Contributors

- @jayvdb made their first contribution in [#6300](jdx/mise#6300)

## [2025.9.10](https://github.com/jdx/mise/compare/v2025.9.9..v2025.9.10) - 2025-09-13

### 📦 Registry

- use asdf to install semver-tool by @jylenhof in [#6233](jdx/mise#6233)

### 🐛 Bug Fixes

- **(tool-stub)** detect binary names from single-file downloads by @jdx in [#6281](jdx/mise#6281)

### 🚜 Refactor

- allow any collection types in deserialize_arr by @risu729 in [#6282](jdx/mise#6282)
- use deserialize_arr for task runs by @risu729 in [#6253](jdx/mise#6253)

### 📚 Documentation

- **(getting-started)** add backends step with diagram, github example, env vars and simple tasks by @jdx in [#6288](jdx/mise#6288)
- simplify OS detection in tool plugin development by @jdx in [#6287](jdx/mise#6287)
- update backend plugin template references by @jdx in [942f5eb](jdx/mise@942f5eb)

### 📦️ Dependency Updates

- update rust crate chrono to v0.4.42 by @renovate[bot] in [#6274](jdx/mise#6274)
- update taiki-e/install-action digest to 0154864 by @renovate[bot] in [#6273](jdx/mise#6273)

### Chore

- **(schema)** fix schema for subtasks by @risu729 in [#6289](jdx/mise#6289)
- update render:schema task by @risu729 in [#6275](jdx/mise#6275)

## [2025.9.9](https://github.com/jdx/mise/compare/v2025.9.8..v2025.9.9) - 2025-09-11

### 🐛 Bug Fixes

- **(backend)** make HTTP installs atomic and serialize with cache lock by @jdx in [#6259](jdx/mise#6259)
- **(env)** allow nested env._.path directives by @risu729 in [#6160](jdx/mise#6160)
- **(env)** disallow nested env objects by @risu729 in [#6268](jdx/mise#6268)
- **(schema)** allow nested arrays in task.depends by @risu729 in [#6265](jdx/mise#6265)
- **(task)** resolve jobs=1 hang and keep-order panic; improve Ctrl-C handling by @jdx in [#6264](jdx/mise#6264)
- **(tasks)** stop CLI group after first failure without --continue-on-error by @jdx in [#6270](jdx/mise#6270)

### 📚 Documentation

- fixed toml issues in URL replacements settings documentation by @ThomasSteinbach in [#6269](jdx/mise#6269)

### Chore

- **(schema)** strict oneOf branches and DRY env_directive in schemas by @jdx in [#6271](jdx/mise#6271)
- add schema linter by @risu729 in [#6267](jdx/mise#6267)

## [2025.9.8](https://github.com/jdx/mise/compare/v2025.9.7..v2025.9.8) - 2025-09-10

### 🐛 Bug Fixes

- **(tasks)** prevent hang when task fails in sequence by @jdx in [#6260](jdx/mise#6260)
- **(version)** fetch mise version if cached version is older than the current by @risu729 in [#6252](jdx/mise#6252)

### 📦️ Dependency Updates

- update rhysd/action-setup-vim action to v1.4.3 by @renovate[bot] in [#6249](jdx/mise#6249)

## [2025.9.7](https://github.com/jdx/mise/compare/v2025.9.6..v2025.9.7) - 2025-09-09

### 🐛 Bug Fixes

- **(env)** allow mixed map for env._.file by @risu729 in [#6148](jdx/mise#6148)
- **(tasks)** restore parallel starts with poetry via list_paths cache and stable exec-env cache by @jdx in [#6237](jdx/mise#6237)
- add 'unknown' to the list of OS patterns by @efussi in [#6235](jdx/mise#6235)
- propagate errors from backend installs by @jdx in [#6236](jdx/mise#6236)

### 📦️ Dependency Updates

- update taiki-e/install-action digest to 0c5db7f by @renovate[bot] in [#6244](jdx/mise#6244)
- update golang docker tag to v1.25.1 by @renovate[bot] in [#6247](jdx/mise#6247)
- update dependency vitepress to v1.6.4 by @renovate[bot] in [#6246](jdx/mise#6246)

### New Contributors

- @efussi made their first contribution in [#6235](jdx/mise#6235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants