Add OCP-specific flag to CreateRemoteSecret

[unsortedhashsets]

What type of PR is this?

• Enhancement / New Feature
• Bug Fix
• Refactor
• Optimization
• Test
• Documentation Update

What this PR does / why we need it:

Use the '--create-service-account=false' flag when creating remote secrets on OpenShift.

Allows to avoid OCP specific failures:

[FAILED] Unexpected error:
      <*errors.errorString | 0xc003a3a970>: 
      error executing command: /usr/bin/sh -c /home/jenkins/workspace/sail/sail-operator-e2e-tests/sail-operator/bin/istioctl create-remote-secret --kubeconfig /home/jenkins/workspace/sail/sail-operator-e2e-tests/kubeconfig2.yaml --namespace istio-system --name remote --server=https://api.user-rhos-d-5.servicemesh.rhqeaws.com:6443/: error: could not get access token to read resources from local kube-apiserver: '--create-service-account=false' should be set when using OpenShift Service Mesh Operator
      Error: could not get access token to read resources from local kube-apiserver: '--create-service-account=false' should be set when using OpenShift Service Mesh Operator

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

https://issues.redhat.com/browse/OSSM-8193

Additional information:

[istio-testing]

Hi @unsortedhashsets. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fjglira]

lgtm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.39%. Comparing base (eebb1d5) to head (9a54413).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
- Coverage   77.50%   77.39%   -0.11%     
==========================================
  Files          44       44              
  Lines        2823     2823              
==========================================
- Hits         2188     2185       -3     
- Misses        527      529       +2     
- Partials      108      109       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.