Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27#1215
Conversation
Use the '--create-service-account=false' flag when creating remote secrets on OpenShift. Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
This change allows setting the multicluster flag via environment variables. Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
|
Hi @unsortedhashsets. Thanks for your PR. I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.27 #1215 +/- ##
================================================
- Coverage 77.74% 77.42% -0.32%
================================================
Files 44 44
Lines 2817 2817
================================================
- Hits 2190 2181 -9
- Misses 521 528 +7
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
ca25e95
into
istio-ecosystem:release-1.27
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
* upstream/release-1.27: Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
Cherry-picks the following commits from
maintorelease-1.27:e17bcfc: Add OCP-specific flag to CreateRemoteSecret (Add OCP-specific flag to CreateRemoteSecret #1213)
Use the '--create-service-account=false' flag when creating remote secrets on OpenShift.
eebb1d5: Allow set multicluster flag with env (Allow set multicluster flag with env #1212)
This change allows setting the multicluster flag via environment variables.