Skip to content

Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27#1215

Merged
istio-testing merged 2 commits intoistio-ecosystem:release-1.27from
unsortedhashsets:cherry-pick-to-1.27
Sep 11, 2025
Merged

Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27#1215
istio-testing merged 2 commits intoistio-ecosystem:release-1.27from
unsortedhashsets:cherry-pick-to-1.27

Conversation

@unsortedhashsets
Copy link
Copy Markdown
Contributor

Cherry-picks the following commits from main to release-1.27:

Use the '--create-service-account=false' flag when creating remote secrets on OpenShift.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
This change allows setting the multicluster flag via environment variables.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @unsortedhashsets. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.42%. Comparing base (16ec758) to head (8d04d81).
⚠️ Report is 1 commits behind head on release-1.27.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #1215      +/-   ##
================================================
- Coverage         77.74%   77.42%   -0.32%     
================================================
  Files                44       44              
  Lines              2817     2817              
================================================
- Hits               2190     2181       -9     
- Misses              521      528       +7     
- Partials            106      108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fjglira
Copy link
Copy Markdown
Contributor

fjglira commented Sep 11, 2025

/ok-to-test

@istio-testing istio-testing merged commit ca25e95 into istio-ecosystem:release-1.27 Sep 11, 2025
17 of 18 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 15, 2025
* upstream/release-1.27:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 (istio-ecosystem#1215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants