Skip to content

Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26#1214

Merged
istio-testing merged 2 commits intoistio-ecosystem:release-1.26from
unsortedhashsets:cherry-pick-to-1.26
Sep 11, 2025
Merged

Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26#1214
istio-testing merged 2 commits intoistio-ecosystem:release-1.26from
unsortedhashsets:cherry-pick-to-1.26

Conversation

@unsortedhashsets
Copy link
Copy Markdown
Contributor

@unsortedhashsets unsortedhashsets commented Sep 11, 2025

Cherry-picks the following commits from main to release-1.26:

@unsortedhashsets
Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
82de8dc 
Use the '--create-service-account=false' flag when creating remote secrets on OpenShift.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
@unsortedhashsets
Allow set multicluster flag with env (istio-ecosystem#1212)
ab696e1 
This change allows setting the multicluster flag via environment variables.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
@unsortedhashsets unsortedhashsets requested a review from a team as a code owner September 11, 2025 11:34
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Sep 11, 2025

Hi @unsortedhashsets. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.42%. Comparing base (af95b3c) to head (ab696e1).
⚠️ Report is 1 commits behind head on release-1.26.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.26    #1214      +/-   ##
================================================
+ Coverage         77.31%   77.42%   +0.10%     
================================================
  Files                44       44              
  Lines              2791     2791              
================================================
+ Hits               2158     2161       +3     
+ Misses              525      523       -2     
+ Partials            108      107       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fjglira
Copy link
Copy Markdown
Contributor

fjglira commented Sep 11, 2025

/ok-to-test

@unsortedhashsets
Copy link
Copy Markdown
Contributor Author

unsortedhashsets commented Sep 11, 2025

/test e2e-kind

@istio-testing istio-testing merged commit 92bb907 into istio-ecosystem:release-1.26 Sep 11, 2025
18 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
619d284 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
de5e6ce 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
aa71996 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
2777fcc 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
1231989 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
57e0a83 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
788eb77 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
68c2259 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 15, 2025
Automated merge
5c3b46d 
* upstream/release-1.26:
  Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)
openshift-merge-bot bot added a commit to openshift-service-mesh/sail-operator that referenced this pull request Oct 21, 2025
@mkralik3 @unsortedhashsets
@openshift-merge-bot @istio-testing @fjglira @openshift-service-mesh-bot @ctartici
Update lpinterop branch with release-3.1.3 (#562)
bb560e7 
* Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)

* Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)

Use the '--create-service-account=false' flag when creating remote secrets on OpenShift.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

* Allow set multicluster flag with env (istio-ecosystem#1212)

This change allows setting the multicluster flag via environment variables.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

---------

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

* [release-1.26] Fix junit report generation (istio-ecosystem#1219)

* Fix junit report generation

Fix the junit report generation for every test run for our e2e test execution

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* Fix lint

Fixing lint error

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

---------

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Co-authored-by: Francisco Herrera <fjglira@gmail.com>

* [release-3.1] Bump version and update GA images (#516)

* Fix new lint errors (istio-ecosystem#1234)

Fix lint error that are happening in the PR: 1231

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Co-authored-by: Francisco Herrera <fjglira@gmail.com>

* Adding check_cluster_operators for OCP clusters (istio-ecosystem#1238) (istio-ecosystem#1243)

Adding check_cluster_operators will help to avoid test run issues while executing the test over OCP clusters

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* [release-3.1] Automator: Update Istio module (#522)

Co-authored-by: openshift-service-mesh-bot <null>

* [3.1.3] Prepare placeholders for OSSM 3.1.3 release without istio changes (#540)

---------

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Co-authored-by: Mikhail Abramov <mabramov@redhat.com>
Co-authored-by: openshift-service-mesh-bot <null>
Co-authored-by: openshift-merge-bot[bot] <148852131+openshift-merge-bot[bot]@users.noreply.github.com>
Co-authored-by: Istio Automation <istio-testing-bot@google.com>
Co-authored-by: Francisco Herrera <fjglira@gmail.com>
Co-authored-by: openshift-service-mesh-bot <165402251+openshift-service-mesh-bot@users.noreply.github.com>
Co-authored-by: Cansin Tartici <ctartici@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjglira fjglira fjglira approved these changes

Assignees

No one assigned

Labels

ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@unsortedhashsets @istio-testing @fjglira