Skip to content

[release-1.26] Fix new lint errors#1234

Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.26from
istio-testing:cherry-pick-1233-to-release-1.26
Sep 26, 2025
Merged

[release-1.26] Fix new lint errors#1234
istio-testing merged 1 commit intoistio-ecosystem:release-1.26from
istio-testing:cherry-pick-1233-to-release-1.26

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

This is an automated cherry-pick of #1233

Fix lint error that are happening in the PR: 1231

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
@istio-testing istio-testing force-pushed the cherry-pick-1233-to-release-1.26 branch from 71e3efa to d3759c6 Compare September 26, 2025 07:43
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.10%. Comparing base (18299ed) to head (d3759c6).
⚠️ Report is 1 commits behind head on release-1.26.

Files with missing lines Patch % Lines
controllers/istio/istio_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.26    #1234      +/-   ##
================================================
+ Coverage         77.03%   77.10%   +0.07%     
================================================
  Files                44       44              
  Lines              2791     2791              
================================================
+ Hits               2150     2152       +2     
+ Misses              531      529       -2     
  Partials            110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@istio-testing istio-testing merged commit 769323b into istio-ecosystem:release-1.26 Sep 26, 2025
17 of 18 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 26, 2025
* upstream/release-1.26:
  Fix new lint errors (istio-ecosystem#1234)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 26, 2025
* upstream/release-1.26:
  Fix new lint errors (istio-ecosystem#1234)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 26, 2025
* upstream/release-1.26:
  Fix new lint errors (istio-ecosystem#1234)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 26, 2025
* upstream/release-1.26:
  Fix new lint errors (istio-ecosystem#1234)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 29, 2025
* upstream/release-1.26:
  Fix new lint errors (istio-ecosystem#1234)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 29, 2025
* upstream/release-1.26:
  Fix new lint errors (istio-ecosystem#1234)
openshift-merge-bot bot added a commit to openshift-service-mesh/sail-operator that referenced this pull request Oct 21, 2025
* Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214)

* Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)

Use the '--create-service-account=false' flag when creating remote secrets on OpenShift.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

* Allow set multicluster flag with env (istio-ecosystem#1212)

This change allows setting the multicluster flag via environment variables.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

---------

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

* [release-1.26] Fix junit report generation (istio-ecosystem#1219)

* Fix junit report generation

Fix the junit report generation for every test run for our e2e test execution

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* Fix lint

Fixing lint error

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

---------

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Co-authored-by: Francisco Herrera <fjglira@gmail.com>

* [release-3.1] Bump version and update GA images (#516)

* Fix new lint errors (istio-ecosystem#1234)

Fix lint error that are happening in the PR: 1231

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Co-authored-by: Francisco Herrera <fjglira@gmail.com>

* Adding check_cluster_operators for OCP clusters (istio-ecosystem#1238) (istio-ecosystem#1243)

Adding check_cluster_operators will help to avoid test run issues while executing the test over OCP clusters

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* [release-3.1] Automator: Update Istio module (#522)

Co-authored-by: openshift-service-mesh-bot <null>

* [3.1.3] Prepare placeholders for OSSM 3.1.3 release without istio changes (#540)

---------

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Co-authored-by: Mikhail Abramov <mabramov@redhat.com>
Co-authored-by: openshift-service-mesh-bot <null>
Co-authored-by: openshift-merge-bot[bot] <148852131+openshift-merge-bot[bot]@users.noreply.github.com>
Co-authored-by: Istio Automation <istio-testing-bot@google.com>
Co-authored-by: Francisco Herrera <fjglira@gmail.com>
Co-authored-by: openshift-service-mesh-bot <165402251+openshift-service-mesh-bot@users.noreply.github.com>
Co-authored-by: Cansin Tartici <ctartici@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants