Skip to content

Fix junit report generation#1218

Merged
istio-testing merged 2 commits intoistio-ecosystem:mainfrom
fjglira:fix-junit-report
Sep 12, 2025
Merged

Fix junit report generation#1218
istio-testing merged 2 commits intoistio-ecosystem:mainfrom
fjglira:fix-junit-report

Conversation

@fjglira
Copy link
Copy Markdown
Contributor

@fjglira fjglira commented Sep 12, 2025

Fix the junit report generation for every test run for our e2e test execution

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

We are having issues generating the Junit report for test executions. This PR aims to fix these issues to ensure the report is generated whatever the test execution pass or fails

Which issue(s) this PR fixes:

Fixes #1217

Related Issue/PR #

Additional information:

Fix the junit report generation for every test run for our e2e test execution

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
@fjglira fjglira requested a review from a team as a code owner September 12, 2025 14:11
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.61%. Comparing base (5fe7836) to head (de98cfd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   77.50%   77.61%   +0.10%     
==========================================
  Files          44       44              
  Lines        2823     2823              
==========================================
+ Hits         2188     2191       +3     
+ Misses        527      525       -2     
+ Partials      108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fixing lint error

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
@istio-testing istio-testing merged commit fe35478 into istio-ecosystem:main Sep 12, 2025
17 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
* upstream/main:
  Fix junit report generation (istio-ecosystem#1218)
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 15, 2025
* upstream/main:
  Fix junit report generation (istio-ecosystem#1218)
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request created: #1219

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: #1218 failed to apply on top of branch "release-1.25":

Applying: Fix junit report generation
Using index info to reconstruct a base tree...
M	tests/e2e/common-operator-integ-suite.sh
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/common-operator-integ-suite.sh
CONFLICT (content): Merge conflict in tests/e2e/common-operator-integ-suite.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix junit report generation

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new issue created for failed cherrypick: #1220

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio-ecosystem/sail-operator#release-1.26 from head istio-testing:cherry-pick-1218-to-release-1.26: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1218-to-release-1.26."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request created: #1221

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio-ecosystem/sail-operator#release-1.26 from head istio-testing:cherry-pick-1218-to-release-1.26: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1218-to-release-1.26."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio-ecosystem/sail-operator#release-1.27 from head istio-testing:cherry-pick-1218-to-release-1.27: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1218-to-release-1.27."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

1 similar comment
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio-ecosystem/sail-operator#release-1.27 from head istio-testing:cherry-pick-1218-to-release-1.27: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1218-to-release-1.27."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

FilipB pushed a commit to FilipB/sail-operator that referenced this pull request Nov 27, 2025
* Fix junit report generation

Fix the junit report generation for every test run for our e2e test execution

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* Fix lint

Fixing lint error

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

---------

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Filip Brychta <fbrychta@redhat.com>
FilipB pushed a commit to FilipB/sail-operator that referenced this pull request Nov 28, 2025
* Fix junit report generation

Fix the junit report generation for every test run for our e2e test execution

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* Fix lint

Fixing lint error

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

---------

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Filip Brychta <fbrychta@redhat.com>
istio-testing pushed a commit that referenced this pull request Nov 28, 2025
* Fix junit report generation

Fix the junit report generation for every test run for our e2e test execution



* Fix lint

Fixing lint error



---------

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Filip Brychta <fbrychta@redhat.com>
Co-authored-by: Francisco Herrera <fjglira@gmail.com>
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 28, 2025
* upstream/release-1.0:
  Fix junit report generation (istio-ecosystem#1218) (istio-ecosystem#1412)
  [release-1.0] feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1401)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Nov 28, 2025
* upstream/release-1.0:
  Fix junit report generation (istio-ecosystem#1218) (istio-ecosystem#1412)
  [release-1.0] feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1401)
dgn pushed a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026
* Fix junit report generation

Fix the junit report generation for every test run for our e2e test execution

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

* Fix lint

Fixing lint error

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

---------

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] It's not being generated the E2E junit file

3 participants