Skip to content

Fix macOS compatibility for update_deps.sh and update macOS specific dev docs#1137

Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
fjglira:more-macos-fix
Sep 9, 2025
Merged

Fix macOS compatibility for update_deps.sh and update macOS specific dev docs#1137
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
fjglira:more-macos-fix

Conversation

@fjglira
Copy link
Copy Markdown
Contributor

@fjglira fjglira commented Aug 19, 2025

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

This PR adds:

  • Update macOS documentation with workaround for update-common shell errors. On macOS, you may find some issues while running locally the update-common target
  • Fix sed -i commands in update_deps.sh to work on both BSD (macOS) and GNU (Linux) sed

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

@fjglira
Fix macOS compatibility for update_deps.sh and update macOS specific …
afa2470 
…dev docs

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
@fjglira fjglira requested a review from a team as a code owner August 19, 2025 10:06
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.84%. Comparing base (eda29bb) to head (afa2470).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
+ Coverage   77.74%   77.84%   +0.10%     
==========================================
  Files          44       44              
  Lines        2808     2808              
==========================================
+ Hits         2183     2186       +3     
+ Misses        520      518       -2     
+ Partials      105      104       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fjglira
Copy link
Copy Markdown
Contributor Author

fjglira commented Aug 19, 2025

/test docs-test

2 similar comments
@fjglira
Copy link
Copy Markdown
Contributor Author

fjglira commented Aug 19, 2025

/test docs-test

@fjglira
Copy link
Copy Markdown
Contributor Author

fjglira commented Sep 1, 2025

/test docs-test

pbajjuri20
pbajjuri20 approved these changes Sep 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..!

dgn
dgn approved these changes Sep 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping as @Dimss approved

@istio-testing istio-testing merged commit 90c02f7 into istio-ecosystem:main Sep 9, 2025
16 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 9, 2025
Automated merge
fd15855 
* upstream/main:
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 9, 2025
Automated merge
769d520 
* upstream/main:
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 10, 2025
Automated merge
cd115fe 
* upstream/main:
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 10, 2025
Automated merge
43c6a00 
* upstream/main:
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 10, 2025
Automated merge
db9d5d7 
* upstream/main:
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 10, 2025
Automated merge
4e55503 
* upstream/main:
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 10, 2025
Automated merge
1c2a015 
* upstream/main:
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 10, 2025
Automated merge
d95a64f 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 10, 2025
Automated merge
686ff81 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 10, 2025
Automated merge
d13231b 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
9d934b5 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
939d5be 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
d73a862 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
c517b7b 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
6dfa788 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
671e8d2 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
b713723 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 11, 2025
Automated merge
bb04111 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
046103b 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
c1687f8 
* upstream/main:
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
4dd1aa7 
* upstream/main:
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
ebf5719 
* upstream/main:
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
848b21e 
* upstream/main:
  Fix junit report generation (istio-ecosystem#1218)
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 15, 2025
Automated merge
55e3fc1 
* upstream/main:
  Fix junit report generation (istio-ecosystem#1218)
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
dgn pushed a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026
@fjglira @dgn
Fix macOS compatibility for update_deps.sh and update macOS specific …
fb32f73 
…dev docs (istio-ecosystem#1137)

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgn dgn dgn approved these changes

@Dimss Dimss Dimss approved these changes

@pbajjuri20 pbajjuri20 pbajjuri20 approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fjglira @dgn @Dimss @pbajjuri20 @istio-testing