Skip to content

Remove explicit labelling for multicluster network#1216

Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
mkolesnik:multicluster-no-label
Sep 12, 2025
Merged

Remove explicit labelling for multicluster network#1216
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
mkolesnik:multicluster-no-label

Conversation

@mkolesnik
Copy link
Copy Markdown
Collaborator

@mkolesnik mkolesnik commented Sep 11, 2025

The network is already specified as part of the Istio CR and as such is passed to the Istio control plane when installed. The label seems not to be needed in such a case.

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

@mkolesnik
Remove explicit labelling for multicluster network
85e1abe 
The network is already specified as part of the `Istio` CR and as such
is passed to the Istio control plane when installed.
The label seems not to be needed in such a case.

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Sep 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mkolesnik
Copy link
Copy Markdown
Collaborator Author

mkolesnik commented Sep 11, 2025

/test all

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.50%. Comparing base (a38460c) to head (85e1abe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1216      +/-   ##
==========================================
- Coverage   77.61%   77.50%   -0.11%     
==========================================
  Files          44       44              
  Lines        2823     2823              
==========================================
- Hits         2191     2188       -3     
- Misses        525      527       +2     
- Partials      107      108       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkolesnik mkolesnik mentioned this pull request Sep 11, 2025
Merged
6 tasks
@mkolesnik mkolesnik marked this pull request as ready for review September 11, 2025 12:53
@mkolesnik mkolesnik requested a review from a team as a code owner September 11, 2025 12:53
fjglira
fjglira approved these changes Sep 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all the multicluster tests are passing, and they do not have any reference to labeling the namespace with the network label

@istio-testing istio-testing merged commit 5fe7836 into istio-ecosystem:main Sep 12, 2025
16 of 17 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
4dd1aa7 
* upstream/main:
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
ebf5719 
* upstream/main:
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 12, 2025
Automated merge
848b21e 
* upstream/main:
  Fix junit report generation (istio-ecosystem#1218)
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 15, 2025
Automated merge
55e3fc1 
* upstream/main:
  Fix junit report generation (istio-ecosystem#1218)
  Remove explicit labelling for multicluster network (istio-ecosystem#1216)
  feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203)
  Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213)
  Allow set multicluster flag with env (istio-ecosystem#1212)
  Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137)
  Add commit validation GH action (istio-ecosystem#1188)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)
@FilipB FilipB mentioned this pull request Sep 17, 2025
Open
dgn pushed a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026
@mkolesnik @dgn
Remove explicit labelling for multicluster network (istio-ecosystem#1216
58cc4d5 
)

The network is already specified as part of the `Istio` CR and as such
is passed to the Istio control plane when installed.
The label seems not to be needed in such a case.

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjglira fjglira fjglira approved these changes

Assignees

No one assigned

Labels

cherrypick/release-1.27 size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkolesnik @istio-testing @fjglira @FilipB