Allow set multicluster flag with env by unsortedhashsets · Pull Request #1212 · istio-ecosystem/sail-operator

unsortedhashsets · 2025-09-10T08:50:54Z

What type of PR is this?

What this PR does / why we need it:

Now in test run

export MULTICLUSTER="true"
make test.e2e.ocp

multicluster option will be ignored and stay false

PR allows to set MULTICLUSTER varialbe not only with arg as --multicluster but also with the ENV variable

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

https://issues.redhat.com/browse/OSSM-8193

Additional information:

istio-testing · 2025-09-10T08:51:12Z

Hi @unsortedhashsets. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This change allows setting the multicluster flag via environment variables. Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

codecov · 2025-09-10T09:00:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.61%. Comparing base (90c02f7) to head (cb305d2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
+ Coverage   77.39%   77.61%   +0.21%     
==========================================
  Files          44       44              
  Lines        2823     2823              
==========================================
+ Hits         2185     2191       +6     
+ Misses        529      525       -4     
+ Partials      109      107       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fjglira

LGTM, please do some test because I remember that it's possible that we need to tweak more stuff to be able to run multicluster test on OCP

* upstream/main: Allow set multicluster flag with env (istio-ecosystem#1212) Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137) Add commit validation GH action (istio-ecosystem#1188) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)

* upstream/main: feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203) Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213) Allow set multicluster flag with env (istio-ecosystem#1212) Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137) Add commit validation GH action (istio-ecosystem#1188) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)

This change allows setting the multicluster flag via environment variables. Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

* upstream/main: feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203) Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213) Allow set multicluster flag with env (istio-ecosystem#1212) Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137) Add commit validation GH action (istio-ecosystem#1188) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)

…ulticluster flag with env to release-1.27 (#1215) * Add OCP-specific flag to CreateRemoteSecret (#1213) Use the '--create-service-account=false' flag when creating remote secrets on OpenShift. Signed-off-by: Mikhail Abramov <mabramov@redhat.com> * Allow set multicluster flag with env (#1212) This change allows setting the multicluster flag via environment variables. Signed-off-by: Mikhail Abramov <mabramov@redhat.com> --------- Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

…ulticluster flag with env to release-1.26 (#1214) * Add OCP-specific flag to CreateRemoteSecret (#1213) Use the '--create-service-account=false' flag when creating remote secrets on OpenShift. Signed-off-by: Mikhail Abramov <mabramov@redhat.com> * Allow set multicluster flag with env (#1212) This change allows setting the multicluster flag via environment variables. Signed-off-by: Mikhail Abramov <mabramov@redhat.com> --------- Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

* upstream/main: feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203) Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213) Allow set multicluster flag with env (istio-ecosystem#1212) Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137) Add commit validation GH action (istio-ecosystem#1188) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)

* upstream/main: Remove explicit labelling for multicluster network (istio-ecosystem#1216) feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203) Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213) Allow set multicluster flag with env (istio-ecosystem#1212) Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137) Add commit validation GH action (istio-ecosystem#1188) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)

* upstream/main: Fix junit report generation (istio-ecosystem#1218) Remove explicit labelling for multicluster network (istio-ecosystem#1216) feat(tests): add cleanup target for e2e.ocp test artifacts closes istio-ecosystem#1164 (istio-ecosystem#1203) Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213) Allow set multicluster flag with env (istio-ecosystem#1212) Fix macOS compatibility for update_deps.sh and update macOS specific dev docs (istio-ecosystem#1137) Add commit validation GH action (istio-ecosystem#1188) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1208)

* Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 (istio-ecosystem#1214) * Add OCP-specific flag to CreateRemoteSecret (istio-ecosystem#1213) Use the '--create-service-account=false' flag when creating remote secrets on OpenShift. Signed-off-by: Mikhail Abramov <mabramov@redhat.com> * Allow set multicluster flag with env (istio-ecosystem#1212) This change allows setting the multicluster flag via environment variables. Signed-off-by: Mikhail Abramov <mabramov@redhat.com> --------- Signed-off-by: Mikhail Abramov <mabramov@redhat.com> * [release-1.26] Fix junit report generation (istio-ecosystem#1219) * Fix junit report generation Fix the junit report generation for every test run for our e2e test execution Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix lint Fixing lint error Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> * [release-3.1] Bump version and update GA images (#516) * Fix new lint errors (istio-ecosystem#1234) Fix lint error that are happening in the PR: 1231 Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> * Adding check_cluster_operators for OCP clusters (istio-ecosystem#1238) (istio-ecosystem#1243) Adding check_cluster_operators will help to avoid test run issues while executing the test over OCP clusters Signed-off-by: Francisco Herrera <fjglira@gmail.com> * [release-3.1] Automator: Update Istio module (#522) Co-authored-by: openshift-service-mesh-bot <null> * [3.1.3] Prepare placeholders for OSSM 3.1.3 release without istio changes (#540) --------- Signed-off-by: Mikhail Abramov <mabramov@redhat.com> Signed-off-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: Mikhail Abramov <mabramov@redhat.com> Co-authored-by: openshift-service-mesh-bot <null> Co-authored-by: openshift-merge-bot[bot] <148852131+openshift-merge-bot[bot]@users.noreply.github.com> Co-authored-by: Istio Automation <istio-testing-bot@google.com> Co-authored-by: Francisco Herrera <fjglira@gmail.com> Co-authored-by: openshift-service-mesh-bot <165402251+openshift-service-mesh-bot@users.noreply.github.com> Co-authored-by: Cansin Tartici <ctartici@redhat.com>

This change allows setting the multicluster flag via environment variables. Signed-off-by: Mikhail Abramov <mabramov@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

unsortedhashsets requested a review from a team as a code owner September 10, 2025 08:50

istio-testing added size/XS needs-ok-to-test labels Sep 10, 2025

unsortedhashsets force-pushed the e2e_multi_fix branch from 29d35ca to fe5114d Compare September 10, 2025 08:53

Allow set multicluster flag with env

cb305d2

This change allows setting the multicluster flag via environment variables. Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

unsortedhashsets force-pushed the e2e_multi_fix branch from fe5114d to cb305d2 Compare September 10, 2025 08:55

fjglira added the ok-to-test label Sep 10, 2025

fjglira approved these changes Sep 10, 2025

View reviewed changes

fjglira removed the needs-ok-to-test label Sep 10, 2025

istio-testing merged commit eebb1d5 into istio-ecosystem:main Sep 10, 2025
17 checks passed

fjglira added cherrypick/release-1.26 cherrypick/release-1.27 labels Sep 11, 2025

This was referenced Sep 11, 2025

Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.26 #1214

Merged

Cherry-pick: Add OCP-specific flag to CreateRemoteSecret, Allow set multicluster flag with env to release-1.27 #1215

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow set multicluster flag with env#1212

Allow set multicluster flag with env#1212
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
unsortedhashsets:e2e_multi_fix

unsortedhashsets commented Sep 10, 2025

Uh oh!

istio-testing commented Sep 10, 2025

Uh oh!

codecov bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

fjglira left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

unsortedhashsets commented Sep 10, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Additional information:

Uh oh!

istio-testing commented Sep 10, 2025

Uh oh!

codecov bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fjglira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Sep 10, 2025 •

edited

Loading