Repository navigation
Implement SDLC pipeline: worker dispatch, stage handlers, and integration tests - #84
Merged
Merged
Conversation
Three fixes to get `build_dsl_graph_with_profile("pipelines/sdlc.dag", "unit_test")` working:
1. **Transport blocks for services**: Added `transport rest { ... }` to
github/pull_request.dag (7 ops) and llm/openai.dag (2 ops). These
services are directly imported by the SDLC pipeline and need transport
specs for the lowerer to generate prepare/execute/parse triplets.
2. **Profile-scoped module loading**: `include_profile_modules()` now only
loads implementation modules for the active profile, not all profiles.
Previously, compiling with unit_test would also load codex_agent_provider,
github_issue_provider, etc. from the local/cloud_run profiles.
3. **InterfaceStub for service implementations**: Services using
`service Foo : BarInterface` syntax (implementing an interface) with no
transport block now get InterfaceStub transport class instead of Unknown.
This lets stub providers compile without explicit transport declarations.
Scouted: github/issues.dag also lacks transport blocks (needed for BT6/local profile).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BT2: Wire 3 empty stages in workflows/sdlc.dag (intake, worker, report) BT3: Hermetic scenario test — DryRun execution with unit_test profile BT4: Per-stage handler tests — structural validation of 8 handlers BT5: Worker dispatch tests — structural validation of dispatch loop BT6: Transport declarations — 26 ops across github, llm, file, shell BT7: Local integration tests (#[ignore], gated on GITHUB_TOKEN) BT8: Full lifecycle test (#[ignore], DryRun with local profile) BT9: Testgen integration — verify 5 SDLC modules auto-discovered BT10: CLI entrypoint — gunbc-sdlc --profile --repo --issue --dry-run All 259 lib tests + 15 SDLC tests pass. Clippy clean. https://claude.ai/code/session_01XmJNtYizWWs1HeGcPYxQWe
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fe1bbf776
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1. Point gunbc-sdlc CLI at workflows/sdlc.dag (worker-dispatch) instead of pipelines/sdlc.dag (issue-centric pipeline). The CLI advertises discover/dispatch behavior which matches the workflow DAG that calls dispatch_sdlc(), not the pipeline. 2. Remove optional --model and --approval-mode flags from Codex agent spawn argv. These are String? inputs — unconditionally including them produces invalid shell invocations when absent. 3. Add compilation test for workflows/sdlc.dag with unit_test profile. 4. Update integration tests to use workflows/sdlc.dag (matching CLI). Profile matching (review item 3): investigated and confirmed not a bug. Profile names are simple identifiers in both parser and CLI; the comparison in daglang-driver correctly matches them. https://claude.ai/code/session_01XmJNtYizWWs1HeGcPYxQWe
Extends the DSL config block with an optional base_path field.
When present, the lowerer prepends it to each operation's transport
path, eliminating repeated /repos/{owner}/{repo} prefixes.
Compiler changes (3 files):
- daglang-syntax: ServiceConfig.base_path field + parser branch
- daglang-lower: derive_rest_spec composes base_path + operation path
Migrated services:
- github/issues.dag: 7 ops, /repos/{owner}/{repo} → base_path
- github/pull_request.dag: 7 ops, same pattern
- sdlc/providers/github_issue_provider.dag: 7 ops, same pattern
Before: transport rest { method: GET, path: "/repos/\{owner\}/\{repo\}/issues/\{id\}" }
After: transport rest { method: GET, path: "/issues/\{id\}" }
All 260 lib tests + 131 compiler tests pass.
https://claude.ai/code/session_01XmJNtYizWWs1HeGcPYxQWe
- Revert base_path service config feature (defer to red team queue per user feedback) — restore full REST paths in .dag service definitions - Fix GNUmakefile: remove --mode=ensure flag that bootstrap doesn't accept - Fix gunbc-ci: check "success" port instead of "overall_success" which evaluates to Skipped (pure fn return expressions with BinaryOp aren't wired by the lowerer — pre-existing limitation) - Update workflows.sdlc snapshot: dependency count 2→5 after BT2 wiring https://claude.ai/code/session_01XmJNtYizWWs1HeGcPYxQWe
Five compounding failures: lowerer drops BinaryOp return expressions (line 7839 _ => None), passthrough falls back to Value::Skipped silently, testgen mocks bypass wiring, no IR-level edge verification exists. New red team tasks: - RT4a: Complex return expression lowering (root cause) - RT4b: Passthrough missing-input diagnostic (defense-in-depth) - RT4c: Lowering completeness gate (compile-time prevention) https://claude.ai/code/session_01XmJNtYizWWs1HeGcPYxQWe
briansrls
added a commit
that referenced
this pull request
May 6, 2026
…tion + V6 ACTIVE Per Verification Mgr partition response at gunbc#846 #issuecomment-4385074816. Second Mgr to engage substantively with design schedule. §2 header updated with 3-track worker partition table: - Track A (executable/ledger): bold-crane-790 — V1 (TC1 hold pending Q-PAFS + EVAL-3) + V6 (active) - Track B (corpus/demos/data): cool-heron-521 — V2 + V4 + V5 (post-R2- Evaluator-gated; prep now via design + skeleton) - Track C (Mgr-reserved/cross-lane): cool-owl-579 (Mgr) — V3 (post- cascade) + V7 (hold pending Director Q-ValueBody-Isomorphism scope) V6 marked ACTIVE — only Verification item proceeding without Director hold. Worker pin: bold-crane-790. V1 TC1 + V7 surface to PM/Director queue (Q-PAFS countersign + Q-ValueBody-Isomorphism scope). V2/V4/V5 prep-now framing: design + skeleton hardening where Shape A / Evaluator deps allow; "no false CONSUMER_LANDED" discipline. Per-claim gate mapping to §1.8 ledger rows #43-#52 (V5) / #84-#87 (V4) / #74 (V4 demonstration). Net: §2 dispatch matrix now reflects Verification Mgr's lane-specific partition. Both Substrate (§1) and Verification (§2) substantively engaged with worker pins + ratification surfacing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 6, 2026
…1810) * docs(r3): comprehensive R3 design schedule — per-Mgr dispatch matrix per Brian directive Per Brian directive 2026-05-06 (chat): "can we schedule all the design now?" Authors `docs/r3-design-schedule-2026-05-06.md` — central PM-tier dispatch matrix covering all 6 R3 Mgrs + cross-program / Director-tier decisions. Per-Mgr design queue: §1 Substrate Mgr (12 design items): Q-Class-2 gap-test (S1) + LBP scope- calibration canvas (S2) + MachineConstraint<C> carrier (S3) + Workflow* family (S4) + variant-aware projection (S5) + EmissionPathProjection (S6) + PR-F (S7) + ApproximateField<F> Float migration (S8) + T-Numeric- Construction brief (S9) + T-E-P-Producer-Broadening dispatch (S10) + Slice C #1795 follow-up (S11) + F2/F8 doc-sharpening (S12) + 5 demonstration gates. §2 Verification Mgr (7 design items): Pattern-A executable cluster (V1) + L4/L7 exhaustive coverage (V2) + T-Lens-Self-Application stronger demo (V3) + T-Tests-As-Data lane work (V4) + T-Free-Consequences 10 gates (V5) + bridge_retirement_ledger_zero audit gate (V6) + ValueBody isomorphism (V7). §3 PB Mgr (5 design items): T-LensProducer-Retirement (P1) + T-FixedPoint completion (P2) + T-V2-Retirement post-FP+LP (P3) + 3 PB-owned bridges (P4) + F2/F8 cross-lane (P5) + 4 demonstration gates. §4 Evaluator Mgr (5 design items): E6-G0d constructor execution (E1) + E5 Descent termination contract (E2) + E6-G1.a static lens fold (E3) + E6-G1.b generic dispatch (E4) + X1.b S1 coordination (E5). §5 Grounding Mgr (5 design items): L6 row population (G1) + T-Ground-Rust full coverage (G2) + Coercion-Fold scratch retirement (G3) + F10 cleanup (G4) + Anthropic #1702 re-dispatch (G5). §6 Debt-Paydown Mgr (5 design items): Q-Drift-Reconcile (DP1) + SG-0 CI gate (DP2) + velocity tripwire (DP3) + closure-receipt cadence (DP4) + #1566 rollup hygiene (DP5). §7 Cross-program / Director-tier (5 decisions): Q-LBP-R3-Closeability (CP1) + Q-Tier4-Inclusion (CP2) + Q-WEDGE-A framing (CP3) + Q-Class-6 (CP4) + PR #1794 merge (CP5). §8 Sequencing summary: critical path (T-E-P-Producer-Broadening → T-LBP → T-LAS||T-WAD → T-LSA) + parallel longest single-lane (T-V2-Retirement) + Verification-internal path + bottleneck escalations. §9 Status update cadence: daily Mgr-internal + weekly Mon/Wed/Fri PM compilation. Cross-Mgr coord via Director queue. §10 References: r3-structure.md / r3-program-plan.md (incl. §1.8 ledger) / audit/r3-debt-sweep-2026-05-06.md / 6 Mgr inboxes + Director + Research PM. Total design items: ~44 across 6 Mgrs + 5 Director-tier decisions. Net: per-lane Mgr design work scheduled in parallel with Brian/Director scope-calibration decisions. Mgrs do NOT wait for all decisions to resolve — design dispatches in flight as escalations resolve. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): absorb Substrate Mgr §1 partition response — worker pins + S3∥S8 + demo as Acceptance bullets Per Substrate Mgr partition response at gunbc#846 #issuecomment-4385074769. Substrate Mgr provided clean trigger-state partition for §1 12 items + worker pins + structural corrections. Updates absorbed: S7 PR-F: worker pin narrowed to loyal-wolf-828 (per Q-PR-F bandwidth-aware routing + Substrate Mgr explicit partition); valiant-ant-72 reserved for S3 MachineConstraint<C> implementation post-design (cleaner separation of authoring vs implementation phases). S8 ApproximateField<F> Float migration: dispatch trigger updated from "post-S3 (sequential) OR parallel" → "**parallel with S3**" per Substrate Mgr correction. MachineConstraint<C> and ApproximateField<F> are INDEPENDENT axes (machine width vs algebra approximation); both Mgr-tier design now with cross-reference at brief-landing. S10 T-E-P-Producer-Broadening: worker pin = quick-koi-190 (currently on #1799 termination-contract; T-E-P consumes descent-evidence, natural follow-on). S11 Slice C: dispatch trigger refined to "post-#1795 (Slice A) + #1801 (Slice B) merge" cascade-clearance; worker pin = smart-ram-167 (Slice B precedent owner; pattern-familiar). 5 demonstration gates (#67/#68/#70/#72/#73): per Substrate Mgr structural correction — fold demonstration scope into parent worker brief Acceptance bullets, NOT separate dispatches. Each gate becomes Acceptance bullet on parent lane's brief. Worker assignment now explicit: - S5 (variant-aware projection): quiet-boar-160 (in flight) - S7 (PR-F): loyal-wolf-828 (post-#1782 merge) - S10 (T-E-P): quick-koi-190 (post-#1782 merge; post-#1799 close) - S11 (Slice C): smart-ram-167 (post-#1795 + #1801 merge) - S3 implementation: valiant-ant-72 (post-S3 design) Mgr-tier authoring queue (Substrate Mgr): S1 + S2 + S3 + S9 + brief packets for S6/S10/S11/S7. Surfaces ratification needs to PM/Director queue as canvases land. Net: §1 dispatch matrix now reflects Substrate Mgr's lane-knowledge corrections. Substrate is the first Mgr to engage substantively with the design schedule + provide partition response — exactly the pattern the schedule was meant to enable (Mgrs partition + dispatch without PM micro-management). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): absorb Verification Mgr §2 partition — 3-track worker partition + V6 ACTIVE Per Verification Mgr partition response at gunbc#846 #issuecomment-4385074816. Second Mgr to engage substantively with design schedule. §2 header updated with 3-track worker partition table: - Track A (executable/ledger): bold-crane-790 — V1 (TC1 hold pending Q-PAFS + EVAL-3) + V6 (active) - Track B (corpus/demos/data): cool-heron-521 — V2 + V4 + V5 (post-R2- Evaluator-gated; prep now via design + skeleton) - Track C (Mgr-reserved/cross-lane): cool-owl-579 (Mgr) — V3 (post- cascade) + V7 (hold pending Director Q-ValueBody-Isomorphism scope) V6 marked ACTIVE — only Verification item proceeding without Director hold. Worker pin: bold-crane-790. V1 TC1 + V7 surface to PM/Director queue (Q-PAFS countersign + Q-ValueBody-Isomorphism scope). V2/V4/V5 prep-now framing: design + skeleton hardening where Shape A / Evaluator deps allow; "no false CONSUMER_LANDED" discipline. Per-claim gate mapping to §1.8 ledger rows #43-#52 (V5) / #84-#87 (V4) / #74 (V4 demonstration). Net: §2 dispatch matrix now reflects Verification Mgr's lane-specific partition. Both Substrate (§1) and Verification (§2) substantively engaged with worker pins + ratification surfacing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): absorb Debt-Paydown Mgr §6 partition — DP2 IN-FLIGHT at PR #1807 Per Debt-Paydown Mgr partition response at gunbc#846 #issuecomment-4385074935. Third Mgr to engage substantively. §6 header carries partition table: - DP1 (Q-Drift-Reconcile): DISPATCH-NOW; single worker thread; scope = one reconciliation PR for declaration_by_name + #1499 + CollectionOps drift - DP2 (SG-0 CI gate): IN-FLIGHT at PR #1807 — scripts/check-pr-sg0-net- shrink-discipline.sh + workflow + template + ROADMAP. Closes §1.8 gate #75 pr_anticipation_discipline_ci_active. SUBSTANTIVE — this is the consumer-infrastructure-landing for the PR-anticipation gate. - DP3 (velocity tripwire): CONTINUOUS — recurring report; no single landed event - DP4 (closure-receipt cadence): CONTINUOUS — feeds r3_debt_paydown_zero_ remaining Pass surface - DP5 (#1566 rollup hygiene): HOLD pending DRAFT close No §6 items currently Director-blocked; clean dispatch. PR #1807 actively executing closes §1.8 gate #75 → CONSUMER_LANDED status update flows through §1.8 ledger when PR #1807 merges. Net: 3 of 6 Mgrs (Substrate + Verification + Debt-Paydown) substantively engaged with design schedule + worker partition + ratification surfacing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): absorb PB Mgr §3 partition + ratify §2.2 sequencing as HARD DAG Per PB Mgr partition response at gunbc#846 #issuecomment-4385075315. Fourth Mgr to engage substantively + surface real PM ratification ask. §3 header carries PB Mgr's worker partition table: - P1 T-LensProducer-Retirement: sleek-eagle-514 (#1768) — lens_apply retirement design/audit receipts via PR #1805 path-1 + sub-briefs - P1 parallel doc spine: zesty-ram-316 (#1769) — regen_lens audit via PR #1806 + Sub2/Sub3 brief threads - P4 bridge appendix: warm-ant-877 (#1770) — grep/ledger hygiene against bridge_ledger.dag / r3_bridge_retirement_ledger_zero.dag / verification.dag - P5 F2+F8: PB Mgr coordinates consumer-side with Substrate S12 owner (no duplicate PR unless PM ratifies co-author shape) - P2 T-FixedPoint: HOLD until P1 + SG-0 zero per F1 sequencing - P3 T-V2-Retirement: HOLD on broad ~79 .rs sweep until P2 + LP + Int<N> triggers clear §2.2 sequencing authority RATIFIED as HARD DAG (PM disposition 2026-05-06): Per PB Mgr's surface — "staffing parallelism vs hard DAG" question explicitly resolved. r3-structure.md §"Lane structure" → T-FixedPoint row names "R2-close dependency: SG-0 zero from T-LensProducer-Retirement" as explicit dependency. SG-0 zero is structural precondition for T-FixedPoint (bit-identical compile requires no remaining hand-Rust ratchet); not just resource sequencing. T-FixedPoint cannot complete until T-LP-Retirement completes. Plan §2.2 sequence is canonical authority on this; PB Mgr's HOLD on P2 is correct discipline. Net: 4 of 6 Mgrs (Substrate + Verification + Debt-Paydown + PB) engaged substantively with worker pins + ratification surfacing. PB Mgr's HARD-DAG ratification ask resolved inline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): absorb Grounding Mgr §5 partition — G4 DISPATCHED + G1/G2/G3/G5 HELD on Substrate cascade Per Grounding Mgr partition response at gunbc#846 #issuecomment-4385080863. Fifth Mgr to engage substantively. §5 header carries Grounding Mgr's worker partition table. Clean dispatch shape — Grounding lane is largely consumer of Substrate work, so most items HELD until Substrate carriers land. Partition: - G1 L6 row population: HELD pending Substrate S6 EmissionPathProjection - G2 T-Ground-Rust full coverage: HELD pending Substrate S7 PR-F + S8 Float migration; #1783 remains draft as dispatch-guide staging artifact - G3 Coercion-Fold scratch retirement: HELD pending LanguageSpec projection - G4 F10 install_hint cleanup: DISPATCHED 2026-05-06 to silent-badger-711 (#1774) - G5 Anthropic #1702 re-dispatch: HELD pending Substrate S5 variant-aware projection + Q-Anthropic-Variant-Aware closure-scope No PM/Director ratification needed; G4 dispatched cleanly. Other items proceed when Substrate triggers land. Net: 5 of 6 Mgrs (Substrate + Verification + Debt-Paydown + PB + Grounding) substantively engaged. Pending: Evaluator only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): absorb Evaluator Mgr §4 partition — E1 DISPATCHED + E5 DONE; ALL 6 of 6 Mgrs engaged Per Evaluator Mgr partition response at gunbc#846 #issuecomment-4385081532. **Sixth and final Mgr to engage substantively** — all 6 of 6 R3 Mgrs now have lane-specific worker partitions in design schedule. §4 header carries Evaluator Mgr's worker partition table: - E1 E6-G0d constructor execution: DISPATCHED 2026-05-06 to valiant-carp-10 (#1767); evaluator-only src/v3/compiler/src/lib.rs; brief = #1784 - E2 E5 Descent termination contract consumer: HELD pending Substrate carrier landing (quick-koi/quick-crab path) - E3 E6-G1.a static lens fold: HELD pending Director Q-PAFS / Q-EVAL-Lens-Fold-First-Slice countersignature - E4 E6-G1.b generic dispatch: HELD post-G1.a + post-Substrate X1.b - E5 X1.b S1 TransformDispatch coordination: DONE cross-lane status sent to Substrate (#1739) Additional state notes: - #1784 G0d brief green on fmt/ci/v3; self_host_ratchet in progress post-main merge — doesn't block E1 dispatch (brief stable + approved) - #1799 E5 STOP packet green on fmt/ci/v3; held semantically behind Substrate termination contract - warm-dove #1778 passing/held; existing PR needs Director/PM disposition No PM/Director ratification needed for E1/E5. E3 still needs Director countersignature. Net: 6 of 6 Mgrs (Substrate / Verification / Debt-Paydown / PB / Grounding / Evaluator) substantively engaged with design schedule. Concrete dispatches in flight: G4 (silent-badger-711) + DP1 + DP2 (PR #1807) + E1 (valiant- carp-10) + S5 (quiet-boar-160 in flight) + Substrate Mgr-tier authoring queue (S1/S2/S3/S9). Cross-lane coord working: E5 → Substrate; G* → S* trigger-cascade. Engagement scoreboard: 100% of R3 Mgrs partitioned + dispatching per schedule. PM micro-management overhead = zero per Mgr-tier dispatch discipline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): codex BLOCKING fixes — §S4 audit-first against extdeps.github.actions + §V1 Pattern-A 5th gate routed to T-CostLens Fix 2 of 4 codex BLOCKING findings on PR #1810: 1. §S4 Workflow* family carriers (Class 4) — prepend existing-ontology audit prerequisite citing dsl/extdeps/github/actions.dag (218 lines, already declares Workflow / WorkflowTrigger / Job / Step / MatrixStrategy / RunnerSpec / WorkflowPermissions / ConcurrencySpec / DispatchInput). Reframe proposed carriers as audit targets / deltas, not fresh ontology; require Substrate Mgr audit-and-delta receipt before worker dispatch. Per feedback_audit_adjacent_authority_first + feedback_parallel_representation_debt. 2. §V1 Pattern-A executable cluster — fix count mismatch. Headline now says "4 NEW (DimensionReport-typed cluster) in V1"; explicit note that the 5th NEW Pattern-A gate (§1.8 #40 symbolic_cost_expr_equals_executable, SymbolicCost-typed) belongs to T-CostLens-Composition lane, not V1's TC cluster (per r3-program-plan.md:755 — different predicate family, distinct runner work). Closure-predicate citation updated accordingly. Findings 1 (external PM ledger) + 2 (Mgr-canvas → lane authority) rebutted on PR with grep evidence — both invalid. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 of 3 tasks
briansrls
added a commit
that referenced
this pull request
May 6, 2026
…arkers) Per gunbc PM review on PR #1879 (deep-wolf-155, 2026-05-06T20:46:43Z): within each layer-block the CENTER mixed three origin classes — direct mirror of .dag, user-authored .dag logic, and fold-rule auto-emit — all sharing one tint. Applying the recommended Path A: light-touch inline markers that flag the auto-emit lines, plus a load-bearing qualifier on the TESTS panel. Changes: - TESTS panel header: "// tests — R3 DELIVERABLE (T-Tests-As-Data lane; not emitted today)". Legend tests row updated to match. The panel previously claimed behavior that doesn't exist yet — verified by the PM that gunbc emits 0 #[cfg(test)] markers today and that R3 closure gates #74/#84/#85/#86/#87 will deliver this. - Inline "// auto — fold rule" annotations (italic gray, via tspan) on the three impl blocks that the structural fold emits without authored source: impl<A,B> Sum<A,B> (constructors + predicates), impl HttpError (new), impl LoginRequest (new). - Subtitle updated so the auto-marker convention is explained at the top of the diagram. Not applied (intentional, lighter touch): - #[derive(...)] left as plain code — deriving is universally understood as mechanical, the layer comment + auto-marker on the impl block is enough signal. - unimplemented!() left as plain code — body filler is obviously placeholder; over-marking would clutter. - Within-helpers fact-vs-logic split (Result alias vs map/and_then) not visually separated — the helpers layer comment will gain a small clarifier in a follow-up if it reads ambiguous.
briansrls
added a commit
that referenced
this pull request
May 7, 2026
…brief (closes #1966) (#2149) * docs(briefs): cite gate IDs #84-#87 + #74 on T-Tests-As-Data unified brief Maps the four DECLARED 2026-05-06 gate ledger rows + #74 demonstration sibling to the existing unified brief authored at #1893. Routes #1966 (which asked for a unified worker brief consolidating these gates) to existing authority per brief-authoring-checklist.md Q2 + INVARIANTS P2 (single authority) — not a second parallel brief. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(briefs): align ledger section cite to §1.8 actual heading Cursor review on PR #2149 (composer-2) flagged that "§Gate ledger" doesn't match the actual heading in r3-program-plan.md. Updated to "§1.8 Canonical R3 Closure-Authority Ledger" to match line 178 verbatim. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 7, 2026
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…k5 fragments-inclusive numbers (codex BLOCKING) codex BLOCKING review on PR #2361 sha b925b17 + 1 non-blocking. All 3 findings addressed. **Finding 1 BLOCKING — temporary exception handling folded into close condition**: Cluster M plan §1.3 #84 close criterion previously said "count = 0 (or carries only Director-allocated exceptions)" — folding exceptions into close. Codex correct: this leaves PB-zero ratchet escapable. Tightened to strict zero; Director-allocated timed-carries (e.g., Option 2 cross_target_coverage_carrier_test.rs) are now blockers/non-close-risk until they migrate to testgen-coverage. R3-honest-close requires actual zero, not "zero-except-exceptions". §5.1 receipt language matched. **Finding 2 BLOCKING — script reduces dispatch evidence to string pattern**: Brief paths cited in option-(c) pairings now require file existence verification at $ROOT/$path. String-pattern match alone was escapable (cite a fictional brief path, satisfy regex). Issue refs / GitHub URLs are external and not file-checkable here, so they pass through pattern check only. Updated script self-tests to use existing brief path (docs/briefs/r3-v-tests-as-data-v1-worker.md); added new fail case for nonexistent brief path. Self-tests pass. **Finding 3 NON-BLOCKING — Risk5 numbers misaligned with fragments-inclusive surface**: §10.3 Risk5 cited 119→149; tracker + ROADMAP surface (post-fragments-inclusion) is 120→150. Updated Risk5 row to fragments-inclusive numbers; cited tightening provenance. Boundary contract now consistent: close-condition matches "actual zero" semantics; script enforces file-existence for brief-path evidence; Risk5 numbers match canonical surface. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks done
briansrls
added a commit
that referenced
this pull request
May 9, 2026
… bare #NNNN gate-numbers (codex BLOCKING) codex inline BLOCKING @ scripts/check-pr-sg0-net-shrink-discipline.sh:119: regex `[[:space:]]#)[0-9]+` matched bare #NNNN tokens in prose like "dispatch for gate #84" — gate numbers (#84, #85, etc. are R3 gate IDs cited in §1.8 ledger), not issue refs. This let option-(c) deferrals pass with what looks like a tracker reference but is actually just a gate number mentioned in passing. Fix: regex tightened to require qualified `gunbc#NNNN` or `gunb-ai/gunbc#NNNN` form (or full GitHub URL). Bare `#NNNN` no longer accepted. Self-test added: "(c) bare #NNNN gate-number-in-prose" expects fail. Error message updated to make the distinction explicit: "qualified tracker issue ref (gunbc#NNNN or gunb-ai/gunbc#NNNN). Bare #NNNN refs (which could be gate numbers in prose) no longer accepted." Self-tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…2358) * docs(audit): R3 PB-0 velocity walk + SG-0 census trajectory finding Director-greenlit follow-up to PR #2300 cluster analysis. Honest census walk + velocity-to-zero math against gates #8 (sg0_non_test_zero) + #84 (every_rust_test_ports_to_dag_or_generated) — the Pure-Bootstrap-Zero closure gates per THESIS.md:298 + ROADMAP.md:53/88. LOAD-BEARING FINDING: SG-0 census is GROWING, not shrinking. 9-day delta 2026-04-30 → 2026-05-09: +30 entries (119 → 149), at +3.3/day average. R3 close requires gates #8 + #84 reach 0; at current trajectory the gates never close. Per-class partition shows ~80-90 of 101 test entries dissolve via single bulk event when Cluster M (T-Tests-As-Data-Completeness) lands; remaining classes dissolve via PB-Runtime + T-V2-Retirement + T-Tier3-Dissolution + LP-Retirement. Reclassifies Cluster M as critical-path-load-bearing for PB-0 closure thesis (PR #2300 had it as parallel). Without Cluster M COMPLETE, gate #84 cannot close inside 8-12 week R3 window. Surfaces 2 NEW honest-close risks (Risk 5 trajectory + Risk 6 Cluster M dispatch status) for Director cycle absorption + Brian-tier framing question on whether "PB-0 by R3 close" is still load-bearing or has drifted. Cites THESIS.md, ROADMAP.md, r3-program-plan.md §1.8 + §10, prior cluster analysis as parents; does not restate gate Pass-conditions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §4 dependency picture — separate substrate-flow vs PB-0-closure edges (codex BLOCKING) Codex review on PR #2358 line 92: §4 dependency diagram had A → B → M (substrate flow) but §5 Risk 4 + PR #2300 §4 Risk 2 reference M → B → E (PB-0-closure sequencing). Inconsistent edge directions violated INVARIANTS P2/P5 single-authority-metadata for sequencing. Resolution: §4 now explicitly carries two edge-classes: - View 1 substrate-flow: A → {B, M} (parallel-post-A) - View 2 PB-0-closure: M → (B-PB-0-honest cementing-in-dag) → E Both views are simultaneously true under different relations (substrate-availability vs closure-readiness). The "M → B → E" sequencing in §5 Risk 4 corresponds to View 2 — closure-honesty sequencing, not substrate flow. PR #2300 §2 had M classified as "parallel" which is correct under View 1 substrate-flow but missed View 2 PB-0-closure-readiness; this audit's reclassification of M as "critical-path" is correct under View 2 closure-flow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §0 + §3.2 — durable authority cite + dissolution-rate evidence partition (openai-pro APPROVE_WITH_COMMENTS) openai-pro review on PR #2358 sha 93f187e → 9c61c4f: 2 valid findings. §0 authority cite: replaced local filesystem path (`/Users/briansrls/.worktrees/gunbc/zesty-bear-812 thread`) with durable GitHub-comment refs: - gunbc#846 #issuecomment-4411924843 (Director's initial relay) - gunbc#846 #issuecomment-4412008376 (subsequent ratification + partner-work delegation) §3.2 evidence partition: prior framing labeled the recent-PR list as "materially reduced entries" but included enabling-only landings (#2281 +1, #2271 net 0, #2200 added entries). Re-partitioned into: - "Census-reducing landings" (only PR #2279) - "Enabling-only landings" (#2281, #2271, #2200) — substrate/scaffold work that does NOT reduce census in-PR - Recomputed rate using only census-reducing landings: ~0.25/day or ~0.5-1/cycle (upper bound) - Added explicit "Why this matters for §3.3" sentence clarifying enabling-only events are prerequisites, not reductions Boundary discipline + Modeling Faithfulness re-grounded; rate calculation now cleanly traceable to evidence. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): §8 meta-finding — closure-claims-vs-HEAD drift pattern (Director scope expansion) Director scope expansion at gunbc#846 #issuecomment-4412017502: 6 additional drift findings from parallel Director-tier audit sweep all share root cause "program-plan claims running ahead of HEAD reality." Director recommended folding pattern observation into this audit. §8 captures 9 specific drift instances across PM + 2 Director audits: 1. §1.8 status drift (this audit §1) 2. SG-0 trajectory drift (this audit §0) 3. TC1 #11 plan-language drift (Director ask 6) 4. 10 demonstration gates runtime-path drift (Director ask 7) 5. Substrate-gap-class #61 enumeration drift (Director ask 8) 6. Gate-count canonicalization drift (Director ask 9) 7. Gate #95 carve-doc cross-ref drift (Director ask 10) 8. §10.3 ratification ledger publication drift (Director ask 11) 9. R4-carve hand-Rust drift (PM ask 2026-05-09 at #828 #issuecomment-4412052024) Pattern shape: every instance is "document text asserts a closure-state that HEAD does not satisfy" via 4 sub-shapes (post-R3 substrate dep / trajectory divergence / one-sided conjunctive close / cross-ref drift). Standing recommendation: status-vs-HEAD grep cadence in standing PM/Director cycle (per-Mgr lane self-check + PM weekly §1.8/§10.3 grep). Meta-finding is structural-not-personnel: drift class closes when reconciliation cadence is added explicitly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §0 audit-time snapshot disclaimer (codex BLOCKING — staleness vs HEAD) codex BLOCKING inline @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:23: "HEAD census row is stale against sg0_census_test.rs." Verified: at PR branch sha 5ea313c the census is 49 + 102 + 2 = 153; on origin/main cf1d523 it's 50 + 103 + 2 = 155. Audit cited 48 + 101 + 1 = 149/150. Audit numbers ARE stale relative to HEAD — main has moved 1 commit past the PR branch since audit authored. Fix: add explicit "audit-time snapshot" disclaimer scoping the count cells to the audit window. Live source-of-truth for SG-0 trajectory is `docs/audit/r3-sg0-trajectory-tracker.md` (daily/per-cycle refresh). The trajectory finding (growth ≥ +3.3/day; gates cannot reach zero at observed velocity) is structural and remains valid regardless of point-in-time count drift; specific cells should be read "as of audit window" not "as of HEAD now." Per `r3-sg0-trajectory-tracker.md` §7 + audit §7: methodology durable; specific numbers ephemeral. The codex finding was correct that the audit numbers were presented as if HEAD-current; disclaimer now scopes them properly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): tracker-file forward-reference (codex BLOCKING — tracker on sibling PR #2361) codex BLOCKING inline @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:17: cited `docs/audit/r3-sg0-trajectory-tracker.md` is not in PR #2358's tree — it's on sibling PR #2361. If PR #2358 merges first, the reference points to a non-existent file (P1/P2 violation). Verified: tracker file IS on PR #2361 branch (blob `85e072cf`); IS NOT on PR #2358 branch or main. Fix: refactored references to: - Cite `src/v3/compiler/tests/integration/sg0_census_test.rs` directly as the live SG-0 census source-of-truth (file IS on main) - Note tracker artifact lands via sibling PR #2361; cite-once-merged - §8 standing-recommendation updated similarly Snapshot scope disclaimer now self-contained — audit can land independently of PR #2361 merge ordering. No forward-references to non-merged sibling content remain. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §4 gate #8 partial Cluster M overlap (openai-pro REQUEST_CHANGES) openai-pro review on PR #2358 sha cf89a69: §2.2 row "infer/lower/test_runner" listed Cluster M as part of test_runner's dissolution dependency, but §4 summary claimed gate #8 is "orthogonal to M/B closure flow" — internal contradiction. Fix: amended §4 to acknowledge partial Cluster M overlap for test_runner.rs specifically (test runner retires when Cluster M's TestClaim system can drive testing end-to-end as .dag data — i.e., when #87 cementing-test discipline + bulk-port discipline land). Gate #8 is now correctly characterized: mostly orthogonal to M/B closure flow, but not fully — test_runner.rs is the specific overlap entry per §2.2. Single canonical PB-0 closure dependency picture restored across §2.2 + §4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §1 — overclaim "every test entry has dissolution-trigger comment" corrected (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:40: prior framing claimed "every test entry has a header-comment naming a 'dissolution trigger'." Verified at HEAD: only ~32 of 103 test entries have inline header comments. The remaining ~71 are potentially untracked hand-Rust debt under INVARIANTS P1/P5 — option-(c) discipline assumes per-entry dissolution-trigger documentation but these lack it. Fix: §1 corrected to "About 32 of 103 test entries... the remaining ~71 entries lack inline dissolution-trigger comments." Added explicit audit finding: commentless entries are "potentially untracked hand-Rust debt" — they may have implicit dissolution paths (m1/m2 boundary tests via T-V2-Retirement + Tests-As-Data; sg* tests via Tests-As-Data; common/ helpers when downstream consumers retire) but lack the per-entry header comment. PM follow-up (Task 13): per-entry audit of ~71 commentless entries to classify under existing clusters OR flag as untracked debt requiring fresh substrate authoring or comment-attribution PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §2 cluster-level partition scope + §8 per-instance verification table (codex BLOCKING) codex top-level BLOCKING on PR #2358 sha 7a34af5: 2 valid findings. **Finding 1 — §2 trigger partition assumed-shape vs mechanical**: §2 partition was cluster-level estimation, not per-entry mechanical audit. Codex correct that "option-(c) dominance" claim needed grounding. Fix: §2 now explicitly scopes the partition as cluster-level methodology (NOT per-entry attribution) — derived from (a) inspection of header comments where present + (b) inferred classification of commentless entries by filename pattern. Per-entry verification deferred to Task 13 (UNACCOUNTED entries grep). The cluster-level partition supports §3 velocity-math finding without per-entry attribution; both §1 + §3 conclusions reproducible at cluster-level. **Finding 2 — §8 Director-audit bullets transcribed without per-instance verification**: §8 listed 9 drift instances by short reference; each bullet's grounding was implicit (verified in corresponding fix commits but not surfaced inline). Fix: §8 converted to verification table with explicit "Verification (landed authority)" column per instance. Each of the 9 drift instances now cites: - The grep-verified landed authority (e.g., `docs/r3-program-plan.md` §1.8 row #11 + Director disposition `473b99fb...`) - The fix commit / PR where addressed (e.g., PR #2361 sha 6efde88) - Dispositions where applicable (e.g., #7 dissolved by Task 12 PR #2364; #9 resolved by Director (a) ratification + Task 12) Each drift instance now self-grounds the §8 meta-finding without requiring readers to re-derive evidence per-bullet. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §1 trigger-coverage math reconcile to 101 (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:40: "trigger-coverage math says 32 of 103 test entries while the same audit snapshot and §2 say 101 test entries, so the remaining-debt count is internally inconsistent under INVARIANTS P1/P2." Verified: §1 used "32 of 103" + "remaining ~71" while §0 audit-time snapshot table line 25 + §2.1 line 56 + §2.1 line 69 + §3 line 134 all use 101. The 103 was introduced in commit ebfebae (BLOCKING fix for "every entry" overclaim) — I picked 103 instead of matching the existing 101 framing. Real internal inconsistency. Fix: §1 trigger-coverage reconciled to 101 (matches §0 audit-time snapshot table at sha c25b2d8df + §2.1 + §3 references): - "32 of 103" → "32 of 101" (with explicit cite to §0 snapshot) - "remaining ~71" → "remaining ~69" (101 − 32 = 69, partition-consistent) - §2 methodology cite "(~32 of 103 test entries per §1)" → "(~32 of 101)" Single audit-time-snapshot count (101) used consistently across §0/§1/§2/§3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §8 row 1 source pointer — cluster-analysis (openai-pro REQUEST_CHANGES) openai-pro REQUEST_CHANGES on PR #2358 sha 2ba3719: §8 drift instance #1 sourced "9 gates likely promotable to CONSUMER_LANDED" to "this audit §1" but §1 is the SG-0 option-(c) discussion, NOT a 9-gate status audit. The source pointer didn't actually ground the row. Verified: the 9-gate inventory is in docs/audit/r3-cluster-analysis-2026-05-09.md §1 (PR #2300, on main), which says verbatim: "9 gates likely-promotable from DECLARED → CONSUMER_LANDED. 88 → ~79 still-DECLARED if Mgrs refresh ledger." Fix: row 1 source pointer corrected to cluster-analysis doc citation with verbatim quote + retain the existing grep-verification chain (§1.8 + 8 merged PRs). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): THESIS/ROADMAP citations to section anchors (codex non-blocking) codex review on PR #2358 sha c27502c: non-blocking — "THESIS citation says line 298 for the Pure Bootstrap quote, but the quote is at THESIS.md:282 in the current repo; fix the line pointer when touching the authority block." Verified: THESIS:298 IS the Pure Bootstrap quote on origin/main (codex may be reading a stale snapshot). But per `feedback_section_anchors_over_line_numbers`, line numbers drift — should switch to section/symbol anchors regardless. Fix: parent-doc citations switched from line-numbers to structural references: - THESIS.md "Pure Bootstrap to Zero" framing + verbatim quote (section anchor; line-anchor-immune) - ROADMAP.md T-PB-A lane row (`pb_hand_rust_at_shim_floor` predicate named explicitly) + T-PB-B lane row (`pb_rust_tests_outside_residual_zero` predicate named explicitly) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 9, 2026
… option-(c) discipline + SG-0 tracker (#2361) * docs(r3): PB-0 remediation program — Cluster M sequencing + §10 RED + option-(c) discipline + SG-0 tracker Director-greenlit partner work (gunbc#846 #issuecomment-4412008376) for the Pure-Bootstrap-Zero remediation program. Operator directive 2026-05-09: "course correct; existing plan stays canonical; staffing is not a concern; this is planning/correction." Branch-A from framing question: PB-0 by R3 close stays load-bearing. Bundles 5 partner-work artifacts: 1. **`docs/audit/r3-cluster-m-sequencing-plan-2026-05-09.md`** (Task 1) — 3-phase sequencing plan for Cluster M (T-Tests-As-Data-Completeness gates #84/#85/#86/#87) with lane-Mgr partition (Substrate authors #85/#86 substrate canvases; Verification authors #87 cementing-test discipline + #84 bulk-port). 4-8 week velocity projection fits 8-12 week R3 window with parallel dispatch. 2. **`docs/audit/r3-sg0-trajectory-tracker.md`** (Task 5) — daily-cadence schema + first 5-row history table; 3 threshold alarms; data source for new R3-close progress bars. 3. **`docs/r3-program-plan.md` §10.3 amendments** (Task 4) — adds Q-PB0-Trajectory-Risk5 + Q-PB0-ClusterM-Cold-Risk6 + Q-Cluster-M-Reclassification rows (RATIFIED 2026-05-09 per Director acknowledgment). 4. **`ROADMAP.md`:177 amendment + `scripts/check-pr-sg0-net-shrink-discipline.sh` tightening** (Task 3) — option-(c) deferrals now require concrete dispatch evidence (gunbc#NNNN issue ref OR docs/briefs/*.md path), not just "named follow-up dispatch" word. Closes the +30/9days option-(c) paper-trail leak. Self-tests pass. 5. **§8 dispatch readiness checklist** in sequencing plan — surfaces Director ratification needed on dispatch shape (single-coordinator vs 4-parallel-worker vs hybrid); cites existing PRE-AUTH DISPATCH-READY brief at `docs/briefs/r3-v-tests-as-data-v1-worker.md` (tier-1 queue #1859). PM-tier authoring; Director ratifies before dispatch. Pre-authored worker briefs (Task 2 sub-task) await Director's choice of dispatch shape per §8.1; current PR scopes to plan + amendments + tightening + tracker. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): asks 6 + 9 — TC1 #11 plan-language sync + gate-count canonicalization (Director scope expansion) Director scope expansion at gunbc#846 #issuecomment-4412017502 (parallel Director audit findings, 2026-05-09). First wave of 6 NEW asks (6-11) bundled into existing remediation PR per Director sequencing recommendation. **Ask 6 — TC1 §1.8 row #11 plan-language sync**: Row #11 prior text claimed "flips DECLARED → CONSUMER_LANDED → PASSING in one move on Evaluator E3.c (#1970) merge." This contradicts ratified Director (a)-disposition (#828 decision id `473b99fb...` 2026-05-09) where TC1 stays DECLARED through R3 (gate #11 cannot reach PASSING absent #1972 substrate canvas-tier work, which is HELD-CANVAS-DEFERRED past R3 per Substrate Mgr Path-A confirmation 2026-05-08). Amended row #11 to reflect honest sub-status; prior phrasing superseded. **Ask 9 — gate-count canonicalization (94 vs 95 ambiguity)**: Added explicit canonical breakdown: `97 enumerated - 3 R4-carved (#81/#82/#95) = 94 R3-load-bearing`. Gate #97 IS part of the 94 set (not additive). Future closure-arithmetic citations must use {97 enumerated, 94 load-bearing, 81 lane-aligned} canonical numbers to avoid +/-1 drift. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): §1.5 arithmetic vs row #11 + SG-0 tracker fragments scope (openai-pro REQUEST_CHANGES) openai-pro review on PR #2361 sha 6efde88: 2 valid findings. **Finding 1 BLOCKING — §1.5 arithmetic vs row #11 contradiction**: §1.5 said "97 - 3 R4-carved = 94 R3-load-bearing; #97 IS part of 94" while row #11 said "stays DECLARED through R3; not load-bearing for R3-thesis honest-close arithmetic." Two authorities for what counts as R3-load-bearing. Fix: refined §1.5 canonical breakdown to {97 enumerated → 94 post-R4-carve → 93 post-canvas-deferral}. Gate #11 added to "post-R3-canvas-deferred" category alongside R4-carved set; effectively removed from R3-thesis-honest-load-bearing arithmetic per Director (a)-disposition. Both 94 and 93 are canonical for different purposes: - 94 = post-R4-carve enumeration count (R4 boundary discussions) - 93 = R3-thesis-honest-close conjunction count (actual R3 close gate-count requirement) **Finding 2 NON-BLOCKING — SG-0 tracker fragments scope**: Tracker procedure extracted only `EXPECTED_HAND_AUTHORED_NON_TEST` + `EXPECTED_HAND_AUTHORED_TEST`, but ROADMAP.md:177 names the SG-0 delta surface as `EXPECTED_HAND_AUTHORED_*` ∪ fragments. Tracker undercounted live debt. Fix: added `fragments` column to tracker schema + procedure; updated history table with retroactive `fragments=1` (per `parse_parser_body.txt`). New total formula: `non_test + test + fragments`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): §1.5 + tracker + script — full canonicalization round (openai-pro REQUEST_CHANGES round 2) openai-pro review on PR #2361 sha 5b10ed2 found 3 remaining inconsistencies after round 1 fix: **Finding 1 — §1.5 still said "94 R3 thesis-load-bearing" alongside new "93 honest-load-bearing"**: Refactored §1.5 opening to enumerate three canonical numbers explicitly: 97 enumerated / 94 post-R4-carve enumerated / 93 R3-thesis-honest-load-bearing. Removed legacy "94 are R3 thesis-load-bearing" framing in favor of the unambiguous breakdown. **Finding 2 — SG-0 tracker §4 used 149 + "0+0" while §3 schema/history says 150 + "0+0+0"**: Updated §4 to match: "150 entries (48 non_test + 101 test + 1 fragments)" + "0 + 0 + 0" target. Updated §7 progress-bar guidance: "150 → 0". **Finding 3 — script regex didn't accept full GitHub issue URLs (ROADMAP says URL form is acceptable)**: Expanded regex to accept `https?://github.com/.../issues/NNNN` form alongside gunbc#NNNN + docs/briefs/*.md. Updated error message + comment block. Added passing self-test for full GitHub URL form. Self-tests pass. Boundary contract between ROADMAP option-(c) language and script regex now aligned; canonical R3 closure arithmetic single-authoritied; SG-0 tracker fully consistent across schema / current-state / progress-bar guidance. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): close-condition strictness + brief-path file existence + Risk5 fragments-inclusive numbers (codex BLOCKING) codex BLOCKING review on PR #2361 sha b925b17 + 1 non-blocking. All 3 findings addressed. **Finding 1 BLOCKING — temporary exception handling folded into close condition**: Cluster M plan §1.3 #84 close criterion previously said "count = 0 (or carries only Director-allocated exceptions)" — folding exceptions into close. Codex correct: this leaves PB-zero ratchet escapable. Tightened to strict zero; Director-allocated timed-carries (e.g., Option 2 cross_target_coverage_carrier_test.rs) are now blockers/non-close-risk until they migrate to testgen-coverage. R3-honest-close requires actual zero, not "zero-except-exceptions". §5.1 receipt language matched. **Finding 2 BLOCKING — script reduces dispatch evidence to string pattern**: Brief paths cited in option-(c) pairings now require file existence verification at $ROOT/$path. String-pattern match alone was escapable (cite a fictional brief path, satisfy regex). Issue refs / GitHub URLs are external and not file-checkable here, so they pass through pattern check only. Updated script self-tests to use existing brief path (docs/briefs/r3-v-tests-as-data-v1-worker.md); added new fail case for nonexistent brief path. Self-tests pass. **Finding 3 NON-BLOCKING — Risk5 numbers misaligned with fragments-inclusive surface**: §10.3 Risk5 cited 119→149; tracker + ROADMAP surface (post-fragments-inclusion) is 120→150. Updated Risk5 row to fragments-inclusive numbers; cited tightening provenance. Boundary contract now consistent: close-condition matches "actual zero" semantics; script enforces file-existence for brief-path evidence; Risk5 numbers match canonical surface. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §9.3 — close stale open question that contradicts §1.3/§5.1 strict zero (codex inline BLOCKING) codex inline BLOCKING @ docs/audit/r3-cluster-m-sequencing-plan-2026-05-09.md:174: §9 question 3 ("does Phase 3 close fold Director-allocated exceptions") was left open after §1.3 + §5.1 were tightened to strict-zero. Inconsistent close-authority within same doc. Fix: marked §9.3 RESOLVED with cross-reference to §1.3/§5.1 canonical close-condition language. Strict-zero adopted; Option 2 timed-carries are blockers, not closure-allowed exceptions. Question is no longer open. Internal close-authority now consistent across §1.3 (canonical close-condition) + §5.1 (Phase 3 receipt) + §9.3 (resolved-not-open). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sg-0): brief-path canonicality + path-traversal rejection (codex BLOCKING) codex inline BLOCKING @ scripts/check-pr-sg0-net-shrink-discipline.sh:119: existence check alone insufficient — regex permits docs/briefs/../*.md which could resolve to non-brief files outside docs/briefs/. Fix: added path-traversal rejection (any `..` segment fails) + canonical-prefix check (resolved path must remain under docs/briefs/). Existence check retained. New self-test: "(c) cited brief path with path-traversal (.. segment)" expects fail. Prior self-tests still pass. Defense-in-depth ordering: 1. Reject `..` segments (path-traversal) 2. Reject paths not under docs/briefs/ (canonical-prefix; redundant with regex but guards future regex relaxation) 3. Verify file exists at $ROOT/$p Brief-path option-(c) discipline now enforces (a) prefix-locked, (b) path-traversal-free, (c) file-existing — three orthogonal checks closing the prior escape paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): §1.5 gate-count framing — carve-promotion-aware (Director amendment ask) Per Director amendment ask at gunbc#846 #issuecomment-4412343280: replace prior "97 - 3 R4-carved = 94 R3-load-bearing" framing with carve-promotion-aware "97 R3-load-bearing gates green, no carves" forward-looking framing. Per Director ratification 2026-05-09 at gunbc#846 c#4412330468 (operator framing "0 hand-Rust including tests AND stage0; bootstrap is data + self-generated"): R4 carves C1 / C2 / C3 (gates #81 / #82 / #95) are PROMOTED-IN-R3 as lens-producer-retirement work folded into Cluster F. Updated canonical breakdown: - 97 enumerated total - 0 R4-carved at R3 close (carves dissolved per c#4412330468) - 1 post-R3-canvas-deferred {#11} (TC1 V1 strict-fire; #1972 substrate canvas-tier deferred past R3) - 96 R3-thesis-load-bearing = 97 − 1 = 96 R3 close target = 96 R3-load-bearing gates GREEN (was 93 prior round; was 94 before that). Forward-looking framing avoids the drift instance per PR #2358 §8 meta-finding (publishing "94" or "93" now would drift within hours of Director ratifying carve-promotion). This change dissolves expansion Ask 10 (gate #95 carve cross-ref) — Cluster F carve-promotion follow-up PR handles r4-carve-out-routing.md amendment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): §1.5 intro arithmetic single-authority — remove stale 94/93 framing (codex BLOCKING) codex inline BLOCKING @ docs/r3-program-plan.md:86: §1.5 intro paragraph retained "97 enumerated / 94 post-R4-carve / 93 R3-thesis-honest-load-bearing" framing while the canonicalization block below said "0 R4-carved / 96 R3-thesis-load-bearing." Two competing authorities for R3 gate arithmetic (P2 single-authority violation). The 94/93 framing was stale post-Director carve-promotion-IN-R3 ratification at gunbc#846 c#4412330468 — should have been removed when canonicalization block was added but I missed the intro paragraph. Fix: §1.5 intro now says "97 enumerated / 96 R3-thesis-load-bearing (no carves; only #11 canvas-deferral subtracted)." Single authority for R3 gate arithmetic. Carve-promotion citation in intro matches canonicalization block. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sg-0): option-(c) regex — require qualified gunbc# prefix; reject bare #NNNN gate-numbers (codex BLOCKING) codex inline BLOCKING @ scripts/check-pr-sg0-net-shrink-discipline.sh:119: regex `[[:space:]]#)[0-9]+` matched bare #NNNN tokens in prose like "dispatch for gate #84" — gate numbers (#84, #85, etc. are R3 gate IDs cited in §1.8 ledger), not issue refs. This let option-(c) deferrals pass with what looks like a tracker reference but is actually just a gate number mentioned in passing. Fix: regex tightened to require qualified `gunbc#NNNN` or `gunb-ai/gunbc#NNNN` form (or full GitHub URL). Bare `#NNNN` no longer accepted. Self-test added: "(c) bare #NNNN gate-number-in-prose" expects fail. Error message updated to make the distinction explicit: "qualified tracker issue ref (gunbc#NNNN or gunb-ai/gunbc#NNNN). Bare #NNNN refs (which could be gate numbers in prose) no longer accepted." Self-tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sg-0): error message backtick → single-quote (openai-pro APPROVE_WITH_COMMENTS) openai-pro review on PR #2361 sha 3673f1c: shell-backticks around `..` in path-traversal error message at line 137 are command-substitution, not literal-text quoting. Shell tries to execute `..` as command before printing the GitHub Actions error, producing avoidable shell noise. Fix: replaced backtick-quoted `..` with single-quoted '..' in error message. Branch still returns failure cleanly; no shell side-effects on diagnostic path. Self-tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): Cluster M docs hygiene + SG-0 (c) comment alignment (codex non-blocking) codex review on PR #2361 sha ba18ef8: 0 BLOCKING + 2 non-blocking hygiene findings. **Non-blocking #1 — Cluster M parent-doc anchors** THESIS.md:298 + ROADMAP.md:88 line citations don't precisely point to "zero-Rust-tests" authority — THESIS:298 says "0 hand-maintained" (broader scope including non-test); ROADMAP:88 IS the T-PB-B row but line numbers drift. Per `feedback_section_anchors_over_line_numbers`, switched to structural references: THESIS.md "Pure Bootstrap to Zero" framing + ROADMAP.md T-PB-B lane row (`pb_rust_tests_outside_residual_zero` predicate explicitly named). **Non-blocking #2 — SG-0 (c) comment vs regex divergence** Comment at line 113 said "(c) now requires ... an issue ref (gunbc#NNNN or #NNNN)" but regex on line 119 + error message on line 120 reject bare #NNNN (gate-number-in-prose risk). Comment was stale relative to 2026-05-09 codex BLOCKING tightening (commit later in this PR). Fix: aligned comment to regex — "(gunbc#NNNN or gunb-ai/gunbc#NNNN)"; explicitly noted "Bare #NNNN refs (could be gate-numbers in prose) are NOT accepted" matching the error message language. Self-test case at line 343 already validates the rejection ("(c) bare #NNNN gate-number-in-prose"); behavior unchanged, only comment alignment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(script): SG-0 (c) URL regex tightened to gunb-ai/gunbc tracker only (openai-pro REQUEST_CHANGES) openai-pro REQUEST_CHANGES on PR #2361 sha ba18ef8: option-(c) full-URL alternative accepted any GitHub issue URL via `https?://github\.com/[[:alnum:]_./-]+/issues/[0-9]+`. This let unrelated external repos (github.com/other/repo/issues/1234) satisfy the SG-0 deferral gate, undermining the "tracked dispatch" single-authority contract. ROADMAP option (c) is "dispatch-tracker issue URL", which implicitly means the gunbc tracker. Fix: - Tightened URL regex to `https?://github\.com/gunb-ai/gunbc/issues/[0-9]+` - Updated error message to name "gunb-ai/gunbc issue URL" explicitly - Added negative self-test case for external-repo URL rejection (matches openai-pro's request: "an external repo URL such as https://github.com/other/repo/issues/1234 should fail") Self-test passes after change. Behavior: - gunbc#NNNN: pass (unchanged) - gunb-ai/gunbc#NNNN: pass (unchanged) - https://github.com/gunb-ai/gunbc/issues/NNNN: pass (positive case at line 346) - https://github.com/other-org/other-repo/issues/NNNN: fail (NEW negative case at line 351) - docs/briefs/*.md (existing canonical path): pass (unchanged) - bare #NNNN: fail (unchanged) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): r3-program-plan post-carve-promotion reconciliation (codex BLOCKING on PR #2361) codex inline BLOCKING @ docs/r3-program-plan.md:99: "the new 96/no-carves close target is not propagated to the later §1.8 close formula or the referenced r3-structure/r4-carve authorities that still mark #81/#82/#95 carved, leaving two R3 close authorities (INVARIANTS P2 single authority)." PR #2361's §1.5 canonicalization block (added at sha 2e782f2) introduced "96 R3-load-bearing / 0 carves" framing but didn't reconcile parallel- authority references elsewhere. Same drift PR #2364 had (fixed at sha bc45e59 on that branch). PR #2361 needs the same comprehensive reconciliation to be self-consistent on its own merit. Fix-forward across: - §1 top "R3 close" definition (line 8) — replace stale "97/CARVED to R4 / option (b)" with carve-promotion-aware framing - §1.5 §1.5 canonicalization sub-bullets (lines 86, 95, 96) — clean fabricated `473b99fb...` placeholder hash, update r4-carve-out-routing.md cross-ref to PR #2364 (actual carve-promotion PR, not PR #2363 which is the substrate-readiness audit) - §1.5 R4-carved §1.8 rows paragraph (line 109) — DISSOLVED note + carve-promotion citations + cross-ref to PR #2364 - §1 Pass-surface bullets (lines 112, 115) — 94 → 96 - §1.7 R3 close criteria implies (line 107) — "all non-carved" → "all 96 R3-load-bearing" - §1.6 lane gate row T-Lens-Behavioral-Parity (line 187) — all 4 lenses R3-load-bearing - §1.8 row #11 (line 229) — clean `473b99fb...` placeholder - §1.8 row #73 status (line 291) — all 4 lenses post-promotion framing - §1.8 row #81/#82/#83 (lines 299/300/301) — R3-LOAD-BEARING carve-promoted within Cluster F - §1.8 row #95 (line 313) — R3-LOAD-BEARING carve-promoted; cascade prereqs - §1.8 epilogue (line 320) — 94 → 96 - §5/6 R3 close (line 607) — 94 → 96 - §10.3 Q-LBP-R3-Closeability (line 1040) — appended 2026-05-09 AMENDED note dissolving option (b) carve-narrowing Single canonical authority: 97 enumerated → 96 R3-load-bearing (only #11 canvas-deferred; 0 R4 carves at R3 close per Director ratification 2026-05-09 c#4412330468). Cited consistently across §1 / §1.5 / §1.6 / §1.7 / §1.8 / §3 / §5 / §10.3. Note on PR #2364 overlap: PR #2364's bc45e59 lands the same reconciliation. This PR makes #2361 self-consistent independent of merge ordering — squash-merge resolves overlapping content cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): Cluster M §3 — cite locked design instead of reopening carrier-shape (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-cluster-m-sequencing-plan-2026-05-09.md:92: "§3 reopens #85/#86 carrier-shape and Director-ratification questions even though docs/design-tests-as-data-completeness.md already canonically defines ProgramGenerator/Quantifier/QuantifiedTestClaim and says no Director ratification is required before lane dispatch, creating a second authority for the lane plan (INVARIANTS P2 single authority)." Verified: docs/design-tests-as-data-completeness.md exists on main (blob ff49723). §1 Authority discipline says "All §8 design questions resolved in-doc per feedback_design_before_implement — no Director ratification required before lane dispatch (only standard cascade gates: R2-Evaluator landed; existing TestClaim infrastructure from DB-15 R2)." §2.1 canonically defines ProgramGenerator; §2.2 canonically defines Quantifier (closed two-variant ForAll/Exists sum) + QuantifiedTestClaim with Rust signatures. My §3.1/§3.2 framing as "substrate canvas needed; Director ratification needed before brief authoring" was a duplicate-authority anti-pattern — should have grep-verified locked design before authoring canvas-tier framing per `feedback_grep_verify_locked_design_before_ratification`. Fix-forward across: - §3 header + intro (line 71): citation to locked design + authority correction explaining the prior duplicate-authority error - §3.1/§3.2 (lines 79/85): rewrite from "substrate canvas needed + Director ratifies" → "carrier landing per locked design § ; no Director ratification needed; standard cascade gates only" - §2 Lane-Mgr partition table (lines 64/65): authoring scope cites locked design instead of "need substrate canvas first" - §2 closing prose (line 69): "no canvas-tier ratification — design-doc resolves shape per §1 Authority discipline" - §4 (line 91): "carrier landings per locked design not blocking" instead of "substrate canvases for #85/#86 not blocking" - §6 velocity projection (line 126): "carrier landings per locked design" instead of "substrate canvas + carrier authoring" - §6 risk (line 132): replaced "canvas-tier ratification adds 1-3 days" with "STOP-and-PING via Substrate Mgr inbox if migration shape surprises arise per feedback_construction_over_ratchets" Single canonical authority restored: locked design docs/design-tests-as-data-completeness.md §2.1/§2.2 owns ProgramGenerator/Quantifier/QuantifiedTestClaim shape; this sequencing plan owns Cluster M phase ordering only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…rid ratification) (#2362) * docs(briefs): R3 Cluster M dispatch briefs — Task 2 per Director (γ) hybrid ratification Per Director ratification at gunbc#846 #issuecomment-4412309986: 4 asks answered + Task 2 dispatch shape locked at (γ) hybrid (Substrate canvases #85/#86 → Verification discipline #87 → Verification bulk-port coordinator #84). 3 light-touch dispatch briefs authored: 1. **`r3-cluster-m-dispatch-substrate-canvas-asks-2026-05-09.md`** — Substrate Mgr (warm-wolf-698) dispatch surface for #85 ForAll/Exists quantifier substrate canvas + #86 ProgramGenerator carrier canvas. Standing-authority canvas-drafting; Director ratifies surfaced shape questions. Pattern precedent: T-WAD Slice 2. 2. **`r3-cluster-m-dispatch-verification-discipline-87-2026-05-09.md`** — Verification Mgr (wise-bear-525) dispatch for #87 cementing-test discipline pattern. Cites existing PRE-AUTH `r3-v-tests-as-data-v1-worker.md` (tier-1 queue gunbc#1859) as substrate-of-truth; this brief is the (γ)-hybrid coordination overlay. 3. **`r3-cluster-m-dispatch-verification-bulkport-84-2026-05-09.md`** — Verification Mgr coordinator role for #84 bulk-port. Strict-zero close-condition per Director Ask 4 (no Director-allocated exception fold; bulk-port scope = all 102 entries; testgen must cover). Per-class brief queue + lane-Mgr signoff workflow. All 3 briefs cite-and-execute against the structural authority at `docs/audit/r3-cluster-m-sequencing-plan-2026-05-09.md` per Director's "Sequencing-plan doc carries the structural authority; briefs cite-and-execute" guidance. Director will dispatch lane Mgrs (Substrate Mgr canvas authoring + Verification Mgr discipline + bulk-port coordinator) on this brief PR ratification. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): Cluster M Phase 1 dispatch brief — cite locked design instead of canvas-asks (codex BLOCKING cascade) Cascade fix from codex BLOCKING on PR #2361 sha c6c3fb9 (sequencing plan §3 reopened carrier-shape questions despite locked design resolving them at docs/design-tests-as-data-completeness.md §2.1/§2.2). This brief had the same anti-pattern: framed as "Substrate Canvas Dispatch Asks" + "Surface for Director ratification" sub-bullets that duplicated the locked design's canonical carrier definitions. Fix: comprehensive rewrite as "Substrate Carrier Landing Asks": - Title: "Substrate Canvas Dispatch Asks" → "Substrate Carrier Landing Asks" - §0 Scope: list specific carriers (Quantifier + QuantifiedTestClaim + ProgramGenerator) instead of "substrate canvas authoring" - §1: NEW Authority correction section citing codex BLOCKING + locked-design §1 ("no Director ratification required before lane dispatch") + INVARIANTS P2 single-authority - §2 Dispatch disposition: pattern explicitly distinguishes "substrate-shape canvases for novel substrate (e.g., T-WAD Slice 2)" from "migration / locked-design carrier landings dispatch directly" - §3 (was §2) Substantive guidance: removed "surface for Director ratification" bullets; replaced with verbatim locked design carrier shapes (Quantifier closed sum; QuantifiedTestClaim/ProgramGenerator Rust signatures). Worker scope cites locked design §2.1/§2.2 directly. - §4 NEW STOP-and-PING posture: if unexpected shape question arises, surface via Substrate Mgr inbox (per feedback_construction_over_ratchets) rather than authoring canvas mid-port - §5/§6/§7 dispatch trigger / receipt / velocity unchanged in substantive content; cleaned up framing references Single canonical authority restored: locked design docs/design-tests-as-data-completeness.md §2.1/§2.2 owns shape; this brief owns dispatch coordination only. Cross-PR alignment: PR #2361 sha 697a125 has the parallel fix on the sequencing plan; this PR's brief is now consistent with that. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): Cluster M dispatch briefs — codex BLOCKING (4) addressed codex inline BLOCKINGs on PR #2362 sha a88e816 (4 findings): 1. **Sequencing plan path neither in PR diff nor in repo** (line 4 of all 3 briefs) Verified: `docs/audit/r3-cluster-m-sequencing-plan-2026-05-09.md` is in-flight on concurrent PR #2361 (not on main yet). Same in-flight authority pattern as PR #2363 audit. Fix: each brief's authority line now notes "in-flight via concurrent PR #2361" + "this brief is the dispatch overlay — substantive content here is self-contained and grounded in [locked-design / live-ledger] authorities below." Self-containment preserved; no merge-order trap. 2. **`r3-v-tests-as-data-v1-worker.md` cited as substrate-of-truth but absent** (discipline-87 line 14) Verified: file EXISTS on main (blob `4ff9abcb1b8b` per `git ls-tree origin/main`). Tree-visibility false positive (codex bot's repeated pattern this cycle). Fix: added explicit `git ls-tree origin/main` cite + locked-design authority `docs/design-tests-as-data-completeness.md` §C5 in §1 substrate section. 3. **Hard-coding "102" duplicates SG-0 census authority** (bulkport-84 line 18) Real finding: brief said "all 102 entries" duplicating the live `EXPECTED_HAND_AUTHORED_TEST` count. Fix: scope reframed to "all entries in EXPECTED_HAND_AUTHORED_TEST at PR-merge time (live authority: src/v3/compiler/tests/integration/ sg0_census_test.rs; count is wc -l-derivable from the array literal — not hardcoded here to avoid duplicate-authority drift)." 4. **First cementing migration uses wrong predicate** (discipline-87 line 34) Real finding: brief said "frozen `BinaryDimensionReportEquals` snapshot" but locked design `docs/design-tests-as-data-completeness.md` §C5 says cementing v2-oracle ports use `DifferentialEquals` or `LensOutputEquals` (same-source comparison axis). `BinaryDimensionReportEquals` is for Pattern-A DimensionReport comparisons (TC1/TC2/TC3 family) — different axis. Fix: predicate corrected with explicit cite to locked design §C5 row + §"C5: Cementing (v2 oracle)" + clarification of why `BinaryDimensionReportEquals` is the wrong predicate. 5. **Velocity context citing "102"** (discipline-87 line 45) Cascade fix: replaced "102 hand-Rust test entries" with reference to `EXPECTED_HAND_AUTHORED_TEST` (live count authoritative at sg0_census_test.rs). Cross-PR alignment: PR #2361 sha 697a125 has the parallel locked- design citations on the sequencing plan; this PR's briefs now consistent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 13, 2026
briansrls
added a commit
that referenced
this pull request
May 13, 2026
4 tasks
briansrls
added a commit
that referenced
this pull request
May 13, 2026
…laxation per codex BLOCKING PR #3013 Two substantive close-criteria fixes per codex BLOCKING 2026-05-13T18:19:56Z: **Finding 1 — Gap 5 boundary carve-out violates 0-residual** (TESTING.md L212-217 + docs/design-pure-bootstrap-zero.md:41,138): - Removed `-not -path "*/boundary/*"` from gate #84 close predicate - Added authority citation: TESTING.md "🔄 RETRACTED 2026-04-25" + 0-floor target - Boundary tests ARE counted; migrate to ExecuteCommand-based .dag TestClaim per cascade **Finding 2 — Gap 9 pragmatic-relaxation dilutes THESIS absolute** (THESIS.md "show the correct code" reads as absolute promise): - Removed "Pragmatic relaxation (≥X%)" alternative from Gap 9 close criterion - Removed §4 operator sub-decision (b) threshold negotiation - Close criterion is 100% absolute; non-100% requires R4-carve override of project_no_r4_carves_directive (NOT within-R3 threshold negotiation) **Additional: Phase F adversarial re-pass discipline** (operator directive 2026-05-13 — final closeout will be adversarial analysis): - Phase F now explicitly includes operator+PM adversarial re-pass against interrogation doc + close plan + §1.8 row statuses - Bookkeeping PR sequencing updated: depends on adversarial-re-pass verdict, not just predicate execution outcome - Symmetric to 2026-05-13 adversarial sweep that surfaced 10 counterfactuals; applied at close ceremony to confirm none survived Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 13, 2026
… EXPECTED_HAND_AUTHORED_TEST list-emptied predicate per briansrls BLOCKING PR #3013 briansrls BLOCKING 2026-05-13T18:22:57Z at docs/r3-actual-close-plan.md:183: > "The gate #84 close predicate uses the `// AUTO-GENERATED FROM .dag` > comment as the authority for generated tests, which can pass with > hand-authored Rust carrying the marker and does not prove the THESIS > tests-as-data claim." **Verified**: this is exactly the feedback_no_textual_enforcement_bridges anti-pattern — "never propose grep/regex as interim enforcement; text-gating 'be structural' defeats itself." A textual comment is gameable; a developer could add `// AUTO-GENERATED FROM .dag` to a hand-authored file to bypass the ratchet. The THESIS claim ("every Rust test ports to .dag or is generated") is structural and requires a structural predicate. **Fix**: replaced the textual-marker predicate with the structural EXPECTED_HAND_AUTHORED_TEST list-emptied authority — the same ratchet Gap 1 uses for EXPECTED_HAND_AUTHORED_NON_TEST. Every hand-authored test entry must be named on the list (PR-template enforcement); migrations remove entries; close fires when list empties. The list discriminates structurally, not textually. Preserved the no-boundary-carve-out authority citations (separate codex BLOCKING) — boundary entries are named on EXPECTED_HAND_AUTHORED_TEST and dissolve through migration like any other entry, no separate carve-out. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 13, 2026
codex BLOCKING 2026-05-13T18:22:57Z (sha f05359f) — 3 root-causes + 1 improvement: **B1 — Tier-2 feature-deferral example removed entirely** (Gap 1 alternative-disposition): Prior fix at a973064 retained the fabricated example in retraction-framing. Codex stronger ask: "remove the example OR require operator-approved amendment to PB-zero authority". Reframed: no Tier-2 example survives this section; any R4-carve requires BOTH (1) override of project_no_r4_carves_directive AND (2) amendment to docs/design-pure-bootstrap-zero.md authority text adding a per-subset deferral carrier. Neither alone is sufficient. **B2 — Generator-manifest positive structural authority** (Gap 5 close criterion): Prior fix at 29684a0 gave negative authority (list-emptied) but codex asks positive form. Added dual predicate: (a) EXPECTED_HAND_AUTHORED_TEST = empty [negative] + (b) generator-manifest maps each surviving test → its .dag source + regeneration-byte-equality fail-close on drift [positive]. Catches orphan generated files that negative form alone misses. Substrate prereq: manifest carrier authored as Cluster M Phase 3 expansion. **B3 — Deferral carrier with named reason** (Gap 9 substrate-shape): Prior fix at 5872dae had correction: Witness covering only the 100% path. Codex asks separation of absolute-thesis vs pragmatic-residual into named carrier variants. Reshaped to sum Correction = LiveCorrection { witness } | DeferredCorrection { reason, retirement_plan }. Diagnostic.correction is mandatory Correction (not Option). Residual is structurally named with retirement-plan accountability; gate #84/#106 close requires every DeferredCorrection ratchetable to zero per its own retirement plan. **NB1 — Ledger-derived row-count** (Gap 10 close criterion): Hard-coded "ALL 105 rows" rotted as soon as Gap 9 proposed row #106. Per feedback_no_snapshot_integers_in_briefs: derive count from §1.8 ledger at execution time via grep enumeration; Gap 9 row #106 + subsequent additions automatically included. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 13, 2026
…ncing (DRAFT) (#3013) * docs(r3): R3 actual-close plan — 10 adversarial gaps with disposition + dispatch sequencing (DRAFT pending Director + operator ratification) Operator directive 2026-05-13 verbatim: "can we start on the planning docs to get to ACTUAL r3 close? like all of our adversarial questions answered positively? i feel like the planning for this stuff has been continuously dropped". PM-authored planning doc replacing "viz-as-SoT closed_at + DECLARED-strings-are-drift" framing with explicit per-gap disposition for the 10 substantive counterfactuals surfaced by today's adversarial audit: 1. PB-0 zero hand-Rust (177+ entries in EXPECTED_HAND_AUTHORED_NON_TEST; gate #8 DECLARED) 2. L5 cross-target consistency (gate #15 DECLARED; no Python/Go executable emission on main) 3. Self-host fixed point R3-strong (gate #16 R1-horizon only; 4 joint preconditions deferred) 4. Lens behavioral parity (3 of 4 lenses NOT behaviorally complete; gates #79/#81/#82/#83) 5. Tests-as-data completeness (gate #84 Cluster M Phase 3 bulk-port pending; load-bearing-blocking) 6. v2 retirement terminal (gate #97 coherence-only; src/v2/ exists at HEAD) 7. T-WAD FULL R3 (gates #98-#103 all DECLARED; ci.yml still hand-edited) 8. Bootstrap-seed Rust survivors (folded into Gap 1) 9. Show-the-correct-code (no §1.8 gate exists for THESIS:103-105) 10. Close-audit doc absent (interrogation §8 self-check has no execution log on main) For each gap: promise verbatim + HEAD evidence + what's missing + plan to cash (owner, sub-program, effort estimate) + close criterion predicate. §2 dispatch sequencing: 6 phases A-F mapped to Substrate Mgr / Verification Mgr / Debt-Paydown Mgr / Director-tier coordination / PM-direct. §3 total time-to-actual-close: 8-12 weeks optimistic; 12-20 realistic; 6+ months if PB-0 retirement is the longest tail and can't parallelize aggressively. §4 operator decision points: 4 binary IN-R3 / R4-defer choices that determine actual R3 scope (PB-0, L5 cross-target, self-host R3-strong, show-correct-code). §5 process discipline (preventing future drop): single authoritative plan doc, weekly PM closure-cadence message, per-gap closure-PR template, Gap 10 (close-audit doc) authored FIRST as receipt mechanism. Authority: - Operator directive 2026-05-13 (planning request) - Today's adversarial audit findings (counterfactual evidence against viz-as-SoT closure claim) - THESIS.md promise enumeration + r3-close-interrogation.md §-by-§ adversarial structure - §1.8 closure-authority ledger gate state at HEAD Status: DRAFT pending Director ratification + operator scope-decision approval before dispatch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): Gap 4 — cite closed PR #2860 as content-source for parallelism cementing-receipt re-launch (Director msg_b3324a05 flag) Director (msg_b3324a05) flagged PR #2860 (G87-C parallelism cementing receipt + ratchet repair, closed 2026-05-13T16:45:44Z under operator cleanup directive) as load-bearing for counterfactual #4 / Gap 4 parallelism behavioral parity. The PR content is retrievable via `gh pr view 2860 --json body` so the Gap 4 cementing-receipt re-launch doesn't author from scratch. Adds PR #2860 reference to Gap 4 sub-program as step 2 (between F-α and F-β.1), with concrete artifact paths + dissolution-trigger naming + relationship-to-F-α clarification (cementing-receipt is gate-#87 ratchet-discipline level, distinct from F-α Stage 2e walker port which is substrate work). Both are required for full Gap 4 closure. Cementing-receipt re-launch is cheaper (PR #2860 substance ready); F-α walker port is the larger substrate scope. Authority: - Director msg_b3324a05 flag (2026-05-13) - PR #2860 substance per gh API retrieval - §1.8 row #87 lens_cementing_test_discipline_complete (CONSUMER_LANDED + PASSING; ratchet fires on inventory mismatch) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): integrate Director msg_cd2d8d7d 8 substantive feedback items into close plan Director (zesty-bear-812) ratified PR #3013 structure + dispatch sequencing + §5 process discipline. 8 substantive items applied: 1. **§4 R4-carve framing collision** — Per `project_no_r4_carves_directive` (Brian 2026-05-08), R4-carve is NOT freely available as default. §4 reframed: 4 decisions default to IN-R3; explicit override required with stated structural-unblockable reason. §5 process-discipline note added. 2. **Gap 3 R2-Evaluator audit** — Director-tier deliverable picked up by zesty-bear-812 (this week per msg_cd2d8d7d). §6 deliverables list tracks. 3. **Gap 4 sequential cadence as Mgr-bandwidth lever** — Effort estimate split: single-Mgr sequential 4-8wk vs parallelized-via-2nd-Substrate-Mgr ~2-4wk. Surfaced as tightening lever, not foreclosed. 4. **Gap 5 close-criterion header-marker filter** — Predicate amended to `xargs grep -L "// AUTO-GENERATED FROM .dag" | wc -l == 0` so generated-from-.dag tests are filterable. Substrate prereq: code-gen emits header line; if not present at HEAD, lands in Gap 5 Phase 3 ratchet. 5. **Gap 6 transitive-dependency depth** — Explicit 5+ deep chain call-out: Gap 6 ← Gap 3 ← {Gap 1, R2-Evaluator, R2-Grounding, Row-B}. Gap 6 framed as close-ceremony terminal gate (last 2 weeks of R3 close). 6. **Gap 9 threshold = operator decision** — ≥80% pragmatic relaxation is operator-decision-shaped, not Director-decision. §4 now surfaces (a) IN-R3 vs not-R3-promised choice + (b) if IN-R3, threshold = 100% (THESIS-correct) or ≥X% pragmatic with named-residual list. Per `project_no_r4_carves_directive`, the not-R3-promised reframe is structurally an R4-carve requiring operator override. 7. **Gap 10 timeline calibrated** — Skeleton 1-2 days (PM-direct, unblocked, immediate); execution 1-2 weeks (Verification Mgr serial) or 3-5 days (ctrl-build parallel). Overall ~1-2 weeks for full landing. 8. **Phase F bookkeeping downstream of close-audit-doc verdict** — §2 Phase F reworded: §1.8 manifest strings sync to close-audit-doc predicate-execution outcome (View-4-authoritative per `feedback_r3_close_three_views_drift`), NOT to procedural `closed_at` markers. Sequencing: close-audit-doc lands first; bookkeeping PR consumes that doc as authority. Avoids procedural-closure trap. §6 pending-decisions list updated: - Director ratification: checked ✓ - Operator §4 confirmations: 4 sub-items per gap - Director-tier deliverables in-flight per msg_cd2d8d7d (4 items) - Operator Phase A authorization Authority: - Director ratification msg_cd2d8d7d (2026-05-13) — substance verdict + 8 feedback items - `project_no_r4_carves_directive` (Brian 2026-05-08, 5d-old memory but still presumptively in force; surfaced for operator confirmation) - `feedback_r3_close_three_views_drift` View 4 authoritative (Director memory update post-msg_b3324a05) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): claude review 11247 exploratory observations integrated (PM recs explicit per gap + Gap 9 canvas-promotion note + §3 velocity-citation discipline) 3 non-blocking exploratory observations from claude APPROVE review on PR #3013 sha a4d1608 at 2026-05-13T18:03:26Z: 1. **§4 PM-recommendation explicitness across all 4 gaps** — previously only Gap 1 stated "do not defer." Added explicit PM-recommended IN-R3 + reasoning for Gaps 2/3/9 with each R4-carve's specific dilution impact (omni-emission falsifier loss, self-host thesis dilution, THESIS:103-105 absolute promise drop). §4 preamble now states cross-gap PM view + per-gap recommendation. 2. **Gap 9 substrate-shape canvas-promotion** — `correction: Option<Witness>` field commitment is buried in planning-doc prose; promoted to Substrate-Mgr-canvas-before-worker-dispatch step. Canvas authoring + Director ratification gates worker dispatch. 3. **§3 velocity-citation discipline** — most estimates were unsourced beyond Gap 1's `feedback_pre_authored_brief_queue` reference. Added explicit caveat: Gaps 2/3/5/6/7/9 are PM-prior-cycle-experience-based; final ratified version cites per-gap velocity reference + first weekly closure-cadence message calibrates against actual landing-date data. Authority: - claude APPROVE review 11247 on PR #3013 sha a4d1608 at 2026-05-13T18:03:26Z - All 3 observations non-blocking; addressing pre-operator-review for cleaner ratification Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): retract Gap 5 boundary carve-out + Gap 9 pragmatic-relaxation per codex BLOCKING PR #3013 Two substantive close-criteria fixes per codex BLOCKING 2026-05-13T18:19:56Z: **Finding 1 — Gap 5 boundary carve-out violates 0-residual** (TESTING.md L212-217 + docs/design-pure-bootstrap-zero.md:41,138): - Removed `-not -path "*/boundary/*"` from gate #84 close predicate - Added authority citation: TESTING.md "🔄 RETRACTED 2026-04-25" + 0-floor target - Boundary tests ARE counted; migrate to ExecuteCommand-based .dag TestClaim per cascade **Finding 2 — Gap 9 pragmatic-relaxation dilutes THESIS absolute** (THESIS.md "show the correct code" reads as absolute promise): - Removed "Pragmatic relaxation (≥X%)" alternative from Gap 9 close criterion - Removed §4 operator sub-decision (b) threshold negotiation - Close criterion is 100% absolute; non-100% requires R4-carve override of project_no_r4_carves_directive (NOT within-R3 threshold negotiation) **Additional: Phase F adversarial re-pass discipline** (operator directive 2026-05-13 — final closeout will be adversarial analysis): - Phase F now explicitly includes operator+PM adversarial re-pass against interrogation doc + close plan + §1.8 row statuses - Bookkeeping PR sequencing updated: depends on adversarial-re-pass verdict, not just predicate execution outcome - Symmetric to 2026-05-13 adversarial sweep that surfaced 10 counterfactuals; applied at close ceremony to confirm none survived Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): retract fabricated Tier-2 R4-deferral authority per briansrls BLOCKING PR #3013 briansrls BLOCKING 2026-05-13T18:22:57Z at docs/r3-actual-close-plan.md:48: > "The PB-0 alternative disposition cites design-pure-bootstrap-zero.md as > allowing Tier-2 R4 deferral for grounding submodules, but that authority > sets a 0 hand-authored in-tree Rust floor, so this creates an unauthorized > escape hatch against the Pure Bootstrap target." **Verified**: grep -nE "tier[- ]2|grounding|R4|defer|carve" against docs/design-pure-bootstrap-zero.md returns ONLY one hit (L131: historical TESTING.md carve-out which the doc explicitly retracts under 0-floor target). Zero references to "Tier-2", "grounding submodules deferred", or any R4-deferral carve-out mechanism. The "Tier-2 R4-deferred per design-pure-bootstrap-zero.md" citation in Gap 1 alternative-disposition was fabricated authority — an unauthorized escape hatch against the absolute 0-floor target. **Fix**: - Removed the fabricated citation - Explicit statement: PB-0 design doc admits no internal escape hatch - R4-carve of PB-0 subsets requires explicit operator override of project_no_r4_carves_directive (2026-05-08), naming specific subset + structural-unblockable reason — not citation of an unauthorized escape - PM-recommendation preserved (do NOT R4-defer; standing directive applies) Symmetric to the Gap 9 pragmatic-relaxation fix at commit 870f6ce — both findings reflect the same anti-pattern of converting absolute thesis claims into negotiable thresholds via fabricated/imputed authority. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): replace textual AUTO-GENERATED marker with structural EXPECTED_HAND_AUTHORED_TEST list-emptied predicate per briansrls BLOCKING PR #3013 briansrls BLOCKING 2026-05-13T18:22:57Z at docs/r3-actual-close-plan.md:183: > "The gate #84 close predicate uses the `// AUTO-GENERATED FROM .dag` > comment as the authority for generated tests, which can pass with > hand-authored Rust carrying the marker and does not prove the THESIS > tests-as-data claim." **Verified**: this is exactly the feedback_no_textual_enforcement_bridges anti-pattern — "never propose grep/regex as interim enforcement; text-gating 'be structural' defeats itself." A textual comment is gameable; a developer could add `// AUTO-GENERATED FROM .dag` to a hand-authored file to bypass the ratchet. The THESIS claim ("every Rust test ports to .dag or is generated") is structural and requires a structural predicate. **Fix**: replaced the textual-marker predicate with the structural EXPECTED_HAND_AUTHORED_TEST list-emptied authority — the same ratchet Gap 1 uses for EXPECTED_HAND_AUTHORED_NON_TEST. Every hand-authored test entry must be named on the list (PR-template enforcement); migrations remove entries; close fires when list empties. The list discriminates structurally, not textually. Preserved the no-boundary-carve-out authority citations (separate codex BLOCKING) — boundary entries are named on EXPECTED_HAND_AUTHORED_TEST and dissolve through migration like any other entry, no separate carve-out. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): retract Option<Witness> shape per briansrls BLOCKING PR #3013 — Practice-2 carrier refinement briansrls BLOCKING 2026-05-13T18:22:57Z at docs/r3-actual-close-plan.md:277: > "The proposed correction: Option<Witness> shape leaves 'diagnostic > without correction' representable even though the THESIS-correct path > requires diagnostics to point to the structurally correct program." **Verified** against three converging memory authorities: - feedback_state_space_vs_behavioral_invariants — "check if the type admits illegal state combinations; type enforcement > API enforcement" - feedback_optional_models_recovery_as_exception — "T? where absence is the norm conceals plurality" - feedback_practice_2_vs_4_same_variant_vs_cross_variant — Practice-2 carrier refinement when the redundant/illegal state crosses variant boundaries Option<Witness> admits None which structurally represents "diagnostic without correction" — exactly the state THESIS.md "show the correct code" forbids absolutely. The type itself admits the illegal state; behavioral checks ("did this fired diagnostic produce a correction?") are API-tier enforcement that the carrier-tier should subsume. **Fix**: substrate-shape constraint added to Gap 9 sub-program step 4: canvas authors MUST commit `correction: Witness` (non-optional) — Practice-2 carrier refinement makes diagnostic-without-correction unrepresentable by construction. Anti-pattern symmetric to Gap 9 pragmatic-relaxation fix at 870f6ce (both findings convert absolute THESIS claim into expressible-but-forbidden state). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): address 3 codex BLOCKING + 1 non-blocking on PR #3013 codex BLOCKING 2026-05-13T18:22:57Z (sha f05359f) — 3 root-causes + 1 improvement: **B1 — Tier-2 feature-deferral example removed entirely** (Gap 1 alternative-disposition): Prior fix at a973064 retained the fabricated example in retraction-framing. Codex stronger ask: "remove the example OR require operator-approved amendment to PB-zero authority". Reframed: no Tier-2 example survives this section; any R4-carve requires BOTH (1) override of project_no_r4_carves_directive AND (2) amendment to docs/design-pure-bootstrap-zero.md authority text adding a per-subset deferral carrier. Neither alone is sufficient. **B2 — Generator-manifest positive structural authority** (Gap 5 close criterion): Prior fix at 29684a0 gave negative authority (list-emptied) but codex asks positive form. Added dual predicate: (a) EXPECTED_HAND_AUTHORED_TEST = empty [negative] + (b) generator-manifest maps each surviving test → its .dag source + regeneration-byte-equality fail-close on drift [positive]. Catches orphan generated files that negative form alone misses. Substrate prereq: manifest carrier authored as Cluster M Phase 3 expansion. **B3 — Deferral carrier with named reason** (Gap 9 substrate-shape): Prior fix at 5872dae had correction: Witness covering only the 100% path. Codex asks separation of absolute-thesis vs pragmatic-residual into named carrier variants. Reshaped to sum Correction = LiveCorrection { witness } | DeferredCorrection { reason, retirement_plan }. Diagnostic.correction is mandatory Correction (not Option). Residual is structurally named with retirement-plan accountability; gate #84/#106 close requires every DeferredCorrection ratchetable to zero per its own retirement plan. **NB1 — Ledger-derived row-count** (Gap 10 close criterion): Hard-coded "ALL 105 rows" rotted as soon as Gap 9 proposed row #106. Per feedback_no_snapshot_integers_in_briefs: derive count from §1.8 ledger at execution time via grep enumeration; Gap 9 row #106 + subsequent additions automatically included. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): close §6/§4 INVARIANTS P2 violation + footer drift per cursor APPROVE_WITH_COMMENTS PR #3013 cursor/composer-2 APPROVE_WITH_COMMENTS 2026-05-13T18:35:17Z: **Finding 1 — INVARIANTS P2 violation (§6 vs §4 duplicate Gap 9 authority)**: §6 operator checklist still offered "ratify threshold = 100% (THESIS-correct) OR ≥X% (pragmatic, X TBD); (b) override with not-R3-promised reframe" — exactly the within-R3 threshold negotiation that §4 retracted in the prior fix at 870f6ce. Two "authoritative" asks for the same Gap 9 decision = INVARIANTS P2 single-place- for-the-fact violation. **Fix**: rewrote §6 Gap 9 bullet to match §4 — single binary decision (IN-R3 at 100% absolute OR R4-carve via explicit operator override of project_no_r4_carves_directive). No threshold negotiation; no sub-decision (b) since §4 removed it. §4 is now the single authority for the Gap 9 disposition. **Finding 2 (exploratory) — §6 vs footer drift**: §6 line 453 marks "Director ratifies this plan structure — APPROVED 2026-05-13" ✓ but footer at line 471 still said "DRAFT pending Director ratification + operator scope approval". Director already ratified structure per msg_cd2d8d7d; only operator scope approval is pending. **Fix**: tightened footer to "Director structure-ratified 2026-05-13; DRAFT pending operator scope approval (§4 IN-R3 confirmations + Phase A dispatch authorization)" — preserves the actual gating state without contradicting §6 checklist. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): align Gap 9 close criterion to sum-variant Correction carrier per codex BLOCKING #11273 PR #3013 Prior fix at 9d763dd ratified `sum Correction { LiveCorrection | DeferredCorrection }` substrate-shape canvas (Practice-2 carrier refinement: nullable `Option<Witness>` admits illegal "diagnostic without correction" state). But the close criterion still read `correction: Witness` + `Some(_)` — the retracted Option shape it was meant to replace. P2 single-authority violation: two incompatible carrier shapes for the same Diagnostic.correction field in adjacent text. Rewrote close criterion as: - Structural (compiler-enforced): every Diagnostic carries mandatory `correction: Correction` field (sum-variant, no Option-wrapping) - Variant-tally (zero-DeferredCorrection): every fired Diagnostic in test corpus is LiveCorrection variant; count of DeferredCorrection = 0 - Substrate ratchet: every DeferredCorrection entry ratchetable to zero per its own retirement_plan field Preserved both retraction citations (codex BLOCKING #11254 pragmatic-relaxation + briansrls Option<Witness>) as audit trail. Close criterion now matches the canvas substrate-shape commitment by construction. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): absorb Director R2-Evaluator audit msg_82b9c4bb — Gap 3 expansion + §4 sub-item 5 (Mgr dispatch) + r3-program-plan thesis-state drift reframe Director-tier R2-Evaluator audit (PR #3013 Gap 3 precondition deliverable from msg_cd2d8d7d) surfaced 3 structural findings: (a) R2 closed-with-residuals 2026-04-29 16:34Z (#1275; ROADMAP.md:512) with 5 sub-lanes carried as r3-continuation: runtime_value_model_structural (in-flight #1197/#1228/#1231), body_evaluator_structural (not-started), lens_application_complete_reflection (in-flight #1191), witness_construction_structural (not-started), cross_target_equivalence_harness_structural (not-started). Closure-ledger row stale @ #1191-#1231 era (HEAD is #3013+). (b) R3 Evaluator Mgr merry-gull-128 (#1743) ABSENT from current subtree at HEAD. Authority dispersed across 3 R3 Mgrs without single owner — r2-structure.md:73 anti-pattern reincarnation under R3-tier-slice procedural wrapper. (c) Brief surface comprehensive (r2-evaluator-manager.md + 4 sub-briefs + 10+ PR-A-E + R3-tier per-slice briefs); not the gap. (d) Director recommends re-spawn evaluator Mgr as 4th R3 Mgr lane. PM execution (bundled per feedback_bundle_workstreams_per_pr): 1. r3-actual-close-plan.md Gap 3 expansion: cite all 5 sub-lanes explicitly; reframe R2-Evaluator HEAD evidence from "landed" to "closed-with-residuals with 5 sub-lane debt"; note merry-gull-128 absence; close-criterion now requires (i) 5 sub-lanes ratchet-to-PASSING OR per-sub-lane R4-carve carrier with named retirement plan (substrate-shape symmetry with Gap 9 DeferredCorrection discipline), AND (ii) §4 sub-item 5 Mgr-dispatch disposition ratified. 2. r3-actual-close-plan.md §4 sub-item 5 (subtree-shape decision): R3 Evaluator Mgr dispatch with 3 operator sub-options — (a) re-spawn 4th lane PM+Director recommended, (b) fold into existing R3 Mgrs with named risk, (c) Director-direct ad-hoc PM-does-not-recommend per r2-structure.md:73 retraction. §6 checklist updated to track. 3. r3-program-plan.md lines 429/435 reframe: strike "R2-Evaluator (interpreter-as-data; LANDED)" / "R2-Evaluator landed" → "R2-Evaluator closed-with-residuals 2026-04-29 16:34Z per ROADMAP.md:512 — sub-lane completion partial via R3-tier slices, see Gap 3 in r3-actual-close-plan.md". Catches feedback_thesis_gate_state_drift class. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): split Gap 3 close criterion from dispatch staffing prereq + use r2-closure-ledger authority for sub-lanes per Director notes msg_f0a54769 PR #3013 Director note msg_f0a54769 surfaced 3 substantive shape issues on the 85c230b Director-audit absorption: Note 1 (sub-lane name authority): the 5 R2-Evaluator sub-lane names (runtime_value_model_structural / body_evaluator_structural / lens_application_complete_reflection / witness_construction_structural / cross_target_equivalence_harness_structural) live in `docs/r2-closure-ledger.md:250-263`, NOT as §1.8 row IDs in `docs/r3-program-plan.md`. Prior draft conflated authorities ("PASSING in §1.8" mismatches the actual artifact). PM-selected path (α): use sub-lane names as predicate authority per `feedback_parallel_representation_debt` — don't introduce 5 new §1.8 rows for already-named ledger content. Predicate is cell-level check of `docs/r2-closure-ledger.md` (each sub-lane row status=green at HEAD); closure-ledger row stale @ #1191-#1231 era requires refresh first. Note 2 (staffing-as-criterion vs precondition): staffing/dispatch shape is a PRECONDITION for execution, not a close criterion for the substrate-debt itself. If a Mgr exists but doesn't close the 5 sub-lanes, Gap 3 isn't closed; if alternative dispatch (fold/ad-hoc) closes them, Gap 3 IS closed. Moved "(ii) R3 Evaluator Mgr lane owner identified" from close criterion to new "Dispatch staffing prereq" section. Close criterion now purely substrate-debt-shaped. Note 3 (sequencing): re-spawn AFTER operator §4 sub-item 5 ratification, NOT before. Sequence explicit in Dispatch staffing prereq section per `feedback_construction_over_ratchets` adjacent class — don't author the Mgr until the operator-decision substrate cashes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): operator-ratification recorded — all 4 IN-R3 + §4 sub-item 5 re-spawn (a) + Phase A authorized PR #3013 Operator (briansrls) ratification 2026-05-13 via direct PM dispatch: - Items 1-4 (R3 scope decisions): ALL IN-R3 confirmed per project_no_r4_carves_directive default. No R4-carves. - Gap 1 (PB-0): full 177-entry retirement - Gap 2 (L5 cross-target): full 3-target Python+Go - Gap 3 (self-host R3-strong): 4-joint-precondition cascade - Gap 9 (show-correct-code): 100% absolute (zero DeferredCorrection per sum-variant carrier) - Item 5 (R3 Evaluator Mgr dispatch subtree-shape decision): (a) re-spawn as 4th R3 Mgr lane confirmed. Director (zesty-bear-812) executes per pre-authorization at msg_d456b60d. - Phase A immediate dispatch authorized (implicit in ratification). Close-audit doc skeleton + §1.8 row #106 authoring proceeds PM-direct post-merge. §6 checklist updated: all operator-decision boxes checked. Director-tier deliverable R2-Evaluator audit also marked complete (msg_82b9c4bb 2026-05-13; absorbed at 85c230b + 97cfb9d). Footer status updated from "DRAFT pending operator scope approval" to "operator fully ratified 2026-05-13; READY FOR DISPATCH post-merge". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3-close): absorb codex BLOCKING #11284 + reframe alternative-disposition class per operator §4 ratification PR #3013 Codex BLOCKING #11284 (2 findings on 97cfb9d): F1 — `docs/r3-actual-close-plan.md:11` closure target generically allowed any adversarial gap to be "explicitly R4-deferred", semantically reintroducing a carve-out path the design-pure-bootstrap-zero.md + r3-program-plan.md authorities explicitly forbid. PM-intent dilution. F2 — `docs/r3-actual-close-plan.md:89` Gap 2 alternative-disposition authored Rust-only-Shape-A scope-narrow as an explicit fallback, semantically weakening the §3.1 3-target promise without prior authority reconciliation. Both findings are an instance of a broader class: alternative-disposition language across §0 + Gaps 1/2/3/9 was authored pre-ratification when operator hadn't yet foreclosed those paths. Post-operator-§4 ratification 2026-05-13 (ALL IN-R3, no R4-carves), they are stale-against-ratification. Consistent reframe applied to all 4 alternative-disposition instances: - Line 11 (§0 closure target): R4-defer / THESIS-reframe paths STRUCTURALLY FORECLOSED per operator §4 IN-R3 ratification; legacy alt-disposition sections retained as audit-trail not as available paths. - Line 48 (Gap 1 alt disposition): operator §4 Item 1 IN-R3 ratification supersedes; dual-amendment authority chain preserved as closure-rule discipline for any future re-opening. - Line 89 (Gap 2 alt disposition): operator §4 Item 2 IN-R3 ratification forecloses Rust-only-narrow. - Line 133 (Gap 3 alt disposition): operator §4 Item 3 IN-R3 ratification forecloses R1-horizon-narrow + 5-sub-lane R4-carve. - Line 342 (Gap 9 alt disposition): operator §4 Item 4 IN-R3 ratification forecloses THESIS-aspirational-not-R3-promised reframe. Also propagated ratification state into §4 header (request-for-ratification → RATIFIED 2026-05-13) + line 3 Status line (DRAFT → FULLY RATIFIED). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 13, 2026
briansrls
added a commit
that referenced
this pull request
May 13, 2026
briansrls
added a commit
that referenced
this pull request
May 13, 2026
briansrls
added a commit
that referenced
this pull request
May 13, 2026
4 tasks
briansrls
added a commit
that referenced
this pull request
May 13, 2026
* Gate Rust tests behind generated manifest * WIP: R3 Gap 5 Cluster M Phase 3 — 99-Rust-test bulk-port dispatch (gates #84 * Separate Rust test generator manifest * WIP: R3 Gap 5 Cluster M Phase 3 — 99-Rust-test bulk-port dispatch (gates #84 * Keep Rust test manifest in hand-authored ratchet * WIP: R3 Gap 5 Cluster M Phase 3 — 99-Rust-test bulk-port dispatch (gates #84 * Rerun CI after SG-0 body fix * Restore SG-0 inline test receipts
This was referenced May 13, 2026
briansrls
added a commit
that referenced
this pull request
May 14, 2026
* §1.8 ledger-receipt sync — rows #84 #86 post-PR-#3040 landing Per feedback_post_merge_ledger_receipt_sync: atomic post-merge ledger sync following PR #3040 squash-merge (SHA 7c29361 "R3 Cluster M generator-manifest substrate refinement (shape-only; Gap 5 close prereq)"). Row #84 `every_rust_test_ports_to_dag_or_generated`: - Adds explicit substrate-shape-readiness landing citation against PR #3040 / 7c29361 (GeneratedFromDag.manifest_entries + sum-variant GeneratedManifestEntry = PendingFact | ResolvedFact per Director msg_3b99a90f). - Documents that Gap 5 actual close remains gated on the follow-up Evaluator-Mgr-owned runtime PR per Director Q-RegenCapability β SPLIT disposition (msg_606e0e50) + brief §7.1: 3-way byte-equality assertion + directory-walk orphan-output detection at the well-known tests/ scan-root. - References the Verification-Mgr-owned per-file FixtureMapping enumeration follow-up (brief §7.2) that materialises ResolvedFact instances once the runtime PR lands. Row #86 `program_generator_carrier_landed`: - Preserves CONSUMER_LANDED + PASSING status. - Adds "refined shape PASSING preserved in-place" citation against PR #3040 / 7c29361 — the carrier moved from generated_paths: List<Path> to manifest_entries: List<GeneratedManifestEntry> (sum-variant) without PASSING regression; r1c_d_pb_census_gates_suite_evaluates_through_runner continues green under the refined shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Fix row #86 test symbol — module-qualified, no spurious t_ prefix (cursor finding) cursor/composer-2 APPROVE_WITH_COMMENTS flagged a naming slip: ledger row #86 named the receipt as `t_r1c_d_pb_census_gates_suite_evaluates_through_runner` but the wired integration test is `t_pb_b_1_dag_runner_test::r1c_d_pb_census_gates_suite_evaluates_through_runner` (no `t_` prefix on the test fn; the `t_` lives on the module name). The .dag harness header at tests/dag/t_r1c_d_pb_census_gates.dag is the source of truth. INVARIANTS 'documentation describes live state' — grep-accurate symbol restored. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
briansrls
added a commit
that referenced
this pull request
May 14, 2026
…festEntry PendingFact|ResolvedFact shape from PR #3040 (7c29361); attach generated-survivor entries to manifest_entries; update #84/#85 close-predicate consumer without adding hand-Rust-only ratchet entries (#3051) * WIP: R3 Gap 5 generator-manifest integration sweep — consume GeneratedManifes * WIP: R3 Gap 5 generator-manifest integration sweep — consume GeneratedManifes * chore: regen bootstrap snapshots after verification.dag comment drift CI `regen_bootstrap --verify` requires committed bootstrap_generated*.rs to match fresh compile from std .dag authorities. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: R3 Gap 5 generator-manifest integration sweep — consume GeneratedManifes * fix: sync R1C-D GeneratedFromDag manifest with full REGEN_OUTPUTS Codex REQUEST_CHANGES (review 11559): manifest_entries must match build.rs::REGEN_OUTPUTS exactly for set-equality with GENERATED_FILES. Adds PB-0 cycle-4 + emit/shim/projection survivors omitted from the prior fixture; comment documents lockstep maintenance (P2 single authority). Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: R3 Gap 5 generator-manifest integration sweep — consume GeneratedManifes --------- Co-authored-by: Cursor <cursoragent@cursor.com>
1 of 2 tasks
briansrls
added a commit
that referenced
this pull request
May 14, 2026
…NSUMER_LANDED (#3107) §1.8 row #73 promoted DECLARED → CONSUMER_LANDED — host harness landed at src/v3/compiler/tests/integration/lens_behavioral_parity_demonstration_test.rs with 12 r3_gate_73_* assertions green at HEAD, covering all 4 in-R3 lenses (complexity + cost + parallelism + effect_enumeration) on representative inputs against frozen Rust expectations. PASSING remains blocked on Gate73_ReportPredicateCarriers paydown per ROADMAP §"R3 Cluster M / §1.8 gate #84 coordinator anchors" — report-shaped parity slices (ComplexitySummary, workflow parallelism, effect-enumeration report parity) still lack substrate-evaluable TestPredicate carriers; only the symbolic-cost slice was paid 2026-05-12. Closes brief docs/briefs/r3-wave1-s5-lens-behavioral-parity-worker.md §0 status flip; advances T-Lens-Behavioral-Parity gate count. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
briansrls
added a commit
that referenced
this pull request
May 14, 2026
Remove p0_std_render_repeat_string_test.rs: it only called assert_p0_repeat_string_correct_gate_passes(), identical to test_runner_test::test_runner_runs_p0_repeat_string_correct_gate. Coverage remains in tests/fixtures/r1_gates.dag (TestClaim data) plus the existing test_runner integration receipt. Shrinks EXPECTED_HAND_AUTHORED_TEST by one row toward every_rust_test_ports_to_dag_or_generated. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
May 14, 2026
#3122) Remove p0_std_render_repeat_string_test.rs: it only called assert_p0_repeat_string_correct_gate_passes(), identical to test_runner_test::test_runner_runs_p0_repeat_string_correct_gate. Coverage remains in tests/fixtures/r1_gates.dag (TestClaim data) plus the existing test_runner integration receipt. Shrinks EXPECTED_HAND_AUTHORED_TEST by one row toward every_rust_test_ports_to_dag_or_generated. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the SDLC (Software Development Lifecycle) pipeline implementation, adding the worker dispatch loop, per-stage handlers, a command-line binary, and comprehensive integration tests. The pipeline now orchestrates the full issue lifecycle from discovery through completion.
Key Changes
Core Pipeline Implementation
funcs/sdlc_worker.dag): Discovers SDLC-labeled issues, acquires claims, dispatches per-stage handlers, and records outcomesfuncs/sdlc_stages.dag): Eight stage transition handlers (idea→design→review→accepted→implementing→code-review→testing→done)workflows/sdlc.dag): Connected intake (parameter validation), worker dispatch, and reporting stages with proper stage dependenciesfuncs/sdlc_dispatch_runtime.dag): Pre-execution validation policy for stage transitionsCommand-Line Binary
gunbc-sdlcbinary (src/bin/sdlc.rs): Main entry point supporting:Service Transport Declarations
transportblocks to all 26 service operations:Integration Tests
sdlc_scenario.rs): Hermetic DryRun execution with unit_test profilesdlc_handlers.rs): Per-stage handler compilation and structure validationsdlc_worker.rs): Worker dispatch loop structural testssdlc_integration.rs): Local profile compilation and full lifecycle tests (ignored, require GITHUB_TOKEN)sdlc_testgen.rs): Auto-discovery and testgen validation for SDLC modulesCompiler Improvements
include_profile_modulesto accept optional profile string for better profile handlingImplementation Details
execute_stage()which dispatches based on current issue statehttps://claude.ai/code/session_01XmJNtYizWWs1HeGcPYxQWe