Repository navigation
Grounding G6: §1.8 gate #97 emit-shim coherence consumer (#1982) - #2281
Merged
Merged
Conversation
Adds method_template_projection_emit_shim_retirement_coherence (#1982): integration test enforces Gap-4 dag-emit shim + Cargo bin iff src/v2/stage0 exists, forcing Grounding shim removal after PB v2-directory deletion without allowing drift. Ledger + r3-structure Acceptance updated; totals 96→97 gates / 93→94 load-bearing. Co-authored-by: Brian Searls <briansrls@users.noreply.github.com>
briansrls
commented
May 8, 2026
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
2a9f83e2· Trigger:schedule - Thinking:
170s wall
BLOCKING (1)
Root Cause
src/v3/compiler/tests/integration/method_template_projection_emit_shim_coherence_test.rsThe gate models the bin as a file-path fact instead of the Cargo target fact → assert the emit_method_template_projection [[bin]] entry in src/v3/compiler/Cargo.toml tracks v2 alongside the source path.
| let v2_stage0 = workspace_root.join("src/v2/stage0"); | ||
| let shim_lib = | ||
| workspace_root.join("src/v3/compiler/src/pb_method_template_projection_dag_emit.rs"); | ||
| let shim_bin = |
Contributor
Author
There was a problem hiding this comment.
BLOCKING: Gate #97 claims the Cargo bin remains, but the consumer only checks the source file; with autobins = false, removing the [[bin]] entry while v2 remains would still pass, violating P2 boundary discipline.
…ction autobins=false makes the Cargo.toml [[bin]] target the load-bearing fact; scan manifests so removing only the table entry cannot pass while v2 remains. Docs: §1.8 row #97 + r3-structure Pass body aligned with codex review. Co-authored-by: Brian Searls <briansrls@users.noreply.github.com>
This was referenced May 9, 2026
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…dence partition (openai-pro APPROVE_WITH_COMMENTS) openai-pro review on PR #2358 sha 93f187e → 9c61c4f: 2 valid findings. §0 authority cite: replaced local filesystem path (`/Users/briansrls/.worktrees/gunbc/zesty-bear-812 thread`) with durable GitHub-comment refs: - gunbc#846 #issuecomment-4411924843 (Director's initial relay) - gunbc#846 #issuecomment-4412008376 (subsequent ratification + partner-work delegation) §3.2 evidence partition: prior framing labeled the recent-PR list as "materially reduced entries" but included enabling-only landings (#2281 +1, #2271 net 0, #2200 added entries). Re-partitioned into: - "Census-reducing landings" (only PR #2279) - "Enabling-only landings" (#2281, #2271, #2200) — substrate/scaffold work that does NOT reduce census in-PR - Recomputed rate using only census-reducing landings: ~0.25/day or ~0.5-1/cycle (upper bound) - Added explicit "Why this matters for §3.3" sentence clarifying enabling-only events are prerequisites, not reductions Boundary discipline + Modeling Faithfulness re-grounded; rate calculation now cleanly traceable to evidence. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks done
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…2358) * docs(audit): R3 PB-0 velocity walk + SG-0 census trajectory finding Director-greenlit follow-up to PR #2300 cluster analysis. Honest census walk + velocity-to-zero math against gates #8 (sg0_non_test_zero) + #84 (every_rust_test_ports_to_dag_or_generated) — the Pure-Bootstrap-Zero closure gates per THESIS.md:298 + ROADMAP.md:53/88. LOAD-BEARING FINDING: SG-0 census is GROWING, not shrinking. 9-day delta 2026-04-30 → 2026-05-09: +30 entries (119 → 149), at +3.3/day average. R3 close requires gates #8 + #84 reach 0; at current trajectory the gates never close. Per-class partition shows ~80-90 of 101 test entries dissolve via single bulk event when Cluster M (T-Tests-As-Data-Completeness) lands; remaining classes dissolve via PB-Runtime + T-V2-Retirement + T-Tier3-Dissolution + LP-Retirement. Reclassifies Cluster M as critical-path-load-bearing for PB-0 closure thesis (PR #2300 had it as parallel). Without Cluster M COMPLETE, gate #84 cannot close inside 8-12 week R3 window. Surfaces 2 NEW honest-close risks (Risk 5 trajectory + Risk 6 Cluster M dispatch status) for Director cycle absorption + Brian-tier framing question on whether "PB-0 by R3 close" is still load-bearing or has drifted. Cites THESIS.md, ROADMAP.md, r3-program-plan.md §1.8 + §10, prior cluster analysis as parents; does not restate gate Pass-conditions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §4 dependency picture — separate substrate-flow vs PB-0-closure edges (codex BLOCKING) Codex review on PR #2358 line 92: §4 dependency diagram had A → B → M (substrate flow) but §5 Risk 4 + PR #2300 §4 Risk 2 reference M → B → E (PB-0-closure sequencing). Inconsistent edge directions violated INVARIANTS P2/P5 single-authority-metadata for sequencing. Resolution: §4 now explicitly carries two edge-classes: - View 1 substrate-flow: A → {B, M} (parallel-post-A) - View 2 PB-0-closure: M → (B-PB-0-honest cementing-in-dag) → E Both views are simultaneously true under different relations (substrate-availability vs closure-readiness). The "M → B → E" sequencing in §5 Risk 4 corresponds to View 2 — closure-honesty sequencing, not substrate flow. PR #2300 §2 had M classified as "parallel" which is correct under View 1 substrate-flow but missed View 2 PB-0-closure-readiness; this audit's reclassification of M as "critical-path" is correct under View 2 closure-flow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §0 + §3.2 — durable authority cite + dissolution-rate evidence partition (openai-pro APPROVE_WITH_COMMENTS) openai-pro review on PR #2358 sha 93f187e → 9c61c4f: 2 valid findings. §0 authority cite: replaced local filesystem path (`/Users/briansrls/.worktrees/gunbc/zesty-bear-812 thread`) with durable GitHub-comment refs: - gunbc#846 #issuecomment-4411924843 (Director's initial relay) - gunbc#846 #issuecomment-4412008376 (subsequent ratification + partner-work delegation) §3.2 evidence partition: prior framing labeled the recent-PR list as "materially reduced entries" but included enabling-only landings (#2281 +1, #2271 net 0, #2200 added entries). Re-partitioned into: - "Census-reducing landings" (only PR #2279) - "Enabling-only landings" (#2281, #2271, #2200) — substrate/scaffold work that does NOT reduce census in-PR - Recomputed rate using only census-reducing landings: ~0.25/day or ~0.5-1/cycle (upper bound) - Added explicit "Why this matters for §3.3" sentence clarifying enabling-only events are prerequisites, not reductions Boundary discipline + Modeling Faithfulness re-grounded; rate calculation now cleanly traceable to evidence. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): §8 meta-finding — closure-claims-vs-HEAD drift pattern (Director scope expansion) Director scope expansion at gunbc#846 #issuecomment-4412017502: 6 additional drift findings from parallel Director-tier audit sweep all share root cause "program-plan claims running ahead of HEAD reality." Director recommended folding pattern observation into this audit. §8 captures 9 specific drift instances across PM + 2 Director audits: 1. §1.8 status drift (this audit §1) 2. SG-0 trajectory drift (this audit §0) 3. TC1 #11 plan-language drift (Director ask 6) 4. 10 demonstration gates runtime-path drift (Director ask 7) 5. Substrate-gap-class #61 enumeration drift (Director ask 8) 6. Gate-count canonicalization drift (Director ask 9) 7. Gate #95 carve-doc cross-ref drift (Director ask 10) 8. §10.3 ratification ledger publication drift (Director ask 11) 9. R4-carve hand-Rust drift (PM ask 2026-05-09 at #828 #issuecomment-4412052024) Pattern shape: every instance is "document text asserts a closure-state that HEAD does not satisfy" via 4 sub-shapes (post-R3 substrate dep / trajectory divergence / one-sided conjunctive close / cross-ref drift). Standing recommendation: status-vs-HEAD grep cadence in standing PM/Director cycle (per-Mgr lane self-check + PM weekly §1.8/§10.3 grep). Meta-finding is structural-not-personnel: drift class closes when reconciliation cadence is added explicitly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §0 audit-time snapshot disclaimer (codex BLOCKING — staleness vs HEAD) codex BLOCKING inline @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:23: "HEAD census row is stale against sg0_census_test.rs." Verified: at PR branch sha 5ea313c the census is 49 + 102 + 2 = 153; on origin/main cf1d523 it's 50 + 103 + 2 = 155. Audit cited 48 + 101 + 1 = 149/150. Audit numbers ARE stale relative to HEAD — main has moved 1 commit past the PR branch since audit authored. Fix: add explicit "audit-time snapshot" disclaimer scoping the count cells to the audit window. Live source-of-truth for SG-0 trajectory is `docs/audit/r3-sg0-trajectory-tracker.md` (daily/per-cycle refresh). The trajectory finding (growth ≥ +3.3/day; gates cannot reach zero at observed velocity) is structural and remains valid regardless of point-in-time count drift; specific cells should be read "as of audit window" not "as of HEAD now." Per `r3-sg0-trajectory-tracker.md` §7 + audit §7: methodology durable; specific numbers ephemeral. The codex finding was correct that the audit numbers were presented as if HEAD-current; disclaimer now scopes them properly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): tracker-file forward-reference (codex BLOCKING — tracker on sibling PR #2361) codex BLOCKING inline @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:17: cited `docs/audit/r3-sg0-trajectory-tracker.md` is not in PR #2358's tree — it's on sibling PR #2361. If PR #2358 merges first, the reference points to a non-existent file (P1/P2 violation). Verified: tracker file IS on PR #2361 branch (blob `85e072cf`); IS NOT on PR #2358 branch or main. Fix: refactored references to: - Cite `src/v3/compiler/tests/integration/sg0_census_test.rs` directly as the live SG-0 census source-of-truth (file IS on main) - Note tracker artifact lands via sibling PR #2361; cite-once-merged - §8 standing-recommendation updated similarly Snapshot scope disclaimer now self-contained — audit can land independently of PR #2361 merge ordering. No forward-references to non-merged sibling content remain. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §4 gate #8 partial Cluster M overlap (openai-pro REQUEST_CHANGES) openai-pro review on PR #2358 sha cf89a69: §2.2 row "infer/lower/test_runner" listed Cluster M as part of test_runner's dissolution dependency, but §4 summary claimed gate #8 is "orthogonal to M/B closure flow" — internal contradiction. Fix: amended §4 to acknowledge partial Cluster M overlap for test_runner.rs specifically (test runner retires when Cluster M's TestClaim system can drive testing end-to-end as .dag data — i.e., when #87 cementing-test discipline + bulk-port discipline land). Gate #8 is now correctly characterized: mostly orthogonal to M/B closure flow, but not fully — test_runner.rs is the specific overlap entry per §2.2. Single canonical PB-0 closure dependency picture restored across §2.2 + §4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §1 — overclaim "every test entry has dissolution-trigger comment" corrected (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:40: prior framing claimed "every test entry has a header-comment naming a 'dissolution trigger'." Verified at HEAD: only ~32 of 103 test entries have inline header comments. The remaining ~71 are potentially untracked hand-Rust debt under INVARIANTS P1/P5 — option-(c) discipline assumes per-entry dissolution-trigger documentation but these lack it. Fix: §1 corrected to "About 32 of 103 test entries... the remaining ~71 entries lack inline dissolution-trigger comments." Added explicit audit finding: commentless entries are "potentially untracked hand-Rust debt" — they may have implicit dissolution paths (m1/m2 boundary tests via T-V2-Retirement + Tests-As-Data; sg* tests via Tests-As-Data; common/ helpers when downstream consumers retire) but lack the per-entry header comment. PM follow-up (Task 13): per-entry audit of ~71 commentless entries to classify under existing clusters OR flag as untracked debt requiring fresh substrate authoring or comment-attribution PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §2 cluster-level partition scope + §8 per-instance verification table (codex BLOCKING) codex top-level BLOCKING on PR #2358 sha 7a34af5: 2 valid findings. **Finding 1 — §2 trigger partition assumed-shape vs mechanical**: §2 partition was cluster-level estimation, not per-entry mechanical audit. Codex correct that "option-(c) dominance" claim needed grounding. Fix: §2 now explicitly scopes the partition as cluster-level methodology (NOT per-entry attribution) — derived from (a) inspection of header comments where present + (b) inferred classification of commentless entries by filename pattern. Per-entry verification deferred to Task 13 (UNACCOUNTED entries grep). The cluster-level partition supports §3 velocity-math finding without per-entry attribution; both §1 + §3 conclusions reproducible at cluster-level. **Finding 2 — §8 Director-audit bullets transcribed without per-instance verification**: §8 listed 9 drift instances by short reference; each bullet's grounding was implicit (verified in corresponding fix commits but not surfaced inline). Fix: §8 converted to verification table with explicit "Verification (landed authority)" column per instance. Each of the 9 drift instances now cites: - The grep-verified landed authority (e.g., `docs/r3-program-plan.md` §1.8 row #11 + Director disposition `473b99fb...`) - The fix commit / PR where addressed (e.g., PR #2361 sha 6efde88) - Dispositions where applicable (e.g., #7 dissolved by Task 12 PR #2364; #9 resolved by Director (a) ratification + Task 12) Each drift instance now self-grounds the §8 meta-finding without requiring readers to re-derive evidence per-bullet. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §1 trigger-coverage math reconcile to 101 (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:40: "trigger-coverage math says 32 of 103 test entries while the same audit snapshot and §2 say 101 test entries, so the remaining-debt count is internally inconsistent under INVARIANTS P1/P2." Verified: §1 used "32 of 103" + "remaining ~71" while §0 audit-time snapshot table line 25 + §2.1 line 56 + §2.1 line 69 + §3 line 134 all use 101. The 103 was introduced in commit ebfebae (BLOCKING fix for "every entry" overclaim) — I picked 103 instead of matching the existing 101 framing. Real internal inconsistency. Fix: §1 trigger-coverage reconciled to 101 (matches §0 audit-time snapshot table at sha c25b2d8df + §2.1 + §3 references): - "32 of 103" → "32 of 101" (with explicit cite to §0 snapshot) - "remaining ~71" → "remaining ~69" (101 − 32 = 69, partition-consistent) - §2 methodology cite "(~32 of 103 test entries per §1)" → "(~32 of 101)" Single audit-time-snapshot count (101) used consistently across §0/§1/§2/§3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §8 row 1 source pointer — cluster-analysis (openai-pro REQUEST_CHANGES) openai-pro REQUEST_CHANGES on PR #2358 sha 2ba3719: §8 drift instance #1 sourced "9 gates likely promotable to CONSUMER_LANDED" to "this audit §1" but §1 is the SG-0 option-(c) discussion, NOT a 9-gate status audit. The source pointer didn't actually ground the row. Verified: the 9-gate inventory is in docs/audit/r3-cluster-analysis-2026-05-09.md §1 (PR #2300, on main), which says verbatim: "9 gates likely-promotable from DECLARED → CONSUMER_LANDED. 88 → ~79 still-DECLARED if Mgrs refresh ledger." Fix: row 1 source pointer corrected to cluster-analysis doc citation with verbatim quote + retain the existing grep-verification chain (§1.8 + 8 merged PRs). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): THESIS/ROADMAP citations to section anchors (codex non-blocking) codex review on PR #2358 sha c27502c: non-blocking — "THESIS citation says line 298 for the Pure Bootstrap quote, but the quote is at THESIS.md:282 in the current repo; fix the line pointer when touching the authority block." Verified: THESIS:298 IS the Pure Bootstrap quote on origin/main (codex may be reading a stale snapshot). But per `feedback_section_anchors_over_line_numbers`, line numbers drift — should switch to section/symbol anchors regardless. Fix: parent-doc citations switched from line-numbers to structural references: - THESIS.md "Pure Bootstrap to Zero" framing + verbatim quote (section anchor; line-anchor-immune) - ROADMAP.md T-PB-A lane row (`pb_hand_rust_at_shim_floor` predicate named explicitly) + T-PB-B lane row (`pb_rust_tests_outside_residual_zero` predicate named explicitly) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluator freeze —
src/v3/compiler/src/test_runner.rs(R3 Bundle 4b)N/A — not touched.
Summary
Lands
method_template_projection_emit_shim_retirement_coherenceas §1.8 ledger row #97 (Q-V2-Retirement-Boundary-Matrix / Gunbc #1982).src/v3/compiler/tests/integration/method_template_projection_emit_shim_coherence_test.rs—src/v2/stage0/directory present ⇒pb_method_template_projection_dag_emit.rs+[[bin]]emit_method_template_projectioninsrc/v3/compiler/Cargo.toml+src/bin/emit_method_template_projection.rsmust remain (autobins = false— the manifest[[bin]]row is the Cargo target fact per codex review). v2 absent ⇒ all three must be removed.docs/r3-program-plan.md§1.5 / §1.7 / §1.8 (96→97 gates; 93→94 load-bearing) + G6 footnote +docs/r3-structure.mdAcceptance (R2-Grounding-Rust emit-shim boundary).EXPECTED_HAND_AUTHORED_TESTcensus path.Not in this PR: actual deletion of
pb_method_template_projection_dag_emit— still required whilesrc/v2/stands (blocked on PB workspace removal).Follow-up (codex BLOCKING):
d8a8cf0— gate #97 now rats the[[bin]]entry, not only the bin source path.Per-PR dissolution gate (required for new/expanded hand-Rust under
v3/)SG-0 net-shrink discipline
SG-0 hand-path delta: +1
SG-0 pairing: (c) structural deferral + named Grounding dispatch Gunbc #1982
Per-PR debt-paydown receipt
v2_directory_deleted).Test plan
cargo test -p v3-compiler method_template_projection_emit_shim_retirement_coherencecargo test -p v3-compiler sg0_v3_hand_authored_censuscargo fmt --all --checkcargo clippy -p v3-compiler --all-targets -- -D warnings