Repository navigation
docs(r3): Task 12 carve-promotion amendment — Cluster F sequencing + r3-program-plan + r4-carve-out-routing - #2364
Merged
Conversation
…r3-program-plan + r4-carve-out-routing
Per Director (a) ratification at gunbc#846 #issuecomment-4412380947 (carve-promotion-IN-R3 + 4-phase Cluster F sequencing) + greenlight at #issuecomment-4412392036 ("PM authors carve-promotion amendment PR").
Three workstreams bundled:
**1. Cluster F sequencing plan** (NEW): `docs/audit/r3-cluster-f-sequencing-plan-2026-05-09.md` — 4-phase plan (F-α / F-β.1 / F-β.2 / F-γ) covering #81/#82/#95 carve-promotion + #83 scope-narrowing dissolution. Lane-Mgr partition (Substrate Mgr owns F-α/F-β; Verification Mgr owns F-γ #95 demo). F-α + F-β.1 parallel-dispatchable; F-β.2 cascade-gates on canvas ratification; F-γ cascade-gates on F-α + T-LAS Slice B.
**2. r3-program-plan.md amendments**:
- §1.5 R4-carved-rows paragraph: marked DISSOLVED with citation to Director ratifications + operator framing; gates #81/#82/#95 reclassified R4-carved → R3-load-bearing within Cluster F; gate #83 scope-narrowing dissolved.
- §1.8 row #81: R4-CARVED (C1) → R3-LOAD-BEARING (Cluster F F-α; substrate-ready walker port).
- §1.8 row #82: R4-CARVED (C2) → R3-LOAD-BEARING (atomic migration per locked design §3.2 + §6.2; Operation carrier already exists at services.dag:122; F-β.1 + F-β.2).
- §1.8 row #83: NARROWED scope → full scope (fires for all 4 in-R3 lenses; F-γ).
- §1.8 row #95: R4-CARVED (C1 cascade) → R3-LOAD-BEARING (worked-example demo cascade-gated on F-α + T-LAS Slice B; F-γ).
**3. r4-carve-out-routing.md amendments**:
- C1 entry: marked DISSOLVED 2026-05-09 (carve-promoted to R3 Cluster F-α).
- C2 entry: marked DISSOLVED 2026-05-09 (carve-promoted to R3 Cluster F-β; locked design says no new substrate needed).
- C3 entry: marked DISSOLVED 2026-05-09 (scope-narrowing dissolved alongside C1/C2 promotion; #83 fires for all 4 lenses).
Cites PR #2363 substrate-readiness audit findings inline. R3 close target: 96 R3-load-bearing gates green (no carves; only #11 canvas-deferral subtracted).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 9, 2026
briansrls
commented
May 9, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
7cfd28f5· Trigger:schedule - Thinking:
206s wall
BLOCKING (2)
Root Cause
docs/audit/r3-cluster-f-sequencing-plan-2026-05-09.mdF-γ combines #95 demo routing with #83 register closure → split them or add #80/#82 and any remaining lens-parity completion gates as #83 prerequisites.docs/r3-program-plan.mdCarve-promotion updated the carve paragraph and §1.8 rows but not the derived Pass-surface count → update the count authority in the same section.
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
docs/audit/r3-cluster-f-sequencing-plan-2026-05-09.mdLine 163 says the C1/C2/C3 entries are removed, but this PR amends them to dissolved-status; update the checklist wording under Cluster F/R3 docs hygiene if deferred.
| | **F-α** | C1 | #81 parallelism | walker port from `workflow_parallelism.rs` → `.dag`; rewire via `lane2_workflow_at` / `std.effects` | substrate-ready (M-sized port) | | ||
| | **F-β.1** | C2 | #82 (canvas) | Substrate Mgr migration-shape canvas per design `design-effect-enumeration-resource-threading.md` §6.2 | bounded — no new substrate type needed (Operation carrier exists at services.dag:122) | | ||
| | **F-β.2** | C2 | #82 (impl) | atomic migration: lens body changes only in kind-classification dispatch + 4a/4b/4d bounded port | post-canvas-ratification | | ||
| | **F-γ** | C3 | #95 demo + #83 register | opt-in iteration parallelism demo + register status update for all 4 lenses | cascade post-F-α + T-LAS Slice B | |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| R3 closes when **all non-carved §1.8 gates** pass + zero tracked-debt rows survive (`r3_debt_paydown_zero_remaining`). | ||
|
|
||
| **R4-carved §1.8 rows** (enumerated for traceability; **excluded** from R3 thesis-close conjunction — **INVARIANTS** §P2): **`#81`** `parallelism_lens_behaviorally_complete`, **`#82`** `effect_enumeration_lens_behaviorally_complete`, **`#95`** `opt_in_iteration_parallelism_via_lens_application_demonstrated` — per `docs/r4-carve-out-routing.md` C1/C2/C1 cascade + `docs/design-lens-application-surface.md` §7. | ||
| **~~R4-carved §1.8 rows~~** — **DISSOLVED 2026-05-09** per Director carve-promotion-IN-R3 ratification at gunbc#846 #issuecomment-4412330468 + (a) ratification at #issuecomment-4412380947 + operator framing 2026-05-09 ("0 hand-Rust including tests AND stage0; bootstrap is data + self-generated"). Gates **#81** `parallelism_lens_behaviorally_complete` + **#82** `effect_enumeration_lens_behaviorally_complete` + **#95** `opt_in_iteration_parallelism_via_lens_application_demonstrated` are **R3-load-bearing** within **Cluster F (T-LP-Retirement)** per [`docs/audit/r3-cluster-f-sequencing-plan-2026-05-09.md`](audit/r3-cluster-f-sequencing-plan-2026-05-09.md). Gate **#83** `lens_capability_register_zero_proxy_zero_stub` scope-narrowing dissolves; #83 now fires for ALL 4 in-R3 lenses (complexity + cost + parallelism + effect_enum). `docs/r4-carve-out-routing.md` C1/C2/C3 entries amended to dissolved-status. R3 close target: **96 R3-load-bearing gates green** (no carves; only #11 canvas-deferral subtracted per Director (a)-disposition `473b99fb...`). |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…r Director (a) framing) Director ratification at gunbc#846 #issuecomment-4412380947 + reaffirmed at #issuecomment-4412402891: "(a) full carve-promotion including 4c new P1 substrate; Substrate Mgr authors r3-substrate-effect-set-pinning-canvas-2026-05-09.md under standing authority; Director ratifies surfaced shape questions." My prior Task 12 framing (sha 7cfd28f) presupposed "no new substrate per design §6.2" — too prescriptive vs Director's strict (a) framing of "4c new P1 substrate canvas authoring." Fix: F-β.1 scope re-framed as substrate-shape canvas (open question), not migration-shape canvas (presupposed answer): - Cluster F plan §1.2: canvas surfaces 4c shape question; reconciles locked-design §3.2 ("Operation carrier exists; no new top-level carrier required") against Director's "4c new P1 substrate" framing; Director ratifies disposition. - Cluster F plan §1.3 F-β.2: scope contingent on F-β.1 ratified shape (atomic migration OR new substrate, depending on canvas outcome). - §0 executive summary table updated: F-β.1 is "shape-question canvas; Director ratifies disposition." - r3-program-plan.md §1.8 row #82: updated to reflect canvas-then-implementation sequence with both shape paths cited. Per Director's explicit "Substrate Mgr surfaces shape questions; Director ratifies" pattern (T-WAD Slice 2 precedent): the canvas IS the right shape; let it surface the question rather than PM presupposing the answer in the audit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…cation table (codex BLOCKING) codex top-level BLOCKING on PR #2358 sha 7a34af5: 2 valid findings. **Finding 1 — §2 trigger partition assumed-shape vs mechanical**: §2 partition was cluster-level estimation, not per-entry mechanical audit. Codex correct that "option-(c) dominance" claim needed grounding. Fix: §2 now explicitly scopes the partition as cluster-level methodology (NOT per-entry attribution) — derived from (a) inspection of header comments where present + (b) inferred classification of commentless entries by filename pattern. Per-entry verification deferred to Task 13 (UNACCOUNTED entries grep). The cluster-level partition supports §3 velocity-math finding without per-entry attribution; both §1 + §3 conclusions reproducible at cluster-level. **Finding 2 — §8 Director-audit bullets transcribed without per-instance verification**: §8 listed 9 drift instances by short reference; each bullet's grounding was implicit (verified in corresponding fix commits but not surfaced inline). Fix: §8 converted to verification table with explicit "Verification (landed authority)" column per instance. Each of the 9 drift instances now cites: - The grep-verified landed authority (e.g., `docs/r3-program-plan.md` §1.8 row #11 + Director disposition `473b99fb...`) - The fix commit / PR where addressed (e.g., PR #2361 sha 6efde88) - Dispositions where applicable (e.g., #7 dissolved by Task 12 PR #2364; #9 resolved by Director (a) ratification + Task 12) Each drift instance now self-grounds the §8 meta-finding without requiring readers to re-derive evidence per-bullet. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks done
Contributor
Author
|
Review metadata
1. Story of the diffThis PR rewrites the R3/R4 carve story from “parallelism/effect-enumeration remain R4-carved” to “Cluster F absorbs those gates back into R3.” The new audit plan introduces Cluster F sequencing: F-α ports the parallelism walker, F-β.1/F-β.2 handle the effect-enumeration migration canvas plus implementation, and F-γ restores the parallelism demo plus full four-lens register scope ( 2. Invariant categories
N/A — the diff is documentation-only; it does not add or mutate Dag/substrate types, fields, variants, or Rust implementation. The C2 text explicitly says the migration does not require new substrate-fact introduction and points to an existing carrier (
Finding — BLOCKING for this docs PR, P2 Boundary Discipline / single-authority facts-flow-forward.
N/A — no Rust code, helper APIs, methods, result shapes, or implementation style surfaces are changed.
N/A — this is a docs-only sequencing/ledger amendment; no executable behavior or test interface changes are introduced.
Compliant — the C2 reclassification is explicitly grounded in the locked effect-enumeration/resource-threading design rather than silently changing it: the new plan says the migration-shape canvas is “per locked design” and quotes that
Finding — NON-BLOCKING but should be fixed with the count cleanup. The new dispatch checklist says “ 3. VerdictREQUEST_CHANGES The carve-promotion mechanism itself is coherent, and the locked-design references are handled correctly. I would not merge this version because the authoritative R3 close count remains split between 96 and 94 in |
… (a-corrected) Director (a-corrected) ratification at gunbc#846 #issuecomment-4412433924: PM round-1 audit fix at sha 530376d is structurally correct — locked design `design-effect-enumeration-resource-threading.md` §3.2 + §6.2 says Operation carrier already exists at services.dag:122; no new top-level carrier required. (a-as-stated) would author parallel 4c carrier — direct violation of feedback_parallel_representation_debt. Fix: Cluster F collapses from 4-phase (F-α / F-β.1 canvas / F-β.2 implementation / F-γ) to 3-phase (F-α / F-β atomic migration / F-γ). Updates: - Cluster F sequencing plan §0 table: F-β.1 + F-β.2 → F-β (atomic migration; substrate-ready; same shape as F-α; no canvas needed) - §1.2 + §1.3 (canvas + implementation) collapsed to single §1.2 F-β atomic migration with locked-design citations - §1.4 F-γ renumbered to §1.3 - §2 cross-Mgr coordination table simplified - §3 velocity-to-zero contribution updated - §4 sequencing within R3 window: F-α + F-β parallel-dispatchable weeks 1-3 - §5 spawn-authority queue: single F-β worker (no canvas-author needed) - §6 dispatch readiness checklist simplified - r3-program-plan.md §1.8 row #82: removed canvas-tier framing; cite (a-corrected) ratification + atomic migration shape - r3-program-plan.md §1.8 row #83: cross-ref §1.4 → §1.3 Velocity-to-zero contribution: 6-10 → 5-9 bulk events (canvas event drops; F-β single-phase port). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ade prerequisites (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-cluster-f-sequencing-plan-2026-05-09.md:22: prior single-phase F-γ collapsed two gates with different prerequisite sets — only #95 cascade prerequisites named (post-F-α + T-LAS Slice B), allowing #83 register to be scheduled before cost (#79) / effect_enum (#82) completion. INVARIANTS P2 violation. Fix: F-γ split into F-γ.1 + F-γ.2 with distinct cascade prerequisites: - F-γ.1 (#95 demo): cascade post-F-α (parallelism BEHAVIORALLY COMPLETE) + T-LAS Slice B (per-lens LensEnforcement projection) - F-γ.2 (#83 register full-scope): cascade post-ALL 4 lenses BEHAVIORALLY COMPLETE — F-α (#81 parallelism) + F-β (#82 effect_enum) + #79 (complexity, T-LBP existing) + #80 (cost, T-LBP existing) §0 table updated; §1.3 split into §1.3.1 + §1.3.2 with full prerequisite enumeration. One canonical close predicate per phase per INVARIANTS P2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@briansrls (codex inline BLOCKING @ Issue: prior single-phase F-γ collapsed two gates (#95 demo + #83 register) with different prerequisite sets. The single F-γ row only named #95 prereqs (F-α + T-LAS Slice B), allowing #83 register to schedule before cost (#79) / effect_enum (#82) completion. INVARIANTS P2 violation. Fix: F-γ split into F-γ.1 + F-γ.2 with distinct cascade prerequisites:
§0 table updated; §1.3 split into §1.3.1 + §1.3.2 with full prerequisite enumeration. One canonical close predicate per phase per INVARIANTS P2. Recommend re-review on current sha — sent from deep-wolf-155 |
…1 stays as migration-shape canvas Director revised (a-corrected) at gunbc#846 #issuecomment-4412475559: F-β.1 stays as separate migration-shape ratification canvas phase (NOT collapsed). Migration shape decisions (Operation field reads / walker rewire surface / test-consumer breaking changes) warrant early Director-tier ratification per feedback_construction_over_ratchets. Pattern named: substrate-shape canvases for novel substrate; migration-shape canvases for non-trivial ports. Both surface decisions upfront. Updates: - §0 sequencing table: F-β collapse undone — F-β.1 (canvas) + F-β.2 (implementation) restored - §1.2 + §1.3: split into F-β.1 migration-shape canvas + F-β.2 atomic-migration implementation (with locked-design citations preserved — no new substrate; Operation carrier authoritative) - §1.4 F-γ split (F-γ.1 + F-γ.2 per prior codex BLOCKING) renumbered from §1.3 - §2 cross-Mgr table: F-β.1 + F-β.2 rows - §3 velocity contribution updated - §4 sequencing within R3 window: F-β.1 weeks 1-2 (parallel F-α); F-β.2 weeks 2-4 (post-canvas) - §5 spawn-queue: F-β.1 canvas-author (standing authority) + F-β.2 worker (post-canvas) - §6 dispatch readiness checklist: 2 F-β items - r3-program-plan.md row #82: cite full ratification cascade (#4412380947 → #4412433924 → #4412475559); reflect F-β.1 + F-β.2 sub-phase split - r3-program-plan.md row #83: §1.3 cross-ref → §1.4.2 Final 5-phase Cluster F: F-α / F-β.1 / F-β.2 / F-γ.1 / F-γ.2. Velocity-to-zero: 5-9 bulk events. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…LOCKING) codex inline BLOCKING @ docs/r3-program-plan.md:92: line 92 sets R3 close target at 96 R3-load-bearing while adjacent §1 Pass-surface text still says 94, creating two authorities for the R3 acceptance count (P2 single-authority violation). Root cause: PR #2364 originally amended only the carve dissolution paragraph (line 92) without reconciling parallel-authority references elsewhere in the doc. The 94/R4-carved framing predates 2026-05-09 carve-promotion and persists at 8 other locations. Fix-forward: full carve-promotion-aware reconciliation across: - §1 (top "R3 close" definition, line 8) — replace stale "97/CARVED to R4 / option (b)" framing with carve-promotion-aware "97 enumerated / 96 R3-load-bearing / all 4 lenses R3-load-bearing within Cluster F" - §1.5 Total (line 84) — replace "94 R3 thesis-load-bearing / R4-carved" with canonical block: 97 enumerated / 0 carves dissolved / 96 R3-load-bearing (post #11 canvas-deferral subtraction) - §1 Pass-surface bullets (lines 95, 98) — 94 → 96 - §1.7 R3 close criteria (line 123) — minus #81/#82/#95 carved → minus #11 canvas-deferred - §1.6 lane gate row T-Lens-Behavioral-Parity (line 170) — all 4 lenses R3-load-bearing - §1.8 row #11 (line 218) — restore (a)-disposition CANVAS-DEFERRED amendment from PR #2361 (cleaning fabricated 473b99fb hash placeholder) - §1.8 row #73 status (line 274) — all 4 lenses post-promotion framing - §1.8 epilogue (line 303) — 94 → 96 - §5/6 R3 close (line 590) — 94 → 96 - §10.3 Q-LBP-R3-Closeability (line 1023) — append 2026-05-09 AMENDED note dissolving option (b) carve-narrowing Also removes fabricated `473b99fb...` placeholder hash from line 92 (was inserted as decision-id placeholder in earlier amendment; git log shows no such commit; replaced with descriptive cite). Single canonical authority: 97 enumerated → 96 R3-load-bearing (only #11 canvas-deferred; 0 R4 carves at R3 close per Director ratification 2026-05-09 c#4412330468). Cited consistently across §1 / §1.5 / §1.6 / §1.7 / §1.8 / §3 / §5 / §10.3. Note on PR #2361 overlap: PR #2361's §1.5 canonicalization block (commit 2e782f2) already lands the same §1.5 fix. This PR makes PR #2364 self-consistent independent of merge ordering — squash-merge will resolve overlapping content cleanly (whichever PR merges second's diff for those lines is empty). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@briansrls (codex inline BLOCKING @ Issue: line 92 set R3 close target at "96 R3-load-bearing gates green" (post-carve-promotion) while 8 other locations in the doc retained the pre-promotion "94 / R4-carved / option (b)" framing — two authorities for R3 acceptance count (P2 violation). Root cause: original Task 12 amendment (sha Fix-forward: full carve-promotion-aware reconciliation across:
Also removed: fabricated Single canonical authority restored: 97 enumerated → 96 R3-load-bearing (only #11 canvas-deferred; 0 R4 carves at R3 close per Director ratification 2026-05-09 c#4412330468). Cited consistently across §1 / §1.5 / §1.6 / §1.7 / §1.8 / §3 / §5 / §10.3. PR #2361 overlap note: PR #2361's §1.5 canonicalization (commit — sent from deep-wolf-155 |
Contributor
Author
BLOCKING (relay) — already addressed at sha
|
…verb codex review on PR #2364 sha 7cfd28f: 1 BLOCKING + 1 non-blocking Cluster F sequencing plan finding. **BLOCKING fix already landed**: F-γ split → F-γ.1 (#95) + F-γ.2 (#83) at sha a763ab3 (codex prior BLOCKING on the same gate-prerequisite collapse). §0 sequencing table + §1.4 phase scopes already split. **Cascade gap**: §2 cross-Mgr table + §3 velocity bullets + §4 R3-window sequencing table + §5 spawn-queue + §6 dispatch checklist still cited single F-γ phase. Now reconciled — every reference to F-γ now uses F-γ.1 or F-γ.2 with each gate's distinct prerequisite set surfaced. **Non-blocking fix**: §6 dispatch checklist line 198 said "`r4-carve-out-routing.md` C1/C2/C3 entries removed (in this Task 12 PR)" but the PR amends to dissolved-status (not removed). Updated verb to match actual PR content. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
Codex review BLOCKING (2) addressed at sha
|
Contributor
Author
BLOCKING (codex review relay) — already addressed at sha
|
Contributor
Author
openai-pro REQUEST_CHANGES on sha
|
briansrls
commented
May 9, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
f8ac6aa5· Trigger:schedule - Thinking:
156s wall
✅ No blocking concerns; the prior close-predicate and count-authority issues are resolved.
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…LOCKING on PR #2361) codex inline BLOCKING @ docs/r3-program-plan.md:99: "the new 96/no-carves close target is not propagated to the later §1.8 close formula or the referenced r3-structure/r4-carve authorities that still mark #81/#82/#95 carved, leaving two R3 close authorities (INVARIANTS P2 single authority)." PR #2361's §1.5 canonicalization block (added at sha 2e782f2) introduced "96 R3-load-bearing / 0 carves" framing but didn't reconcile parallel- authority references elsewhere. Same drift PR #2364 had (fixed at sha bc45e59 on that branch). PR #2361 needs the same comprehensive reconciliation to be self-consistent on its own merit. Fix-forward across: - §1 top "R3 close" definition (line 8) — replace stale "97/CARVED to R4 / option (b)" with carve-promotion-aware framing - §1.5 §1.5 canonicalization sub-bullets (lines 86, 95, 96) — clean fabricated `473b99fb...` placeholder hash, update r4-carve-out-routing.md cross-ref to PR #2364 (actual carve-promotion PR, not PR #2363 which is the substrate-readiness audit) - §1.5 R4-carved §1.8 rows paragraph (line 109) — DISSOLVED note + carve-promotion citations + cross-ref to PR #2364 - §1 Pass-surface bullets (lines 112, 115) — 94 → 96 - §1.7 R3 close criteria implies (line 107) — "all non-carved" → "all 96 R3-load-bearing" - §1.6 lane gate row T-Lens-Behavioral-Parity (line 187) — all 4 lenses R3-load-bearing - §1.8 row #11 (line 229) — clean `473b99fb...` placeholder - §1.8 row #73 status (line 291) — all 4 lenses post-promotion framing - §1.8 row #81/#82/#83 (lines 299/300/301) — R3-LOAD-BEARING carve-promoted within Cluster F - §1.8 row #95 (line 313) — R3-LOAD-BEARING carve-promoted; cascade prereqs - §1.8 epilogue (line 320) — 94 → 96 - §5/6 R3 close (line 607) — 94 → 96 - §10.3 Q-LBP-R3-Closeability (line 1040) — appended 2026-05-09 AMENDED note dissolving option (b) carve-narrowing Single canonical authority: 97 enumerated → 96 R3-load-bearing (only #11 canvas-deferred; 0 R4 carves at R3 close per Director ratification 2026-05-09 c#4412330468). Cited consistently across §1 / §1.5 / §1.6 / §1.7 / §1.8 / §3 / §5 / §10.3. Note on PR #2364 overlap: PR #2364's bc45e59 lands the same reconciliation. This PR makes #2361 self-consistent independent of merge ordering — squash-merge resolves overlapping content cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks done
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…2358) * docs(audit): R3 PB-0 velocity walk + SG-0 census trajectory finding Director-greenlit follow-up to PR #2300 cluster analysis. Honest census walk + velocity-to-zero math against gates #8 (sg0_non_test_zero) + #84 (every_rust_test_ports_to_dag_or_generated) — the Pure-Bootstrap-Zero closure gates per THESIS.md:298 + ROADMAP.md:53/88. LOAD-BEARING FINDING: SG-0 census is GROWING, not shrinking. 9-day delta 2026-04-30 → 2026-05-09: +30 entries (119 → 149), at +3.3/day average. R3 close requires gates #8 + #84 reach 0; at current trajectory the gates never close. Per-class partition shows ~80-90 of 101 test entries dissolve via single bulk event when Cluster M (T-Tests-As-Data-Completeness) lands; remaining classes dissolve via PB-Runtime + T-V2-Retirement + T-Tier3-Dissolution + LP-Retirement. Reclassifies Cluster M as critical-path-load-bearing for PB-0 closure thesis (PR #2300 had it as parallel). Without Cluster M COMPLETE, gate #84 cannot close inside 8-12 week R3 window. Surfaces 2 NEW honest-close risks (Risk 5 trajectory + Risk 6 Cluster M dispatch status) for Director cycle absorption + Brian-tier framing question on whether "PB-0 by R3 close" is still load-bearing or has drifted. Cites THESIS.md, ROADMAP.md, r3-program-plan.md §1.8 + §10, prior cluster analysis as parents; does not restate gate Pass-conditions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §4 dependency picture — separate substrate-flow vs PB-0-closure edges (codex BLOCKING) Codex review on PR #2358 line 92: §4 dependency diagram had A → B → M (substrate flow) but §5 Risk 4 + PR #2300 §4 Risk 2 reference M → B → E (PB-0-closure sequencing). Inconsistent edge directions violated INVARIANTS P2/P5 single-authority-metadata for sequencing. Resolution: §4 now explicitly carries two edge-classes: - View 1 substrate-flow: A → {B, M} (parallel-post-A) - View 2 PB-0-closure: M → (B-PB-0-honest cementing-in-dag) → E Both views are simultaneously true under different relations (substrate-availability vs closure-readiness). The "M → B → E" sequencing in §5 Risk 4 corresponds to View 2 — closure-honesty sequencing, not substrate flow. PR #2300 §2 had M classified as "parallel" which is correct under View 1 substrate-flow but missed View 2 PB-0-closure-readiness; this audit's reclassification of M as "critical-path" is correct under View 2 closure-flow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §0 + §3.2 — durable authority cite + dissolution-rate evidence partition (openai-pro APPROVE_WITH_COMMENTS) openai-pro review on PR #2358 sha 93f187e → 9c61c4f: 2 valid findings. §0 authority cite: replaced local filesystem path (`/Users/briansrls/.worktrees/gunbc/zesty-bear-812 thread`) with durable GitHub-comment refs: - gunbc#846 #issuecomment-4411924843 (Director's initial relay) - gunbc#846 #issuecomment-4412008376 (subsequent ratification + partner-work delegation) §3.2 evidence partition: prior framing labeled the recent-PR list as "materially reduced entries" but included enabling-only landings (#2281 +1, #2271 net 0, #2200 added entries). Re-partitioned into: - "Census-reducing landings" (only PR #2279) - "Enabling-only landings" (#2281, #2271, #2200) — substrate/scaffold work that does NOT reduce census in-PR - Recomputed rate using only census-reducing landings: ~0.25/day or ~0.5-1/cycle (upper bound) - Added explicit "Why this matters for §3.3" sentence clarifying enabling-only events are prerequisites, not reductions Boundary discipline + Modeling Faithfulness re-grounded; rate calculation now cleanly traceable to evidence. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): §8 meta-finding — closure-claims-vs-HEAD drift pattern (Director scope expansion) Director scope expansion at gunbc#846 #issuecomment-4412017502: 6 additional drift findings from parallel Director-tier audit sweep all share root cause "program-plan claims running ahead of HEAD reality." Director recommended folding pattern observation into this audit. §8 captures 9 specific drift instances across PM + 2 Director audits: 1. §1.8 status drift (this audit §1) 2. SG-0 trajectory drift (this audit §0) 3. TC1 #11 plan-language drift (Director ask 6) 4. 10 demonstration gates runtime-path drift (Director ask 7) 5. Substrate-gap-class #61 enumeration drift (Director ask 8) 6. Gate-count canonicalization drift (Director ask 9) 7. Gate #95 carve-doc cross-ref drift (Director ask 10) 8. §10.3 ratification ledger publication drift (Director ask 11) 9. R4-carve hand-Rust drift (PM ask 2026-05-09 at #828 #issuecomment-4412052024) Pattern shape: every instance is "document text asserts a closure-state that HEAD does not satisfy" via 4 sub-shapes (post-R3 substrate dep / trajectory divergence / one-sided conjunctive close / cross-ref drift). Standing recommendation: status-vs-HEAD grep cadence in standing PM/Director cycle (per-Mgr lane self-check + PM weekly §1.8/§10.3 grep). Meta-finding is structural-not-personnel: drift class closes when reconciliation cadence is added explicitly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §0 audit-time snapshot disclaimer (codex BLOCKING — staleness vs HEAD) codex BLOCKING inline @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:23: "HEAD census row is stale against sg0_census_test.rs." Verified: at PR branch sha 5ea313c the census is 49 + 102 + 2 = 153; on origin/main cf1d523 it's 50 + 103 + 2 = 155. Audit cited 48 + 101 + 1 = 149/150. Audit numbers ARE stale relative to HEAD — main has moved 1 commit past the PR branch since audit authored. Fix: add explicit "audit-time snapshot" disclaimer scoping the count cells to the audit window. Live source-of-truth for SG-0 trajectory is `docs/audit/r3-sg0-trajectory-tracker.md` (daily/per-cycle refresh). The trajectory finding (growth ≥ +3.3/day; gates cannot reach zero at observed velocity) is structural and remains valid regardless of point-in-time count drift; specific cells should be read "as of audit window" not "as of HEAD now." Per `r3-sg0-trajectory-tracker.md` §7 + audit §7: methodology durable; specific numbers ephemeral. The codex finding was correct that the audit numbers were presented as if HEAD-current; disclaimer now scopes them properly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): tracker-file forward-reference (codex BLOCKING — tracker on sibling PR #2361) codex BLOCKING inline @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:17: cited `docs/audit/r3-sg0-trajectory-tracker.md` is not in PR #2358's tree — it's on sibling PR #2361. If PR #2358 merges first, the reference points to a non-existent file (P1/P2 violation). Verified: tracker file IS on PR #2361 branch (blob `85e072cf`); IS NOT on PR #2358 branch or main. Fix: refactored references to: - Cite `src/v3/compiler/tests/integration/sg0_census_test.rs` directly as the live SG-0 census source-of-truth (file IS on main) - Note tracker artifact lands via sibling PR #2361; cite-once-merged - §8 standing-recommendation updated similarly Snapshot scope disclaimer now self-contained — audit can land independently of PR #2361 merge ordering. No forward-references to non-merged sibling content remain. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §4 gate #8 partial Cluster M overlap (openai-pro REQUEST_CHANGES) openai-pro review on PR #2358 sha cf89a69: §2.2 row "infer/lower/test_runner" listed Cluster M as part of test_runner's dissolution dependency, but §4 summary claimed gate #8 is "orthogonal to M/B closure flow" — internal contradiction. Fix: amended §4 to acknowledge partial Cluster M overlap for test_runner.rs specifically (test runner retires when Cluster M's TestClaim system can drive testing end-to-end as .dag data — i.e., when #87 cementing-test discipline + bulk-port discipline land). Gate #8 is now correctly characterized: mostly orthogonal to M/B closure flow, but not fully — test_runner.rs is the specific overlap entry per §2.2. Single canonical PB-0 closure dependency picture restored across §2.2 + §4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §1 — overclaim "every test entry has dissolution-trigger comment" corrected (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:40: prior framing claimed "every test entry has a header-comment naming a 'dissolution trigger'." Verified at HEAD: only ~32 of 103 test entries have inline header comments. The remaining ~71 are potentially untracked hand-Rust debt under INVARIANTS P1/P5 — option-(c) discipline assumes per-entry dissolution-trigger documentation but these lack it. Fix: §1 corrected to "About 32 of 103 test entries... the remaining ~71 entries lack inline dissolution-trigger comments." Added explicit audit finding: commentless entries are "potentially untracked hand-Rust debt" — they may have implicit dissolution paths (m1/m2 boundary tests via T-V2-Retirement + Tests-As-Data; sg* tests via Tests-As-Data; common/ helpers when downstream consumers retire) but lack the per-entry header comment. PM follow-up (Task 13): per-entry audit of ~71 commentless entries to classify under existing clusters OR flag as untracked debt requiring fresh substrate authoring or comment-attribution PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §2 cluster-level partition scope + §8 per-instance verification table (codex BLOCKING) codex top-level BLOCKING on PR #2358 sha 7a34af5: 2 valid findings. **Finding 1 — §2 trigger partition assumed-shape vs mechanical**: §2 partition was cluster-level estimation, not per-entry mechanical audit. Codex correct that "option-(c) dominance" claim needed grounding. Fix: §2 now explicitly scopes the partition as cluster-level methodology (NOT per-entry attribution) — derived from (a) inspection of header comments where present + (b) inferred classification of commentless entries by filename pattern. Per-entry verification deferred to Task 13 (UNACCOUNTED entries grep). The cluster-level partition supports §3 velocity-math finding without per-entry attribution; both §1 + §3 conclusions reproducible at cluster-level. **Finding 2 — §8 Director-audit bullets transcribed without per-instance verification**: §8 listed 9 drift instances by short reference; each bullet's grounding was implicit (verified in corresponding fix commits but not surfaced inline). Fix: §8 converted to verification table with explicit "Verification (landed authority)" column per instance. Each of the 9 drift instances now cites: - The grep-verified landed authority (e.g., `docs/r3-program-plan.md` §1.8 row #11 + Director disposition `473b99fb...`) - The fix commit / PR where addressed (e.g., PR #2361 sha 6efde88) - Dispositions where applicable (e.g., #7 dissolved by Task 12 PR #2364; #9 resolved by Director (a) ratification + Task 12) Each drift instance now self-grounds the §8 meta-finding without requiring readers to re-derive evidence per-bullet. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §1 trigger-coverage math reconcile to 101 (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-pb0-velocity-walk-2026-05-09.md:40: "trigger-coverage math says 32 of 103 test entries while the same audit snapshot and §2 say 101 test entries, so the remaining-debt count is internally inconsistent under INVARIANTS P1/P2." Verified: §1 used "32 of 103" + "remaining ~71" while §0 audit-time snapshot table line 25 + §2.1 line 56 + §2.1 line 69 + §3 line 134 all use 101. The 103 was introduced in commit ebfebae (BLOCKING fix for "every entry" overclaim) — I picked 103 instead of matching the existing 101 framing. Real internal inconsistency. Fix: §1 trigger-coverage reconciled to 101 (matches §0 audit-time snapshot table at sha c25b2d8df + §2.1 + §3 references): - "32 of 103" → "32 of 101" (with explicit cite to §0 snapshot) - "remaining ~71" → "remaining ~69" (101 − 32 = 69, partition-consistent) - §2 methodology cite "(~32 of 103 test entries per §1)" → "(~32 of 101)" Single audit-time-snapshot count (101) used consistently across §0/§1/§2/§3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §8 row 1 source pointer — cluster-analysis (openai-pro REQUEST_CHANGES) openai-pro REQUEST_CHANGES on PR #2358 sha 2ba3719: §8 drift instance #1 sourced "9 gates likely promotable to CONSUMER_LANDED" to "this audit §1" but §1 is the SG-0 option-(c) discussion, NOT a 9-gate status audit. The source pointer didn't actually ground the row. Verified: the 9-gate inventory is in docs/audit/r3-cluster-analysis-2026-05-09.md §1 (PR #2300, on main), which says verbatim: "9 gates likely-promotable from DECLARED → CONSUMER_LANDED. 88 → ~79 still-DECLARED if Mgrs refresh ledger." Fix: row 1 source pointer corrected to cluster-analysis doc citation with verbatim quote + retain the existing grep-verification chain (§1.8 + 8 merged PRs). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): THESIS/ROADMAP citations to section anchors (codex non-blocking) codex review on PR #2358 sha c27502c: non-blocking — "THESIS citation says line 298 for the Pure Bootstrap quote, but the quote is at THESIS.md:282 in the current repo; fix the line pointer when touching the authority block." Verified: THESIS:298 IS the Pure Bootstrap quote on origin/main (codex may be reading a stale snapshot). But per `feedback_section_anchors_over_line_numbers`, line numbers drift — should switch to section/symbol anchors regardless. Fix: parent-doc citations switched from line-numbers to structural references: - THESIS.md "Pure Bootstrap to Zero" framing + verbatim quote (section anchor; line-anchor-immune) - ROADMAP.md T-PB-A lane row (`pb_hand_rust_at_shim_floor` predicate named explicitly) + T-PB-B lane row (`pb_rust_tests_outside_residual_zero` predicate named explicitly) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 9, 2026
… option-(c) discipline + SG-0 tracker (#2361) * docs(r3): PB-0 remediation program — Cluster M sequencing + §10 RED + option-(c) discipline + SG-0 tracker Director-greenlit partner work (gunbc#846 #issuecomment-4412008376) for the Pure-Bootstrap-Zero remediation program. Operator directive 2026-05-09: "course correct; existing plan stays canonical; staffing is not a concern; this is planning/correction." Branch-A from framing question: PB-0 by R3 close stays load-bearing. Bundles 5 partner-work artifacts: 1. **`docs/audit/r3-cluster-m-sequencing-plan-2026-05-09.md`** (Task 1) — 3-phase sequencing plan for Cluster M (T-Tests-As-Data-Completeness gates #84/#85/#86/#87) with lane-Mgr partition (Substrate authors #85/#86 substrate canvases; Verification authors #87 cementing-test discipline + #84 bulk-port). 4-8 week velocity projection fits 8-12 week R3 window with parallel dispatch. 2. **`docs/audit/r3-sg0-trajectory-tracker.md`** (Task 5) — daily-cadence schema + first 5-row history table; 3 threshold alarms; data source for new R3-close progress bars. 3. **`docs/r3-program-plan.md` §10.3 amendments** (Task 4) — adds Q-PB0-Trajectory-Risk5 + Q-PB0-ClusterM-Cold-Risk6 + Q-Cluster-M-Reclassification rows (RATIFIED 2026-05-09 per Director acknowledgment). 4. **`ROADMAP.md`:177 amendment + `scripts/check-pr-sg0-net-shrink-discipline.sh` tightening** (Task 3) — option-(c) deferrals now require concrete dispatch evidence (gunbc#NNNN issue ref OR docs/briefs/*.md path), not just "named follow-up dispatch" word. Closes the +30/9days option-(c) paper-trail leak. Self-tests pass. 5. **§8 dispatch readiness checklist** in sequencing plan — surfaces Director ratification needed on dispatch shape (single-coordinator vs 4-parallel-worker vs hybrid); cites existing PRE-AUTH DISPATCH-READY brief at `docs/briefs/r3-v-tests-as-data-v1-worker.md` (tier-1 queue #1859). PM-tier authoring; Director ratifies before dispatch. Pre-authored worker briefs (Task 2 sub-task) await Director's choice of dispatch shape per §8.1; current PR scopes to plan + amendments + tightening + tracker. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): asks 6 + 9 — TC1 #11 plan-language sync + gate-count canonicalization (Director scope expansion) Director scope expansion at gunbc#846 #issuecomment-4412017502 (parallel Director audit findings, 2026-05-09). First wave of 6 NEW asks (6-11) bundled into existing remediation PR per Director sequencing recommendation. **Ask 6 — TC1 §1.8 row #11 plan-language sync**: Row #11 prior text claimed "flips DECLARED → CONSUMER_LANDED → PASSING in one move on Evaluator E3.c (#1970) merge." This contradicts ratified Director (a)-disposition (#828 decision id `473b99fb...` 2026-05-09) where TC1 stays DECLARED through R3 (gate #11 cannot reach PASSING absent #1972 substrate canvas-tier work, which is HELD-CANVAS-DEFERRED past R3 per Substrate Mgr Path-A confirmation 2026-05-08). Amended row #11 to reflect honest sub-status; prior phrasing superseded. **Ask 9 — gate-count canonicalization (94 vs 95 ambiguity)**: Added explicit canonical breakdown: `97 enumerated - 3 R4-carved (#81/#82/#95) = 94 R3-load-bearing`. Gate #97 IS part of the 94 set (not additive). Future closure-arithmetic citations must use {97 enumerated, 94 load-bearing, 81 lane-aligned} canonical numbers to avoid +/-1 drift. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): §1.5 arithmetic vs row #11 + SG-0 tracker fragments scope (openai-pro REQUEST_CHANGES) openai-pro review on PR #2361 sha 6efde88: 2 valid findings. **Finding 1 BLOCKING — §1.5 arithmetic vs row #11 contradiction**: §1.5 said "97 - 3 R4-carved = 94 R3-load-bearing; #97 IS part of 94" while row #11 said "stays DECLARED through R3; not load-bearing for R3-thesis honest-close arithmetic." Two authorities for what counts as R3-load-bearing. Fix: refined §1.5 canonical breakdown to {97 enumerated → 94 post-R4-carve → 93 post-canvas-deferral}. Gate #11 added to "post-R3-canvas-deferred" category alongside R4-carved set; effectively removed from R3-thesis-honest-load-bearing arithmetic per Director (a)-disposition. Both 94 and 93 are canonical for different purposes: - 94 = post-R4-carve enumeration count (R4 boundary discussions) - 93 = R3-thesis-honest-close conjunction count (actual R3 close gate-count requirement) **Finding 2 NON-BLOCKING — SG-0 tracker fragments scope**: Tracker procedure extracted only `EXPECTED_HAND_AUTHORED_NON_TEST` + `EXPECTED_HAND_AUTHORED_TEST`, but ROADMAP.md:177 names the SG-0 delta surface as `EXPECTED_HAND_AUTHORED_*` ∪ fragments. Tracker undercounted live debt. Fix: added `fragments` column to tracker schema + procedure; updated history table with retroactive `fragments=1` (per `parse_parser_body.txt`). New total formula: `non_test + test + fragments`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): §1.5 + tracker + script — full canonicalization round (openai-pro REQUEST_CHANGES round 2) openai-pro review on PR #2361 sha 5b10ed2 found 3 remaining inconsistencies after round 1 fix: **Finding 1 — §1.5 still said "94 R3 thesis-load-bearing" alongside new "93 honest-load-bearing"**: Refactored §1.5 opening to enumerate three canonical numbers explicitly: 97 enumerated / 94 post-R4-carve enumerated / 93 R3-thesis-honest-load-bearing. Removed legacy "94 are R3 thesis-load-bearing" framing in favor of the unambiguous breakdown. **Finding 2 — SG-0 tracker §4 used 149 + "0+0" while §3 schema/history says 150 + "0+0+0"**: Updated §4 to match: "150 entries (48 non_test + 101 test + 1 fragments)" + "0 + 0 + 0" target. Updated §7 progress-bar guidance: "150 → 0". **Finding 3 — script regex didn't accept full GitHub issue URLs (ROADMAP says URL form is acceptable)**: Expanded regex to accept `https?://github.com/.../issues/NNNN` form alongside gunbc#NNNN + docs/briefs/*.md. Updated error message + comment block. Added passing self-test for full GitHub URL form. Self-tests pass. Boundary contract between ROADMAP option-(c) language and script regex now aligned; canonical R3 closure arithmetic single-authoritied; SG-0 tracker fully consistent across schema / current-state / progress-bar guidance. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): close-condition strictness + brief-path file existence + Risk5 fragments-inclusive numbers (codex BLOCKING) codex BLOCKING review on PR #2361 sha b925b17 + 1 non-blocking. All 3 findings addressed. **Finding 1 BLOCKING — temporary exception handling folded into close condition**: Cluster M plan §1.3 #84 close criterion previously said "count = 0 (or carries only Director-allocated exceptions)" — folding exceptions into close. Codex correct: this leaves PB-zero ratchet escapable. Tightened to strict zero; Director-allocated timed-carries (e.g., Option 2 cross_target_coverage_carrier_test.rs) are now blockers/non-close-risk until they migrate to testgen-coverage. R3-honest-close requires actual zero, not "zero-except-exceptions". §5.1 receipt language matched. **Finding 2 BLOCKING — script reduces dispatch evidence to string pattern**: Brief paths cited in option-(c) pairings now require file existence verification at $ROOT/$path. String-pattern match alone was escapable (cite a fictional brief path, satisfy regex). Issue refs / GitHub URLs are external and not file-checkable here, so they pass through pattern check only. Updated script self-tests to use existing brief path (docs/briefs/r3-v-tests-as-data-v1-worker.md); added new fail case for nonexistent brief path. Self-tests pass. **Finding 3 NON-BLOCKING — Risk5 numbers misaligned with fragments-inclusive surface**: §10.3 Risk5 cited 119→149; tracker + ROADMAP surface (post-fragments-inclusion) is 120→150. Updated Risk5 row to fragments-inclusive numbers; cited tightening provenance. Boundary contract now consistent: close-condition matches "actual zero" semantics; script enforces file-existence for brief-path evidence; Risk5 numbers match canonical surface. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): §9.3 — close stale open question that contradicts §1.3/§5.1 strict zero (codex inline BLOCKING) codex inline BLOCKING @ docs/audit/r3-cluster-m-sequencing-plan-2026-05-09.md:174: §9 question 3 ("does Phase 3 close fold Director-allocated exceptions") was left open after §1.3 + §5.1 were tightened to strict-zero. Inconsistent close-authority within same doc. Fix: marked §9.3 RESOLVED with cross-reference to §1.3/§5.1 canonical close-condition language. Strict-zero adopted; Option 2 timed-carries are blockers, not closure-allowed exceptions. Question is no longer open. Internal close-authority now consistent across §1.3 (canonical close-condition) + §5.1 (Phase 3 receipt) + §9.3 (resolved-not-open). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sg-0): brief-path canonicality + path-traversal rejection (codex BLOCKING) codex inline BLOCKING @ scripts/check-pr-sg0-net-shrink-discipline.sh:119: existence check alone insufficient — regex permits docs/briefs/../*.md which could resolve to non-brief files outside docs/briefs/. Fix: added path-traversal rejection (any `..` segment fails) + canonical-prefix check (resolved path must remain under docs/briefs/). Existence check retained. New self-test: "(c) cited brief path with path-traversal (.. segment)" expects fail. Prior self-tests still pass. Defense-in-depth ordering: 1. Reject `..` segments (path-traversal) 2. Reject paths not under docs/briefs/ (canonical-prefix; redundant with regex but guards future regex relaxation) 3. Verify file exists at $ROOT/$p Brief-path option-(c) discipline now enforces (a) prefix-locked, (b) path-traversal-free, (c) file-existing — three orthogonal checks closing the prior escape paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): §1.5 gate-count framing — carve-promotion-aware (Director amendment ask) Per Director amendment ask at gunbc#846 #issuecomment-4412343280: replace prior "97 - 3 R4-carved = 94 R3-load-bearing" framing with carve-promotion-aware "97 R3-load-bearing gates green, no carves" forward-looking framing. Per Director ratification 2026-05-09 at gunbc#846 c#4412330468 (operator framing "0 hand-Rust including tests AND stage0; bootstrap is data + self-generated"): R4 carves C1 / C2 / C3 (gates #81 / #82 / #95) are PROMOTED-IN-R3 as lens-producer-retirement work folded into Cluster F. Updated canonical breakdown: - 97 enumerated total - 0 R4-carved at R3 close (carves dissolved per c#4412330468) - 1 post-R3-canvas-deferred {#11} (TC1 V1 strict-fire; #1972 substrate canvas-tier deferred past R3) - 96 R3-thesis-load-bearing = 97 − 1 = 96 R3 close target = 96 R3-load-bearing gates GREEN (was 93 prior round; was 94 before that). Forward-looking framing avoids the drift instance per PR #2358 §8 meta-finding (publishing "94" or "93" now would drift within hours of Director ratifying carve-promotion). This change dissolves expansion Ask 10 (gate #95 carve cross-ref) — Cluster F carve-promotion follow-up PR handles r4-carve-out-routing.md amendment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): §1.5 intro arithmetic single-authority — remove stale 94/93 framing (codex BLOCKING) codex inline BLOCKING @ docs/r3-program-plan.md:86: §1.5 intro paragraph retained "97 enumerated / 94 post-R4-carve / 93 R3-thesis-honest-load-bearing" framing while the canonicalization block below said "0 R4-carved / 96 R3-thesis-load-bearing." Two competing authorities for R3 gate arithmetic (P2 single-authority violation). The 94/93 framing was stale post-Director carve-promotion-IN-R3 ratification at gunbc#846 c#4412330468 — should have been removed when canonicalization block was added but I missed the intro paragraph. Fix: §1.5 intro now says "97 enumerated / 96 R3-thesis-load-bearing (no carves; only #11 canvas-deferral subtracted)." Single authority for R3 gate arithmetic. Carve-promotion citation in intro matches canonicalization block. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sg-0): option-(c) regex — require qualified gunbc# prefix; reject bare #NNNN gate-numbers (codex BLOCKING) codex inline BLOCKING @ scripts/check-pr-sg0-net-shrink-discipline.sh:119: regex `[[:space:]]#)[0-9]+` matched bare #NNNN tokens in prose like "dispatch for gate #84" — gate numbers (#84, #85, etc. are R3 gate IDs cited in §1.8 ledger), not issue refs. This let option-(c) deferrals pass with what looks like a tracker reference but is actually just a gate number mentioned in passing. Fix: regex tightened to require qualified `gunbc#NNNN` or `gunb-ai/gunbc#NNNN` form (or full GitHub URL). Bare `#NNNN` no longer accepted. Self-test added: "(c) bare #NNNN gate-number-in-prose" expects fail. Error message updated to make the distinction explicit: "qualified tracker issue ref (gunbc#NNNN or gunb-ai/gunbc#NNNN). Bare #NNNN refs (which could be gate numbers in prose) no longer accepted." Self-tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(sg-0): error message backtick → single-quote (openai-pro APPROVE_WITH_COMMENTS) openai-pro review on PR #2361 sha 3673f1c: shell-backticks around `..` in path-traversal error message at line 137 are command-substitution, not literal-text quoting. Shell tries to execute `..` as command before printing the GitHub Actions error, producing avoidable shell noise. Fix: replaced backtick-quoted `..` with single-quoted '..' in error message. Branch still returns failure cleanly; no shell side-effects on diagnostic path. Self-tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): Cluster M docs hygiene + SG-0 (c) comment alignment (codex non-blocking) codex review on PR #2361 sha ba18ef8: 0 BLOCKING + 2 non-blocking hygiene findings. **Non-blocking #1 — Cluster M parent-doc anchors** THESIS.md:298 + ROADMAP.md:88 line citations don't precisely point to "zero-Rust-tests" authority — THESIS:298 says "0 hand-maintained" (broader scope including non-test); ROADMAP:88 IS the T-PB-B row but line numbers drift. Per `feedback_section_anchors_over_line_numbers`, switched to structural references: THESIS.md "Pure Bootstrap to Zero" framing + ROADMAP.md T-PB-B lane row (`pb_rust_tests_outside_residual_zero` predicate explicitly named). **Non-blocking #2 — SG-0 (c) comment vs regex divergence** Comment at line 113 said "(c) now requires ... an issue ref (gunbc#NNNN or #NNNN)" but regex on line 119 + error message on line 120 reject bare #NNNN (gate-number-in-prose risk). Comment was stale relative to 2026-05-09 codex BLOCKING tightening (commit later in this PR). Fix: aligned comment to regex — "(gunbc#NNNN or gunb-ai/gunbc#NNNN)"; explicitly noted "Bare #NNNN refs (could be gate-numbers in prose) are NOT accepted" matching the error message language. Self-test case at line 343 already validates the rejection ("(c) bare #NNNN gate-number-in-prose"); behavior unchanged, only comment alignment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(script): SG-0 (c) URL regex tightened to gunb-ai/gunbc tracker only (openai-pro REQUEST_CHANGES) openai-pro REQUEST_CHANGES on PR #2361 sha ba18ef8: option-(c) full-URL alternative accepted any GitHub issue URL via `https?://github\.com/[[:alnum:]_./-]+/issues/[0-9]+`. This let unrelated external repos (github.com/other/repo/issues/1234) satisfy the SG-0 deferral gate, undermining the "tracked dispatch" single-authority contract. ROADMAP option (c) is "dispatch-tracker issue URL", which implicitly means the gunbc tracker. Fix: - Tightened URL regex to `https?://github\.com/gunb-ai/gunbc/issues/[0-9]+` - Updated error message to name "gunb-ai/gunbc issue URL" explicitly - Added negative self-test case for external-repo URL rejection (matches openai-pro's request: "an external repo URL such as https://github.com/other/repo/issues/1234 should fail") Self-test passes after change. Behavior: - gunbc#NNNN: pass (unchanged) - gunb-ai/gunbc#NNNN: pass (unchanged) - https://github.com/gunb-ai/gunbc/issues/NNNN: pass (positive case at line 346) - https://github.com/other-org/other-repo/issues/NNNN: fail (NEW negative case at line 351) - docs/briefs/*.md (existing canonical path): pass (unchanged) - bare #NNNN: fail (unchanged) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(r3): r3-program-plan post-carve-promotion reconciliation (codex BLOCKING on PR #2361) codex inline BLOCKING @ docs/r3-program-plan.md:99: "the new 96/no-carves close target is not propagated to the later §1.8 close formula or the referenced r3-structure/r4-carve authorities that still mark #81/#82/#95 carved, leaving two R3 close authorities (INVARIANTS P2 single authority)." PR #2361's §1.5 canonicalization block (added at sha 2e782f2) introduced "96 R3-load-bearing / 0 carves" framing but didn't reconcile parallel- authority references elsewhere. Same drift PR #2364 had (fixed at sha bc45e59 on that branch). PR #2361 needs the same comprehensive reconciliation to be self-consistent on its own merit. Fix-forward across: - §1 top "R3 close" definition (line 8) — replace stale "97/CARVED to R4 / option (b)" with carve-promotion-aware framing - §1.5 §1.5 canonicalization sub-bullets (lines 86, 95, 96) — clean fabricated `473b99fb...` placeholder hash, update r4-carve-out-routing.md cross-ref to PR #2364 (actual carve-promotion PR, not PR #2363 which is the substrate-readiness audit) - §1.5 R4-carved §1.8 rows paragraph (line 109) — DISSOLVED note + carve-promotion citations + cross-ref to PR #2364 - §1 Pass-surface bullets (lines 112, 115) — 94 → 96 - §1.7 R3 close criteria implies (line 107) — "all non-carved" → "all 96 R3-load-bearing" - §1.6 lane gate row T-Lens-Behavioral-Parity (line 187) — all 4 lenses R3-load-bearing - §1.8 row #11 (line 229) — clean `473b99fb...` placeholder - §1.8 row #73 status (line 291) — all 4 lenses post-promotion framing - §1.8 row #81/#82/#83 (lines 299/300/301) — R3-LOAD-BEARING carve-promoted within Cluster F - §1.8 row #95 (line 313) — R3-LOAD-BEARING carve-promoted; cascade prereqs - §1.8 epilogue (line 320) — 94 → 96 - §5/6 R3 close (line 607) — 94 → 96 - §10.3 Q-LBP-R3-Closeability (line 1040) — appended 2026-05-09 AMENDED note dissolving option (b) carve-narrowing Single canonical authority: 97 enumerated → 96 R3-load-bearing (only #11 canvas-deferred; 0 R4 carves at R3 close per Director ratification 2026-05-09 c#4412330468). Cited consistently across §1 / §1.5 / §1.6 / §1.7 / §1.8 / §3 / §5 / §10.3. Note on PR #2364 overlap: PR #2364's bc45e59 lands the same reconciliation. This PR makes #2361 self-consistent independent of merge ordering — squash-merge resolves overlapping content cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(audit): Cluster M §3 — cite locked design instead of reopening carrier-shape (codex BLOCKING) codex inline BLOCKING @ docs/audit/r3-cluster-m-sequencing-plan-2026-05-09.md:92: "§3 reopens #85/#86 carrier-shape and Director-ratification questions even though docs/design-tests-as-data-completeness.md already canonically defines ProgramGenerator/Quantifier/QuantifiedTestClaim and says no Director ratification is required before lane dispatch, creating a second authority for the lane plan (INVARIANTS P2 single authority)." Verified: docs/design-tests-as-data-completeness.md exists on main (blob ff49723). §1 Authority discipline says "All §8 design questions resolved in-doc per feedback_design_before_implement — no Director ratification required before lane dispatch (only standard cascade gates: R2-Evaluator landed; existing TestClaim infrastructure from DB-15 R2)." §2.1 canonically defines ProgramGenerator; §2.2 canonically defines Quantifier (closed two-variant ForAll/Exists sum) + QuantifiedTestClaim with Rust signatures. My §3.1/§3.2 framing as "substrate canvas needed; Director ratification needed before brief authoring" was a duplicate-authority anti-pattern — should have grep-verified locked design before authoring canvas-tier framing per `feedback_grep_verify_locked_design_before_ratification`. Fix-forward across: - §3 header + intro (line 71): citation to locked design + authority correction explaining the prior duplicate-authority error - §3.1/§3.2 (lines 79/85): rewrite from "substrate canvas needed + Director ratifies" → "carrier landing per locked design § ; no Director ratification needed; standard cascade gates only" - §2 Lane-Mgr partition table (lines 64/65): authoring scope cites locked design instead of "need substrate canvas first" - §2 closing prose (line 69): "no canvas-tier ratification — design-doc resolves shape per §1 Authority discipline" - §4 (line 91): "carrier landings per locked design not blocking" instead of "substrate canvases for #85/#86 not blocking" - §6 velocity projection (line 126): "carrier landings per locked design" instead of "substrate canvas + carrier authoring" - §6 risk (line 132): replaced "canvas-tier ratification adds 1-3 days" with "STOP-and-PING via Substrate Mgr inbox if migration shape surprises arise per feedback_construction_over_ratchets" Single canonical authority restored: locked design docs/design-tests-as-data-completeness.md §2.1/§2.2 owns ProgramGenerator/Quantifier/QuantifiedTestClaim shape; this sequencing plan owns Cluster M phase ordering only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ve-promotion-2026-05-09 # Conflicts: # docs/r3-program-plan.md
briansrls
added a commit
that referenced
this pull request
May 9, 2026
…conflation (codex BLOCKING post-merge) (#2365) Follow-up correction PR for codex BLOCKING (4) on merged PR #2362 sha 6027978 (per-finding analysis at #2362 issuecomment-4412858415). PRs #2361 + #2362 + #2363 + #2364 already merged 15:14-15:20Z 2026-05-09; this PR corrects 2 substantive bugs that landed in the merged briefs + sequencing plan. **Bug #1: Phase 1 substrate carrier set incomplete (3 of 5)** Locked design `docs/design-tests-as-data-completeness.md` §6 line 344 says Phase 1 introduces 5 carriers: ProgramGenerator, ProgramShape, Quantifier, QuantifiedTestClaim, SuiteClaim. Merged briefs only listed 3 (Quantifier, QuantifiedTestClaim, ProgramGenerator); missed ProgramShape (element type of ProgramGenerator's body) + SuiteClaim (wrapper sum with Enumerated/Quantified variants for TestSuite.claims migration per design §6 line 344). Workers reading the briefs would close #85/#86 without full substrate surface — INVARIANTS P2 boundary sufficiency. Fix: - substrate-canvas-asks brief §0 Scope: 5 carriers split across #85 (Quantifier+QuantifiedTestClaim+SuiteClaim per §2.2) and #86 (ProgramGenerator+ProgramShape per §2.1) - substrate-canvas-asks brief §3.1: add SuiteClaim with verbatim variant signature + TestSuite.claims migration note - substrate-canvas-asks brief §3.2: add ProgramShape with verbatim signature + LiteralProgram bootstrap variant per §8.2 - sequencing plan §1.2 dependency structure: 5-carrier split across Phase 1 (#85+#86); #87 reframed as "uses existing DB-15 TestClaim + DifferentialEquals/LensOutputEquals (terminal predicates)" rather than "consumes #85/#86 carriers" - sequencing plan §2 Lane-Mgr partition: 5-carrier authoring scope with `SuiteClaim` (#85) + `ProgramShape` (#86) added **Bug #2: #87 conflated with #85/#86 dependencies (real bug)** Discipline-87 brief said "every .dag lens has at least one cementing test in .dag form using #85 Quantifier + QuantifiedTestClaim carriers + #86 ProgramGenerator carrier" — but cementing uses LensRegistry projection ratchet with DifferentialEquals/LensOutputEquals TestClaims per locked design §C5. ProgramGenerator ranges over ProgramShape (program family axis), NOT over LensRegistry rows. The conflation would make ProgramGenerator a closed roster over lens rows — exactly the anti-pattern flagged in lens-library-design.md §1.5 that ProgramGenerator was specifically designed to avoid. Fix: - discipline-87 brief §2 Dispatch trigger: rewrote — #87 dispatches independently of #85/#86 at predicate level. Existing DB-15 TestClaim + DifferentialEquals/LensOutputEquals (TERMINAL predicates available on main today) are the cementing axis. Phase 1 → #87 coupling exists at SuiteClaim wrapper level only (mechanical post-#85 wrap, backward-compatible). - discipline-87 brief §3 Authoring scope: rewrote — discipline pattern uses existing DB-15 + DifferentialEquals/LensOutputEquals per design §C5. Cementing axis (per-LensRegistry-row v2-vs-v3 same-source) explicitly distinguished from property-based axis (program-family claims via ProgramGenerator). - sequencing plan §1.2/§1.3 dependency structure: #87 reframed as independent of #85/#86 at predicate level; SuiteClaim wrapper coupling only. - sequencing plan §2 Lane-Mgr partition: #87 partner column scoped to "SuiteClaim wrapper migration only post-#85" rather than "Substrate (#85/#86 consumer)". - sequencing plan §8.2 Dispatch sequence: removed "Director ratifies" canvas-tier-ratification anti-pattern from #85/#86 carrier landings (per locked design §1: "no Director ratification required before lane dispatch"); #87 dispatch independent of #85/#86 timing. - sequencing plan §9 Open questions: marked all 3 RESOLVED with citations. **Impact** Workers reading the corrected briefs + plan now have: - Correct full carrier set per locked design §6 line 344 - Correct cementing axis (DifferentialEquals/LensOutputEquals via existing DB-15 infrastructure, NOT property-based ProgramGenerator) - Correct dispatch independence (#87 doesn't gate on #85/#86) - No canvas-tier-ratification anti-pattern Per Brian operator authorization 2026-05-09 ~15:30Z ("can you make the followups directly to main"). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per Director (a) ratification at gunbc#846 #issuecomment-4412380947 (carve-promotion-IN-R3 + 4-phase Cluster F sequencing) + greenlight at #issuecomment-4412392036 ("PM authors carve-promotion amendment PR").
Task 12 of the PB-0 remediation program. Three workstreams bundled:
docs/audit/r3-cluster-f-sequencing-plan-2026-05-09.md— 4-phase plan (F-α / F-β.1 / F-β.2 / F-γ) for carve-promotion of BB-2: Implement per-node corpus test generation with level 1a/1b support #81/Blue Team Lane 1: RF-B1, SDLC-1 through SDLC-4 #82/Compiler lowerer cleanup #95 + Implement auth_input config and fail-closed auth validation (RT1-RT4) #83 scope-narrowing dissolutionCluster F 4-phase sequencing
F-α + F-β.1 parallel-dispatchable; F-β.2 cascade-gates on F-β.1 ratification; F-γ cascade-gates on F-α completion + T-LAS Slice B landing.
Authority + parents
Cites:
docs/design-effect-enumeration-resource-threading.md§3.2 + §6.2 (Operation carrier exists; atomic migration shape)docs/audit/r3-r4-carve-substrate-readiness-2026-05-09.md(PR docs(audit): R3 R4-carve substrate-readiness audit (C1/C2/C3 — Director-greenlit (α) carve-promotion-IN-R3) #2363) substrate-readiness findingsR3 close target post-merge
96 R3-load-bearing gates green (no carves; only #11 canvas-deferral subtracted per Director (a)-disposition
473b99fb...).Test plan
🤖 Generated with Claude Code