Skip to content

docs(briefs): cite gate IDs #84-#87 + #74 on T-Tests-As-Data unified brief (closes #1966) - #2149

Merged
briansrls merged 2 commits into
mainfrom
session/silent-hawk-397
May 7, 2026
Merged

briansrls merged 2 commits into
mainfrom
session/silent-hawk-397

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Summary

Routes #1966 ("Verification V4 Tests-As-Data unified worker brief") to the existing unified brief at docs/briefs/r3-v-tests-as-data-v1-worker.md (authored via #1893, V4 status PRE-AUTH DISPATCH-READY).

That brief already consolidates exactly the four lane gates the issue names — every_rust_test_ports_to_dag_or_generated, forall_exists_quantifier_substrate_landed, program_generator_carrier_landed, lens_cementing_test_discipline_complete — plus the tests_as_data_demonstration sibling. The gate IDs (#84–#87 + #74) were not yet assigned in r3-program-plan.md when the brief landed; they were DECLARED 2026-05-06. This PR threads the IDs into the gate table so the brief cites them by row number.

Authority audit receipt (brief-authoring-checklist.md compliance)

  1. Substrate exists? N/A — patch only updates an existing brief; introduces no carrier.
  2. Existing brief? YES — docs/briefs/r3-v-tests-as-data-v1-worker.md (V4, landed via R3 Verification #1893) covers identical scope (all four gates + demonstration sibling, lane T-Tests-As-Data-Completeness, dependencies on R2-Evaluator + ProgramGenerator substrate). Per checklist Q2 + INVARIANTS P2 (single authority), authoring a second parallel unified brief was rejected — this PR routes via citation patch instead.
  3. Design-doc recommendation matches? Lane authority docs/r3-structure.md §39, §148–151, §188 + design lock docs/design-tests-as-data-completeness.md already cited in existing brief; no reframe needed.
  4. Citations live? Verified: r3-program-plan.md rows 74, 84, 85, 86, 87 at HEAD (grep -n lines 273, 283–286).
  5. Carrier dissolves the bridge? N/A — patch is citation-threading; no carrier shape introduced.

Test plan

Closes #1966.

🤖 Generated with Claude Code

…brief

Maps the four DECLARED 2026-05-06 gate ledger rows + #74 demonstration sibling
to the existing unified brief authored at #1893. Routes #1966 (which asked for
a unified worker brief consolidating these gates) to existing authority per
brief-authoring-checklist.md Q2 + INVARIANTS P2 (single authority) — not a
second parallel brief.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: cursor / composer-2
  • Commit: 519ffb08 · Trigger: schedule
  • Comparison: origin/main @ d6cba0c9 ... review/pr-2149-519ffb08 @ 519ffb08
  • Thinking: 31s wall

Findings: None. The diff only updates docs/briefs/r3-v-tests-as-data-v1-worker.md: gate IDs #84–#87 and #74 match the # column and gate IDs in docs/r3-program-plan.md (e.g. rows 273–286 for 74 and 84–87). Nothing here touches compiler substrate, tests, or Rust style, so INVARIANTS.md, docs/modeling-discipline.md, CODING.md, and TESTING.md do not supply applicable violations for this change.

Verdict: APPROVE — Small, accurate doc cross-link to the program plan; no rubric issues in the diff.

Exploratory (optional): The new sentence cites §"Gate ledger", but docs/r3-program-plan.md does not use that exact heading (the table lives under §1.8 Canonical R3 Closure-Authority Ledger). Consider aligning the quoted section name with the plan for faster search/navigation; not a blocking inconsistency with the ledger rows themselves.

Cursor review on PR #2149 (composer-2) flagged that "§Gate ledger" doesn't
match the actual heading in r3-program-plan.md. Updated to "§1.8 Canonical
R3 Closure-Authority Ledger" to match line 178 verbatim.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls
briansrls merged commit f70ba0c into main May 7, 2026

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 519ffb08 · Trigger: schedule
  • Thinking: 103s wall

Non-blocking — Strengths

  • docs/briefs/r3-v-tests-as-data-v1-worker.md The brief now cites the canonical closure-ledger IDs for rows #84-#87 and the demonstration sibling #74, matching the T-Tests-As-Data-Completeness gate names and roles.

✅ Docs-only citation alignment looks clean; no blocking concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verification V4 Tests-As-Data unified worker brief

1 participant