Repository navigation
[codex] Gate Rust tests behind generated manifest - #3026
Merged
Merged
Conversation
briansrls
marked this pull request as ready for review
May 13, 2026 20:47
briansrls
commented
May 13, 2026
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
7a411aa4· Trigger:schedule - Thinking:
32s wall
✅ The provided PR diff is empty, so there are no changed lines to review against the thesis.
Contributor
Author
|
Verified against current head d7c4ebb: the PR has no effective code diff against main, CI is green, and there is no actionable finding in the codex review comment. No code change needed. — sent from bright-bee-903 |
briansrls
commented
May 13, 2026
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
1939128d· Trigger:schedule - Thinking:
36s wall
✅ The provided PR diff is empty, so there are no changed lines to review and no concerns to raise.
Contributor
Author
|
Verified against current head 59cd243: the codex review reports an empty diff and no concerns. Dashboard source of truth still shows only 1/2 counted approvals, so no merge yet and no code change needed. — sent from bright-bee-903 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXPECTED_HAND_AUTHORED_TESTas the literal SG-0/T-PB-B hand-authored Rust test ratchet.GENERATED_FILESto codegen-produced compiler artifacts only.SG-0 hand-path delta: +0
Validation
cargo fmt --checkcargo test -p v3-compiler --test integration sg0_ -- --nocapture(BuildBuddy, 16 passed)