Skip to content

[codex] Gate Rust tests behind generated manifest - #3026

Merged
briansrls merged 19 commits into
mainfrom
session/bright-bee-903
May 13, 2026
Merged

briansrls merged 19 commits into
mainfrom
session/bright-bee-903

Conversation

@briansrls

@briansrls briansrls commented May 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Keeps EXPECTED_HAND_AUTHORED_TEST as the literal SG-0/T-PB-B hand-authored Rust test ratchet.
  • Restores GENERATED_FILES to codegen-produced compiler artifacts only.
  • Removes the earlier test-generated manifest and tautological byte snapshot check after review found they diluted the ratchet instead of proving generation.
  • Leaves the existing SG-0 migration audit and subratchets active so new or retired Rust test paths still trip CI.

SG-0 hand-path delta: +0

Validation

  • cargo fmt --check
  • cargo test -p v3-compiler --test integration sg0_ -- --nocapture (BuildBuddy, 16 passed)

@briansrls
briansrls marked this pull request as ready for review May 13, 2026 20:47

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 7a411aa4 · Trigger: schedule
  • Thinking: 32s wall

✅ The provided PR diff is empty, so there are no changed lines to review against the thesis.

@briansrls

Copy link
Copy Markdown
Contributor Author

Verified against current head d7c4ebb: the PR has no effective code diff against main, CI is green, and there is no actionable finding in the codex review comment. No code change needed. — sent from bright-bee-903

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 1939128d · Trigger: schedule
  • Thinking: 36s wall

✅ The provided PR diff is empty, so there are no changed lines to review and no concerns to raise.

@briansrls

Copy link
Copy Markdown
Contributor Author

Verified against current head 59cd243: the codex review reports an empty diff and no concerns. Dashboard source of truth still shows only 1/2 counted approvals, so no merge yet and no code change needed. — sent from bright-bee-903

@briansrls
briansrls merged commit c959d25 into main May 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant