Add a guide to Teleport+Spacelift#26031
Closed
ptgott wants to merge 384 commits intopaul.gottschling/25418-iac-sectionfrom
Closed
Add a guide to Teleport+Spacelift#26031ptgott wants to merge 384 commits intopaul.gottschling/25418-iac-sectionfrom
ptgott wants to merge 384 commits intopaul.gottschling/25418-iac-sectionfrom
Conversation
ptgott
force-pushed
the
paul.gottschling/25418-iac-section
branch
3 times, most recently
from
6ab4575 to
8b88f46
Compare
ptgott
force-pushed
the
paul.gottschling/25421-spacelift
branch
from
f777819 to
82cb650
Compare
ptgott
force-pushed
the
paul.gottschling/25418-iac-section
branch
from
38d031b to
38a0519
Compare
ptgott
force-pushed
the
paul.gottschling/25421-spacelift
branch
from
82cb650 to
03a2245
Compare
alexfornuto
reviewed
May 22, 2023
alexfornuto
approved these changes
May 31, 2023
Contributor
alexfornuto
left a comment
alexfornuto
left a comment
There was a problem hiding this comment.
LGTM, with the one pending discussion on the image which shouldn't be a blocker. Note that I reviewed for Copy and did not test.
ptgott
force-pushed
the
paul.gottschling/25418-iac-section
branch
from
1002ea5 to
6caf763
Compare
* fix: Observe accurate read latency duration * Use a consistent clock to observe metrics
* chore: Bump Buf to v1.21.0 * chore: Bump Go to 1.20.5 * Run `make dronegen` * Update devbox packages
Fixes a discrepancy in overwriting the environment value with the address observed for the Web UI for sessions not originating from the Web UI. All sessions will now use `tc.WebProxyAddr` as the default value and *only* update if an override is provided. `TestIntegrations/EnvironmentVars` was updated to ensure that the expected environment variables are present in both interactive and non-interactive sessions.
* Set "omitempty" in optional credential fields * Update generated protos * Use "" as the value for DEVICE_ATTESTATION_TYPE_UNSPECIFIED
* helm: add hostAliases support * docs: remove reference to a `custom` mode for agent
* Make devbox sandbox friendly, add devbox CI. The devbox is now sandbox friendly, and devbox CI has been added to ensure that any changes to Devbox are properly validated. * Install correct binary name for node protoc plugin. * Add in zlib to support LIBFIDO compilation.
* Update ADFS SSO guide * Update docs/pages/access-controls/sso/adfs.mdx * Update docs/pages/access-controls/sso/adfs.mdx Co-authored-by: Gus Luxton <gus@goteleport.com> * update link for new heading --------- Co-authored-by: Gus Luxton <gus@goteleport.com>
* Fixes the "Run as different user" window freezing The problem was that we were occasionally getting SCARD_IOCTL_GETSTATUSCHANGEW calls with infinite timeouts, which we would never return from because our status never changes. This is the correct behavior in the short run, but we were ignoring the meaning of SCARD_IOCTL_CANCEL, which tells such long-hanging calls to return with an SCARD_E_CANCELLED return value. This was causing the "Run as different user" window to freeze, because something internally was waiting around for an SCARD_E_CANCELLED that would never come. To fix this, now whenever we get an SCARD_IOCTL_GETSTATUSCHANGEW with an infinite timeout, we add to the corresponding context a DeviceControlResponse that wraps the necessary SCARD_E_CANCELLED return value. Later, when an SCARD_IOCTL_CANCEL is received for that context, we grab the DeviceControlResponse and return it. * removes unecessary PartialEq * Removes unnecessary Option * consolidate and improve Context.get error handling/message * change [#allow(dead_code)] to #[cfg(test)] * updates comment
* docs: Fix more installation commands on Windows * Add TLS 1.2 for Windows Server 2016
* docs: document label expressions This commit adds documentation for the label expressions feature described in RFD 116. * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * use v6 role Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * explain setting both <kind>_labels and <kind>_labels_expression --------- Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor.
* send progress update messages during agent thoughts * handle new output format * define json tags for serialized fields * use streaming api * fan streaming from model loop * fix streaming * stream progress updates * Update lib/assist/assist.go Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com> * remove useless mute * nits * Update lib/ai/model/agent.go Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com> * fix merge * fix misc * more misc fixes * what * what2 * weird eof errors? * Fix tests UI integration * Fix other tests * Linter fixes * Comment out token counting for assist streams to avoid race condition. * Fix more tests --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
…#28568) Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.100.1 to 1.102.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.100.1...service/ec2/v1.102.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update protos * create Posthog event for onboarding questionnaire submit
* Introduce the Access List object. The Access List object, which is the foundational object for access grants, has been introduced. Due to the size/complexity of this object, the implementation in api/types will come in a follow up. * Use duration, update comments. * Remove more requested membership bits, clarify what happens for user login state. * Add in duration type mapping to buf-gogo.gen.yaml. * Use an array instead of csv string. * Migrate from legacy to regular protobuf. * Make common resource header and metadata for use by non-legacy objects. * Use repeated trait list instead of map for traits, remove V1 suffix since things are in a v1 package anyway. * Move common bits into separate files. * Use separate packages for traits, resource header, and metadata.
Added the `t.Parallel()` function call in each test function to enable parallel test execution. This should reduce the overall time it takes to run all these tests by enabling them to run concurrently.
Co-authored-by: public-renovate-gha[bot] <135069952+public-renovate-gha[bot]@users.noreply.github.com>
* Add additional function * Update examples/dynamoathenamigration/migration.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> --------- Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
* log a warning when db/discovery service init is skipped but the service is enabled * dont register discovery service event mapping when init is skipped to avoid log spam waiting on DiscoveryReady event * fix godoc for DiscoveryReady event
* Add custom select comp type for react-select * use tsdoc comment style
Update the e reference to take in the Okta applications to group mapping fix.
…7924) * Add new endpoint, types, update types * Preserve user selected aws rds db * Rename DownloadScript to ManualDeploy - Remove duplicate test - Use discover context instead of passed in props - Rename util to common - Move hasMatchingLabels to common.tsx for re-use * Add another action button and pass autoFocus field * Implement auto deploy screen * Implement auto manual view toggler * Update db view config * Only allow back on user trait if user manually deployed agent * Add TODO comment * Address CRs * Fix lint/test * Address CRs * Revert back to original flow * Define type for service deploy method * Address CR and revert a change - aws field for database has to be empty if the result comes back empty. this field determines if the database is hosted by aws - add a clarifying comment * Remove optional rds field
* refactor: move database validation to grpc * test(local): update CRUD databases test
* Script to configure IAM for the DeployService
* use any instead of interface{}
* fix test typo
…8662) * lib/teleterm: Remove misleading error log after LocalAgent.GetKey * Remove unnecesarry check
Co-authored-by: public-renovate-gha[bot] <135069952+public-renovate-gha[bot]@users.noreply.github.com>
* docs: edits to the headless webauthn guide * lint fix * lint fix * Apply suggestions from code review Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * fix language --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
ptgott
force-pushed
the
paul.gottschling/25421-spacelift
branch
from
3ea9d80 to
77f1c07
Compare
ptgott
force-pushed
the
paul.gottschling/25421-spacelift
branch
from
77f1c07 to
ec0bef5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25421
This PR is based on top of #25418