Posthog event for onboarding questionnaire submit#28328
Merged
michellescripts merged 2 commits intomasterfrom Jul 3, 2023
Merged
Posthog event for onboarding questionnaire submit#28328michellescripts merged 2 commits intomasterfrom
michellescripts merged 2 commits intomasterfrom
Conversation
michellescripts
force-pushed
the
michelle/prehog-questionnaire-submit
branch
from
321e023 to
e05c2a7
Compare
espadolini
approved these changes
Jun 28, 2023
michellescripts
force-pushed
the
michelle/prehog-questionnaire-submit
branch
from
e05c2a7 to
3531fd0
Compare
ibeckermayer
approved these changes
Jun 28, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ravicious
michellescripts
force-pushed
the
michelle/prehog-questionnaire-submit
branch
4 times, most recently
from
bd6be7d to
39afba4
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
michellescripts
force-pushed
the
michelle/prehog-questionnaire-submit
branch
2 times, most recently
from
dca620d to
3af4b8c
Compare
michellescripts
force-pushed
the
michelle/prehog-questionnaire-submit
branch
from
3af4b8c to
b299e1f
Compare
michellescripts
force-pushed
the
michelle/prehog-questionnaire-submit
branch
from
b299e1f to
5c8a54c
Compare
michellescripts
added a commit
that referenced
this pull request
Jul 21, 2023
* update protos * create Posthog event for onboarding questionnaire submit
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Add onboarding questionnaire components (#27977) * Posthog event for onboarding questionnaire submit (#28328) * update protos * create Posthog event for onboarding questionnaire submit * set onboarding survey on user preferences (#28530) * Fix panic when fetching user preferences (#28751) * Fix panic when fetching user preferences Closes #28740 * Prevent overwriting mismatched types in user preferences * Add error handling to user preferences service * GCI imports * Refactor user preferences test and logic This commit updates the approach for comparing equality in user preferences test. It introduces the use of the "go-cmp" library which provides more flexibility in handling comparison of struct elements, thus helping to catch any unexpected changes that could be overlooked with the standard equality checking. We also revised the logic to handle default preferences by overwriting values for better efficiency and readability, also removing unnecessary checking and merging of values. * Add comments to overwriteValues method in userpreferences.go Added detailed comments to better explain the overwriteValues function in userpreferences.go file. The comments clarify how the function uses proto.Ranges to iterate over fields and only overwrite non-nil/empty fields. * Apply some magic to preferences test * Change the import to avoid go.mod changed and match our other imports * Onboarding changes to support e survey (#28981) * Display a survey during onboarding - Adds user context wrapper to the Welcome flow in order to update preferences - Sets selected resources on user preferences * imports & describes * named enums * remove onboard survey from oss - will be moved to /e - export shared types * refactor welcome - move new credential to welcome prop * refactor new credentails - container passes questionnaire to component * remove survey ls dispatch * pr feedback * Revert "pr feedback" This reverts commit 060f34fb60242856f233df6a1006c5192ea321fb. --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new Posthog event for onboarding questionnaire submisison
relies on https://github.com/gravitational/cloud/pull/5053
supports https://github.com/gravitational/cloud/issues/4802