Reduce login latency#28499
Merged
rosstimothy merged 1 commit intomasterfrom Jul 5, 2023
Merged
Conversation
rosstimothy
force-pushed
the
tross/tsh_login_latency
branch
5 times, most recently
from
2b54b3b to
bf4676a
Compare
Contributor
Author
|
Both login attempts below were performed from the same host to the same cloud tenant. Note: this branch also includes the login improvements added in #26968.
|
github-actions
Bot
added
size/md
tsh
rosstimothy
force-pushed
the
tross/tsh_login_latency
branch
from
bf4676a to
7e083c8
Compare
GavinFrazar
approved these changes
Jun 30, 2023
Contributor
GavinFrazar
left a comment
GavinFrazar
left a comment
There was a problem hiding this comment.
LGTM with a few nits. One more that I couldn't add since the lines weren't in the diff: should update TeleportClient.DeviceLogin and TeleportClient.Login godoc to remove mention of ActivateKey, since the former doesn't use it anymore and the latter should advise passing the key to ConnectToRootCluster.
ryanclark
approved these changes
Jul 5, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
rosstimothy
force-pushed
the
tross/tsh_login_latency
branch
from
37119ed to
4c77740
Compare
ravicious
pushed a commit
that referenced
this pull request
Jul 11, 2023
ravicious
pushed a commit
that referenced
this pull request
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the root cluster auth client during the login process to reduce latency.
Closes #26712.
Partially addresses #26712.