Ensure SSH_SESSION_WEBPROXY_ADDR is set for all sessions#27842
Merged
rosstimothy merged 1 commit intomasterfrom Jun 14, 2023
Merged
Ensure SSH_SESSION_WEBPROXY_ADDR is set for all sessions#27842rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
Fixes a discrepancy in overwriting the environment value with the address observed for the Web UI for sessions not originating from the Web UI. All sessions will now use `tc.WebProxyAddr` as the default value and *only* update if an override is provided. `TestIntegrations/EnvironmentVars` was updated to ensure that the expected environment variables are present in both interactive and non-interactive sessions.
github-actions
Bot
added
size/sm
tsh
Joerger
approved these changes
Jun 14, 2023
zmb3
approved these changes
Jun 14, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from tigrato
|
@rosstimothy See the table below for backport results.
|
This was referenced Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a discrepancy in overwriting the environment value with the address observed for the Web UI for sessions not originating from the Web UI. All sessions will now use
tc.WebProxyAddras the default value and only update if an override is provided.TestIntegrations/EnvironmentVarswas updated to ensure that the expected environment variables are present in both interactive and non-interactive sessions.