improve startup with empty db or discovery config#28552
Merged
GavinFrazar merged 1 commit intomasterfrom Jul 3, 2023
Merged
Conversation
camscale
approved these changes
Jul 3, 2023
* log a warning when db/discovery service init is skipped but the service is enabled * dont register discovery service event mapping when init is skipped to avoid log spam waiting on DiscoveryReady event * fix godoc for DiscoveryReady event
GavinFrazar
force-pushed
the
gavinfrazar/fix-empty-service-config-init
branch
from
d175c65 to
a66bea2
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@GavinFrazar See the table below for backport results.
|
This was referenced Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is tiny PR to fix log spamming when
teleportis started with a discovery serviceenabled: truebut which has an empty config. Prior to this PR, we added DiscoveryReady to the event mapping, but skipped initializing it, so the logs would just spam this message constantly:Instead, it will now print a warning that the enabled service was not initialized due to empty config, and skip adding it to the event mapping.