Introduce the Access List object.

[mdwn]

The Access List object, which is the foundational object for access grants, has been introduced. Due to the size/complexity of this object, the implementation in api/types will come in a follow up.

RFD-6E for context

[tigrato]

@mdwn do we have the reasoning behind this object anywhere?

It's quite difficult to review with no/little knowledge

[mdwn]

@mdwn do we have the reasoning behind this object anywhere?

It's quite difficult to review with no/little knowledge

Ahh sorry, I meant to add in a link to the RFD in the PR description. It's been added.

[zmb3]

Thanks for breaking this change into a separate PR and for the great comments!

[tigrato]

I know what I'm going to ask for next is a lot of work but since you're the one who launched the RFD Gogo must go, can we try not to add more uses of Gogo?
Will we support syncing these objects or will they only exist on the auth server?

[mdwn]

I know what I'm going to ask for next is a lot of work but since you're the one who launched the RFD Gogo must go, can we try not to add more uses of Gogo? Will we support syncing these objects or will they only exist on the auth server?

These objects will only exist on the auth server.

So, in theory I agree with you w/r/t not adding more uses of gogo. However, I want to make sure that the gogo RFD has a definitive, agreed upon plan before actually implementing that -- I would hate to implement what I think is a good way around this and then find ourselves having to migrate this one particular object to the outcome of the RFD. Until then, I would rather it be very obvious that this needs migration as well.

[mdwn]

Hrm:

# github.com/gravitational/teleport/api/types
api/types/types.pb.go:38448:29: m.Frequency.MarshalToSizedBuffer undefined (type *durationpb.Duration has no field or method MarshalToSizedBuffer)
api/types/types.pb.go:47515:19: m.Frequency.Size undefined (type *durationpb.Duration has no field or method Size)
api/types/types.pb.go:105087:26: m.Frequency.Unmarshal undefined (type *durationpb.Duration has no field or method Unmarshal)

Gogo maybe doesn't like Duration?

[tigrato]

Hrm:

# github.com/gravitational/teleport/api/types
api/types/types.pb.go:38448:29: m.Frequency.MarshalToSizedBuffer undefined (type *durationpb.Duration has no field or method MarshalToSizedBuffer)
api/types/types.pb.go:47515:19: m.Frequency.Size undefined (type *durationpb.Duration has no field or method Size)
api/types/types.pb.go:105087:26: m.Frequency.Unmarshal undefined (type *durationpb.Duration has no field or method Unmarshal)

Gogo maybe doesn't like Duration?

You need to add a directive to the protoc compiler.
I will check that today or tomorrow morning

[mdwn]

Okay, I've migrated this away from legacy into its own proto file. I had mistakenly thought that there would be an issue with the cache, but I was misremembering the reason that was a concern before.

[mdwn]

I've just added in a "common" package to create a header for this object -- I'm attempting to create this object in the "correct" way, so let me know if you have any objections and I can revert this commit.

[codingllama]

Drive-by per Mike's request.