Add custom component prop type for react-select#28596
Merged
Conversation
kimlisa
force-pushed
the
lisa/add-select-type
branch
from
0a7e8bf to
5aa744e
Compare
ravicious
approved these changes
Jul 3, 2023
zmb3
approved these changes
Jul 3, 2023
| }; | ||
|
|
||
| // CustomSelectComponentProps defines a prop type for the custom | ||
| // componets you define for react-select's `components` prop. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // componets you define for react-select's `components` prop. | |
| // components you define for react-select's `components` prop. |
Should we use tsdoc syntax here too?
kimlisa
force-pushed
the
lisa/add-select-type
branch
from
b5a7b1f to
f4c92ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type required here: https://github.com/gravitational/teleport.e/pull/1746/commits/df2b3fd8d98d3c018ea663407cfb730b80f8a293#diff-31203e9dcd007162396b1538295015d5b0d0a7334da621110c762b25a058ecfbR73 in this PR https://github.com/gravitational/teleport.e/pull/1746