Skip to content

Create a guide to using Teleport with Spacelift#28690

Merged
ptgott merged 4 commits intomasterfrom
paul.gottschling/25421-spacelift
Nov 2, 2023
Merged

Create a guide to using Teleport with Spacelift#28690
ptgott merged 4 commits intomasterfrom
paul.gottschling/25421-spacelift

Conversation

@ptgott
Copy link
Copy Markdown
Contributor

@ptgott ptgott commented Jul 5, 2023

Closes #25421

@ptgott ptgott force-pushed the paul.gottschling/25421-spacelift branch from ec0bef5 to 9d1db62 Compare July 7, 2023 14:36
alexfornuto
alexfornuto reviewed Jul 7, 2023
View reviewed changes
Comment thread docs/img/management/spacelift/apply-success.png Outdated
Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest resizing all the new images, as they are 5k wide and gonna be big/slow loading no matter how compressed the are. They don't need to be any bigger than the maximum size our layout will scale to.

Copy link
Copy Markdown
Contributor Author

@ptgott ptgott Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resized the images and squashed my changes into the original commit. I've also added a sidebar entry for the Spacelift guide.

Comment thread docs/pages/management/dynamic-resources/spacelift.mdx Outdated
Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptgott is this the same version as review/approved in #26031?

Copy link
Copy Markdown
Contributor Author

@ptgott ptgott Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is!

@ptgott ptgott force-pushed the paul.gottschling/25421-spacelift branch from 9d1db62 to 0e1d3bf Compare July 12, 2023 16:30
@ptgott ptgott requested a review from alexfornuto July 12, 2023 16:30
alexfornuto
alexfornuto approved these changes Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving based on original review

@ptgott ptgott force-pushed the paul.gottschling/25421-spacelift branch from 8c5bb4c to 18a4095 Compare October 18, 2023 19:39
@ptgott ptgott temporarily deployed to vercel October 18, 2023 19:39 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 18, 2023

🤖 Vercel preview here: https://docs-dbtvftvqb-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/25421-spacelift branch from 18a4095 to 10d1e5f Compare October 23, 2023 21:09
@ptgott ptgott temporarily deployed to vercel October 23, 2023 21:09 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 23, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 23, 2023

🤖 Vercel preview here: https://docs-julcbadhs-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/25421-spacelift branch from 10d1e5f to 5084afc Compare October 26, 2023 17:57
@ptgott ptgott temporarily deployed to vercel October 26, 2023 17:57 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 26, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 26, 2023

🤖 Vercel preview here: https://docs-60s0kp5m8-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott added the no-changelog Indicates that a PR does not require a changelog entry label Oct 30, 2023
@ptgott ptgott enabled auto-merge October 30, 2023 17:14
@ptgott ptgott force-pushed the paul.gottschling/25421-spacelift branch from 5084afc to 0ab844a Compare October 30, 2023 17:14
@ptgott ptgott temporarily deployed to vercel October 30, 2023 17:14 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2023

🤖 Vercel preview here: https://docs-eadjm4qj1-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/25421-spacelift branch from 0ab844a to c0700f1 Compare October 30, 2023 22:03
@ptgott ptgott temporarily deployed to vercel October 30, 2023 22:04 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2023

🤖 Vercel preview here: https://docs-5u84pcnnc-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott added this pull request to the merge queue Nov 2, 2023
Merged via the queue into master with commit 5cb625b Nov 2, 2023
@ptgott ptgott deleted the paul.gottschling/25421-spacelift branch November 2, 2023 16:08
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Nov 2, 2023

@ptgott See the table below for backport results.

Branch Result
branch/v12 Failed
branch/v13 Failed
branch/v14 Failed

@ptgott ptgott mentioned this pull request Nov 6, 2023
Merged
ptgott added a commit that referenced this pull request Nov 7, 2023
@ptgott
Create a guide to using Teleport with Spacelift
b6e9f95 
Backports #28690

* Add a guide to Teleport+Spacelift

Closes #25421

* Respond to alexfornuto feedback

* Spell fix

* Fix linter errors
ptgott added a commit that referenced this pull request Nov 9, 2023
@ptgott
Create a guide to using Teleport with Spacelift
f85c14b 
Backports #28690

* Add a guide to Teleport+Spacelift

Closes #25421

* Respond to alexfornuto feedback

* Spell fix

* Fix linter errors
ptgott added a commit that referenced this pull request Nov 14, 2023
@ptgott
Create a guide to using Teleport with Spacelift
f4d5d81 
Backports #28690

* Add a guide to Teleport+Spacelift

Closes #25421

* Respond to alexfornuto feedback

* Spell fix

* Fix linter errors
github-merge-queue Bot pushed a commit that referenced this pull request Nov 15, 2023
@ptgott
Create a guide to using Teleport with Spacelift (#34246)
359973d 
Backports #28690

* Add a guide to Teleport+Spacelift

Closes #25421

* Respond to alexfornuto feedback

* Spell fix

* Fix linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmb3 zmb3 zmb3 approved these changes

@stevenGravy stevenGravy stevenGravy approved these changes

@lsgunn-teleport lsgunn-teleport Awaiting requested review from lsgunn-teleport

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

+1 more reviewer

@alexfornuto alexfornuto alexfornuto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation no-changelog Indicates that a PR does not require a changelog entry size/md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a guide for using the Teleport Terraform provider with Spacelift

4 participants

@ptgott @alexfornuto @zmb3 @stevenGravy