Conversation
They never asked to be added I'm not sure why I added them in the first place
fix(ctb): gas snapshot rm extra build step
chore: update license year
feat(ctb): remove genesis output
Fix: build and publish all bedrock docker images before tagging release
Updates the DTL to correctly handle the deposit shutoff flag. We put the flag inside the AddressManager because the DTL already had easy access to the AddressManager. We parse the address as a uint256 and check if it's non-zero. By checking this every loop we can smoothly recover if the shutoff flag is reset.
feat(dtl): handle deposit shutoff
doc: fix spec typos
ops-bedrock: Remove oneshot
We do not want to set the `_owner` field in the `GovernanceToken`. This assumes that it is preset in the state, so it will not work for spinning up new networks.
Adds a global logger to the `SetStorage` operation. Not ideal that a global logger is used, but that is currently how the logging is handled for the migration. This will help to prevent errors in misconfiguration of the system. In setups like hive, it is difficult to get insight into the state of the system as it is being brought up, so this should log when the system is being brought up. Bad config should stick out, ie setting an empty value because something was left out of the config.
op-chain-ops: log when setting storage
op-node: Audit use of L1 State
Makes the L2OO proposer and challenger addresses immutable and gets rid of the concept of ownership in the L2OO.
Turn the constructor args into immutables. There isn't a real reason for them to be in storage. The legacy tokens can have the constructor args held in storage and it shouldn't make a difference.
The `LegacyERC20ETH` needed some cleanup because it extended the `OptimismMintableERC20` which had its interface changed such that the remote token and bridge are immutables instead of being held in storage. Changing these values to immutables will make interactions for mint/burn much cheaper.
…mutable contracts-bedrock: OptimismMintableERC20 immutables
…tils-5 maint(ctb): add comments to deploy utils
Instead of having multiple statedbs created, use a single statedb and make sure that it is only committed once. Various APIs are required for the full migration which wrap the low level LevelDB at various abstractions. This will ensure that changes to the statedb are committed to disk.
Standardizes the whitespace in deployment files. I have nothing better to do right now.
Very simple one for now
…espace maint(ctb): standardized whitespace in deploys
op-chain-ops: single database commit
op-wheel: geth db cheats logic
op-wheel: execution engine logic
op-wheel: commands frontend
🦋 Changeset detectedLatest commit: 31fb2b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
C-protocol-critical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qn->anTypes.WithdrawalTransaction&Types.OutputRootProofop-migratewithdrawals.mdspec (fix(specs): Clear up explanation of L1 side of withdrawals #4194)