Skip to content

op-node: Mark functions test helpers#4237

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
estensen:op-node-test-helper
Dec 8, 2022
Merged

op-node: Mark functions test helpers#4237
mslipper merged 1 commit intoethereum-optimism:developfrom
estensen:op-node-test-helper

Conversation

@estensen
Copy link
Contributor

@estensen estensen commented Dec 6, 2022

Description

Mark functions test helpers so filename and line number which call these functions will be reported instead of the test helpers.

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

⚠️ No Changeset found

Latest commit: 5ba3f4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, @trianglesphere and @protolambda curious of your thoughts on this

@trianglesphere
Copy link
Contributor

These changes look fine. I don't think we've been super consistent about using t.Helper though.

@mslipper
Copy link
Contributor

mslipper commented Dec 8, 2022

Devnet issues are related to lack of rebase. Merging.

@mslipper mslipper merged commit 4a65bb9 into ethereum-optimism:develop Dec 8, 2022
@mslipper mslipper mentioned this pull request Dec 8, 2022
@estensen estensen deleted the op-node-test-helper branch December 8, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants