Conversation
|
trianglesphere
left a comment
trianglesphere
left a comment
There was a problem hiding this comment.
lgtm. If we want to test this, I think we could unit test it, but probably shouldn't do integration tests for this.
| if err != nil { | ||
| return head, nil, nil, fmt.Errorf("failed to get safe block: %w", err) | ||
| } | ||
| finalized, err = getHeader(ctx, client, "eth_getBlockByNumber", "finalized") |
There was a problem hiding this comment.
Any reason to fetch block by number instead of header by number if you only care about the header?
4 participants
Description
This PR adds a
enginepackage toop-wheelwith all the backend logic for the engine commands: a common engine API dialing function with authentication, and functions to read or modify the engine API.Third PR in a stack of 4: base, cheats-logic, engine-logic, commands-frontend:
Tests
This is a testing tool used in the migration testing. I'm open to testing the backend functionality in CI somewhere, but don't like to cascade the testing with testing of the testing.
Metadata
Fix #ENG-3084