Skip to content

feat(ctb): put dictator behind Proxy#4206

Merged
mslipper merged 1 commit intodevelopfrom
sc/ctb-dictator-proxy
Dec 5, 2022
Merged

feat(ctb): put dictator behind Proxy#4206
mslipper merged 1 commit intodevelopfrom
sc/ctb-dictator-proxy

Conversation

@smartcontracts
Copy link
Contributor

Description
Puts the SystemDictator behind a standard Proxy contract. By putting the SystemDictator behind a proxy, we can work our way out of pretty much any error type. The owner of the proxy will be the controller as defined in the deploy config.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

⚠️ No Changeset found

Latest commit: 7312f43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes
Copy link
Contributor

tynes commented Dec 5, 2022

Looks like something is wrong based on the failing devnet with deployed contracts

Error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (reason="execution reverted: L1ChugSplashProxy: implementation is not set yet", method="estimateGas", transaction={"from":"0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266","to":"0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0","data":"0x58a997f6000000000000000000000000a85233c63b9ee964add6f2cffe00fd84eb32338f0000000000000000000000007c6b91d9be155a6db01f749217d76ff02a7227f20000000000000000000000000000000000000000000000000de0b6b3a76400000000000000000000000000000000000000000000000000000000000000030d4000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000000","accessList":null}, error={"name":"ProviderError","code":3,"_isProviderError":true,"data":"0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000304c314368756753706c61736850726f78793a20696d706c656d656e746174696f6e206973206e6f74207365742079657400000000000000000000000000000000"}, code=UNPREDICTABLE_GAS_LIMIT, version=providers/5.7.1)

Digging in:

execution reverted: L1ChugSplashProxy: implementation is not set yet

Looking at the calldata

$ cast 4byte 0x58a997f6
depositERC20(address,address,uint256,uint32,bytes)

@tynes
Copy link
Contributor

tynes commented Dec 5, 2022

Looks like the L1StandardBridge is no longer being configured correctly

Puts the SystemDictator behind a standard Proxy contract. By putting the
SystemDictator behind a proxy, we can work our way out of pretty much
any error type. The owner of the proxy will be the controller as defined
in the deploy config.
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added a commit that referenced this pull request Dec 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify bot added a commit that referenced this pull request Dec 5, 2022
mergify bot added a commit that referenced this pull request Dec 5, 2022
@mslipper mslipper merged commit 09e4957 into develop Dec 5, 2022
@mslipper mslipper deleted the sc/ctb-dictator-proxy branch December 5, 2022 19:27
@mergify mergify bot removed the on-merge-train label Dec 5, 2022
@mslipper mslipper mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants