Skip to content

Update withdrawal params for two step withdrawals#4275

Merged
mslipper merged 1 commit intodevelopfrom
jg/update_go_withdrawal_utils
Dec 6, 2022
Merged

Update withdrawal params for two step withdrawals#4275
mslipper merged 1 commit intodevelopfrom
jg/update_go_withdrawal_utils

Conversation

@trianglesphere
Copy link
Contributor

Description

This renames the L2 block field to the L2 Index. This more accurately matches what the L2 output oracle contract expects.

Tests

Tested in hive here: ethereum-optimism/hive#66

Additional context

I think we need a design doc on the API design of the proof withdrawal utilities. I expect that the API might change again - having to pass in the contract is a little bit ugly.

Once this is merged, I'll have to cut a release v0.10.3 and then update hive with that release.

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

⚠️ No Changeset found

Latest commit: 5926347

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere marked this pull request as draft December 6, 2022 21:56
@trianglesphere trianglesphere force-pushed the jg/update_go_withdrawal_utils branch from 0ebf17f to db3d43c Compare December 6, 2022 21:57
@trianglesphere trianglesphere marked this pull request as ready for review December 6, 2022 21:57
@mergify mergify bot added the A-indexer Area: indexer label Dec 6, 2022
This renames the L2 block field to the L2 Index. This more accurately
matches what the L2 output oracle contract expects.
@trianglesphere trianglesphere force-pushed the jg/update_go_withdrawal_utils branch from db3d43c to 5926347 Compare December 6, 2022 22:26
@tynes
Copy link
Contributor

tynes commented Dec 6, 2022

I think we need a design doc on the API design of the proof withdrawal utilities. I expect that the API might change again - having to pass in the contract is a little bit ugly.

I agree with this, the sdk has a stable interface for typescript and the existing go utils aren't working well for my usecase of submitting migrated withdrawals

@mslipper mslipper merged commit b096e72 into develop Dec 6, 2022
@mslipper mslipper deleted the jg/update_go_withdrawal_utils branch December 6, 2022 23:08
@mslipper mslipper mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-indexer Area: indexer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants