Conversation
This ensure that the git metadata is available to make when it is building the binaries.
This is easier to do than writing a script to update the individual versions, but should be enough to remind the developer cutting the release to do the updates.
trianglesphere
requested review from
mslipper,
protolambda,
tynes and
zhwrd
as code owners
|
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
|
Hey @trianglesphere, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with |
5 participants
Description
This adds two layers of versioning to builds. The first is providing git information to docker builds. We already pulled the information into the build via make & ldflags, but did not have it available because we did not have the
.gitfolder inside docker.The second is setting a reminder in the
tag-bedrock-go-modules.shscript to set the version in theop-node,op-batcher, &op-proposer. This should try to correspond to the tag version. This might be able to be scripted, but scripting it is hard, so I chose to prompt the developer.Metadata