Skip to content

Update op-geth#4211

Merged
mslipper merged 2 commits intodevelopfrom
jg/update_geth
Dec 5, 2022
Merged

Update op-geth#4211
mslipper merged 2 commits intodevelopfrom
jg/update_geth

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Dec 5, 2022

Description

Updates op-geth to a migration rehearsal ready version.
I had to modify the genesis creation tools to set the bedrock block number in the chain config for tests to pass as if the optimism config is set, the bedrock block should also
be set.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

⚠️ No Changeset found

Latest commit: f8d8779

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes
Copy link
Contributor

tynes commented Dec 5, 2022

It looks like somehow eth_estimateGas is trying to be forwarded to a historical node when it shouldn't be

WARN [12-05|19:16:34.829] Served eth_estimateGas reqid=46 duration="39.395µs" err="no historical RPC is available for this historical (pre-bedrock) execution request"

@trianglesphere
Copy link
Contributor Author

It looks like somehow eth_estimateGas is trying to be forwarded to a historical node when it shouldn't be

WARN [12-05|19:16:34.829] Served eth_estimateGas reqid=46 duration="39.395µs" err="no historical RPC is available for this historical (pre-bedrock) execution request"

This was because the optimism config was being set inside the chain config, but the bedrock block was not. I added a fix for it & I'm re-running the tests

@trianglesphere trianglesphere marked this pull request as ready for review December 5, 2022 19:42
@mslipper mslipper merged commit 3eace20 into develop Dec 5, 2022
@mslipper mslipper deleted the jg/update_geth branch December 5, 2022 23:10
@mslipper mslipper mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants