Skip to content

Develop -> Master#2396

Merged
tynes merged 39 commits intomasterfrom
develop
Apr 1, 2022
Merged

Develop -> Master#2396
tynes merged 39 commits intomasterfrom
develop

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Apr 1, 2022

smartcontracts and others added 30 commits March 24, 2022 15:28
Fixes a typo in the primary docker-compose file. replica-healthcheck
should be replica_healthcheck to conform with the style used everywhere
else.
Fixes a bug in the gas oracle docker setup that caused the oracle to
crash whenever it ran locally. Tweaks the ensureConnection function to
check more regularly and properly manage retries.
fix(rhc): typo in healthcheck docker-compose
See release notes here:
https://github.com/NomicFoundation/hardhat/releases/tag/hardhat%402.9.0

This is a performance release, so it is good to upgrade here
to improve the time of CI. The compilation happens in parallel
with this release, as well as tests being able to be ran in parallel.

We do not make use of any forked network tests currently, but
this PR does help to speed up that usecase as well.
Fixes a bug in the GasPriceOracle test suite that seems to only have had
an impact because hardhat got significantly faster between the current
iteration and the older one.
Adds parallel test execution to contracts to speed things up a bit.
Fixes a bug where BaseServiceV2 was not properly throwing when options
were missing.
Updates replica.yml in our infra folder to use an older version of the
healthcheck service by default. We'll use latest when we update our
environment variables everywhere later.
fix(go): bug causing gas oracle to crash locally
fix(infra): use older version of hc by default
…ptions

fix(cmn): have BaseService throw on missing options
Adds a configurable timeout for fetching the genesis file when running
l2Geth. Useful for people who want to run a node on slower internet and
need more than 60 seconds to fetch the genesis file.
…eout

feat(l2geth): add configurable genesis timeout
Runs the external SNX tests once per day.
Update ext-test-snx to collect all logs to prevent the option from going
stale in the future.
The actions responsible for building/deploying changesets have been left in place until a CircleCI implementation is built.
Image sizes were increased because the packages Dockerfile used `buster-slim` rather than Alpine. Unfortunately, the images will still be large because the `node_modules` directory contains dev dependencies. This is how it was before the CircleCI migration/larger build cleanup, and will need a larger rethink of how we build TypeScript projects in the monorepo before it can be solved.
feat(itests): run external tests once per day
Updates cache keys to fix the CircleCI permissions errors we've seen. Builds will be a bit slow while the cache rebuilds.
This code is not going to change before deprecation
of `l2geth` in favor of bedrock. Skip a couple of tests
that fail in CI that are not involved at all in consensus.
mslipper and others added 9 commits March 31, 2022 13:30
Adds a new JsonRpcProvider validator which specifically parses the input
type into a JsonRpcProvider instead of a generic provider.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Adds a new feature to BaseServiceV2 to have a service exit immediately
when 3 exit signals are received. Useful when the main loop would take a
long time to exit but you want the service to exit immediately.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Previously the chainid was too large for the ledger package to
work. This is due to ethers using an old version of the ledger
package. There is an unresolved open issue here:
https://github.com/ethers-io/ethers.js/issues/1365

This updates the chainid to 17 to get around this issue.
This chain id is used by ThaiChain 2.0 ThaiFi which
has very little activity.
https://exp.thaifi.com/

It also lints the docker compose file to use `'`
consistently

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* feat(ci): check deploy markdown correctness

Adds a step to the contract tests to confirm that the contract
deployment docs are up to date. Will only fail if a deployment has been
modified but yarn autogen:markdown was not run properly.

* maint(ct): update deployments markdown

Updates the deployments markdown files. Should've been updated after we
deployed the Teleportr contracts to Kovan but we didn't have the CI
workflow in place to detect that this didn't happen.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* fix(dtl): kovan DTL halting issue

* fix(dtl): add consistency check for L2 sync

* dtl: add retry logic on startup

* dtl: fix startup

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2022

🦋 Changeset detected

Latest commit: 3e5b209

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@eth-optimism/data-transport-layer Patch
@eth-optimism/l2geth Patch
@eth-optimism/common-ts Patch
@eth-optimism/gas-oracle Patch
@eth-optimism/integration-tests Patch
@eth-optimism/contracts Patch
@eth-optimism/core-utils Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch
@eth-optimism/sdk Patch
@eth-optimism/hardhat-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly April 1, 2022 01:38
@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work A-integration Area: integration tests A-cannon Area: cannon A-ops Area: ops A-pkg-sdk Area: packages/sdk labels Apr 1, 2022
@tynes tynes merged commit 08dea72 into master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cannon Area: cannon A-integration Area: integration tests A-ops Area: ops A-pkg-sdk Area: packages/sdk M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants