Merged
Conversation
🦋 Changeset detectedLatest commit: 7dc5bff The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-ops
smartcontracts
force-pushed
the
deps/bump-hardhat
branch
from
130bef3 to
581c3b7
Compare
tynes
requested review from
elenadimitrova,
maurelian,
mslipper,
optimisticben and
smartcontracts
as code owners
smartcontracts
force-pushed
the
deps/bump-hardhat
branch
from
581c3b7 to
3aff767
Compare
Contributor
|
Current test failure is the result of this bug: NomicFoundation/hardhat#2459 |
smartcontracts
added a commit
that referenced
this pull request
Mar 10, 2022
Clears out most of the dependency warnings (mainly unmet peer dependency warnings) by adding or updating various dependencies. Still seeing two warnings that can only be fixed by updating to the latest hardhat. See discussion in #2260 for more context about our attempts to upgrade to the latest version of hardhat.
smartcontracts
added a commit
that referenced
this pull request
Mar 10, 2022
Clears out most of the dependency warnings (mainly unmet peer dependency warnings) by adding or updating various dependencies. Still seeing two warnings that can only be fixed by updating to the latest hardhat. See discussion in #2260 for more context about our attempts to upgrade to the latest version of hardhat.
smartcontracts
added a commit
that referenced
this pull request
Mar 10, 2022
Clears out most of the dependency warnings (mainly unmet peer dependency warnings) by adding or updating various dependencies. Still seeing two warnings that can only be fixed by updating to the latest hardhat. See discussion in #2260 for more context about our attempts to upgrade to the latest version of hardhat.
smartcontracts
added a commit
that referenced
this pull request
Mar 10, 2022
Clears out most of the dependency warnings (mainly unmet peer dependency warnings) by adding or updating various dependencies. Still seeing two warnings that can only be fixed by updating to the latest hardhat. See discussion in #2260 for more context about our attempts to upgrade to the latest version of hardhat.
maurelian
reviewed
Mar 11, 2022
| OVM_GasPriceOracle.setDecimals(6) | ||
| await OVM_GasPriceOracle.setOverhead(2750) | ||
| await OVM_GasPriceOracle.setScalar(1500000) | ||
| await OVM_GasPriceOracle.setDecimals(6) |
Contributor
There was a problem hiding this comment.
how was this test suite working without this?
Contributor
There was a problem hiding this comment.
Does it just become a race condition that always worked out for us?
maurelian
approved these changes
Mar 11, 2022
Contributor
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
I left a couple comments/questions, but should be good to merge.
| '@eth-optimism/data-transport-layer': patch | ||
| '@eth-optimism/integration-tests': patch | ||
| '@eth-optimism/message-relayer': patch | ||
| '@eth-optimism/sdk': patch |
Contributor
There was a problem hiding this comment.
Suggested change
| '@eth-optimism/sdk': patch | |
| '@eth-optimism/sdk': patch | |
| '@eth-optimism/hardhat-node': patch |
Contributor
There was a problem hiding this comment.
Then can delete the other changeset file.
Contributor
Author
There was a problem hiding this comment.
I particularly had 2 changeset files because the auto generated changelogs create a link to the commit that the changeset was added in, so to use changesets correctly, you should have the changeset in the same commit as the changes it corresponds to
| OVM_GasPriceOracle.setDecimals(6) | ||
| await OVM_GasPriceOracle.setOverhead(2750) | ||
| await OVM_GasPriceOracle.setScalar(1500000) | ||
| await OVM_GasPriceOracle.setDecimals(6) |
Contributor
There was a problem hiding this comment.
Does it just become a race condition that always worked out for us?
Contributor
Author
|
Will update this PR to the next release of hardhat as NomicFoundation/hardhat#2459 has been fixed once there is a new release |
See release notes here: https://github.com/NomicFoundation/hardhat/releases/tag/hardhat%402.9.0 This is a performance release, so it is good to upgrade here to improve the time of CI. The compilation happens in parallel with this release, as well as tests being able to be ran in parallel. We do not make use of any forked network tests currently, but this PR does help to speed up that usecase as well.
Fixes a bug in the GasPriceOracle test suite that seems to only have had an impact because hardhat got significantly faster between the current iteration and the older one.
tynes
force-pushed
the
deps/bump-hardhat
branch
from
6bcf678 to
7dc5bff
Compare
Contributor
Author
This has been merged, this PR is now ready for review/merge. Will speed up testing times |
smartcontracts
approved these changes
Mar 25, 2022
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
Clears out most of the dependency warnings (mainly unmet peer dependency warnings) by adding or updating various dependencies. Still seeing two warnings that can only be fixed by updating to the latest hardhat. See discussion in ethereum-optimism#2260 for more context about our attempts to upgrade to the latest version of hardhat.
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview Includes `ca-certificates` and `libssl-dev` in the final exported executable image. The lack of root certificates was preventing certificate verification when using TLS-enabled RPC urls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See release notes here:
https://github.com/NomicFoundation/hardhat/releases/tag/hardhat%402.9.0
This is a performance release, so it is good to upgrade here
to improve the time of CI. The compilation happens in parallel
with this release, as well as tests being able to be ran in parallel.
We do not make use of any forked network tests currently, but
this PR does help to speed up that usecase as well.