l2geth: skip geth console flake tests#2384
Merged
mergify[bot] merged 1 commit intodevelopfrom Mar 31, 2022
Merged
Conversation
This code is not going to change before deprecation of `l2geth` in favor of bedrock. Skip a couple of tests that fail in CI that are not involved at all in consensus.
🦋 Changeset detectedLatest commit: 69e3c41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
approved these changes
Mar 31, 2022
Contributor
|
"Good riddance" |
mslipper
approved these changes
Mar 31, 2022
Merged
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
This code is not going to change before deprecation of `l2geth` in favor of bedrock. Skip a couple of tests that fail in CI that are not involved at all in consensus.
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
…RootAtTimestamp` (#2395) Closes #2383 , #2384 - Skipped testing for `supervisor_syncStatus` because that is being tested checking the chain progress. - Skipped `supervisor_dependencySetV1` because we need `QueryAPI` in Go implementation to implement the end-point so that we can test it using devstack. #### Changes - The serialize and deserialize implemented for `ChainID` is now generic for `u64` because I needed it at other places as well. - Due to the way Go unmarshalls the response, I needed to add the response objects `SuperRootOutputRpc` and `ChainRootInfoRpc`, which are essentially the same as `SuperRootOutput` and `ChainRootInfo` used before. The fields `timestamp`, `version` and `chainID` needed to be compatible with `hexutil.Uint64` and hexutil.Bytes`. Hence all the modifications. Tested locally, all tests including e2e tests are passing as expected.
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
…RootAtTimestamp` (op-rs/kona#2395) Closes #2383 , #2384 - Skipped testing for `supervisor_syncStatus` because that is being tested checking the chain progress. - Skipped `supervisor_dependencySetV1` because we need `QueryAPI` in Go implementation to implement the end-point so that we can test it using devstack. #### Changes - The serialize and deserialize implemented for `ChainID` is now generic for `u64` because I needed it at other places as well. - Due to the way Go unmarshalls the response, I needed to add the response objects `SuperRootOutputRpc` and `ChainRootInfoRpc`, which are essentially the same as `SuperRootOutput` and `ChainRootInfo` used before. The fields `timestamp`, `version` and `chainID` needed to be compatible with `hexutil.Uint64` and hexutil.Bytes`. Hence all the modifications. Tested locally, all tests including e2e tests are passing as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This code is not going to change before deprecation
of
l2gethin favor of bedrock. Skip a couple of teststhat fail in CI that are not involved at all in consensus.