ci: Use Alpine to reduce image size#2375
Merged
mslipper merged 1 commit intoethereum-optimism:developfrom Mar 31, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: c195712 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mslipper
force-pushed
the
bugfix/docker-image-size
branch
from
d7b6738 to
cb31a03
Compare
tynes
reviewed
Mar 28, 2022
ops/docker/Dockerfile.packages
Outdated
| @@ -4,14 +4,9 @@ | |||
| # ### BASE: Install deps | |||
| # We do not use Alpine because there's a regression causing it to be very slow | |||
Contributor
There was a problem hiding this comment.
Is this comment still relevant?
mslipper
force-pushed
the
bugfix/docker-image-size
branch
from
cb31a03 to
aab0821
Compare
Contributor
|
This needs a changeset for each typescript service, then looks good to me |
Image sizes were increased because the packages Dockerfile used `buster-slim` rather than Alpine. Unfortunately, the images will still be large because the `node_modules` directory contains dev dependencies. This is how it was before the CircleCI migration/larger build cleanup, and will need a larger rethink of how we build TypeScript projects in the monorepo before it can be solved.
mslipper
force-pushed
the
bugfix/docker-image-size
branch
from
aab0821 to
c195712
Compare
tynes
approved these changes
Mar 29, 2022
Contributor
|
Is there something with circle ci and the way it supports stdout? The geth tests that are failing look like they are doing a string match on stdout |
Collaborator
Author
|
The geth tests have always been a bit flaky, but it's worse on CircleCI. I'll rerun the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image sizes were increased because the packages Dockerfile used
buster-slimrather than Alpine. Unfortunately, the images will still be large because thenode_modulesdirectory contains dev dependencies. This is how it was before the CircleCI migration/larger build cleanup, and will need a larger rethink of how we build TypeScript projects in the monorepo before it can be solved.