ci: Remove GH actions CI builds#2372
Merged
mslipper merged 1 commit intoethereum-optimism:developfrom Mar 27, 2022
Merged
Conversation
The actions responsible for building/deploying changesets have been left in place until a CircleCI implementation is built.
|
smartcontracts
approved these changes
Mar 26, 2022
Contributor
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
Ya love to see it 🔥🔥🔥
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…#2388) ## Description This PR refactors the core logic of the engine task handler. In particular, it moves duplicate code from the build and the insert unsafe tasks to the forkchoice task. Changes: - Add an associated `Output` type for the `EngineTaskExt` trait which allows the implementors of this trait to be composed. In particular, the `ForkchoiceTask` may returns the payload id that was inserted in the EL, which can be used by the `BuildTask` to consolidate the payload into the engine state. - Allows the `ForkchoiceTask` to directly insert newly built payload attributes into the EL (by adding an `Option<OpAttributeWithParent>` argument to the `ForkchoiceTask`). This allows to refactors both calls to the `FCU` inside the `BuildTask` using the `ForkchoiceTask` and avoids manually handling the forkchoice updates - Moves the `PayloadStatus` verification logic to the `ForkchoiceTask` to avoid having to perform the same logic in both the `BuildTask` and the `InsertUnsafeTask`, which allows to fix the sequencer kickstart issue described in #2372 Close #2372 ## Potential follow-ups - Remove the clones inside the engine tasks - Refactor the `new_payload` logic into an engine task to remove duplicate code in the `InsertUnsafe` and `Build`Tasks
theochap
added a commit
that referenced
this pull request
Jan 14, 2026
…op-rs/kona#2388) ## Description This PR refactors the core logic of the engine task handler. In particular, it moves duplicate code from the build and the insert unsafe tasks to the forkchoice task. Changes: - Add an associated `Output` type for the `EngineTaskExt` trait which allows the implementors of this trait to be composed. In particular, the `ForkchoiceTask` may returns the payload id that was inserted in the EL, which can be used by the `BuildTask` to consolidate the payload into the engine state. - Allows the `ForkchoiceTask` to directly insert newly built payload attributes into the EL (by adding an `Option<OpAttributeWithParent>` argument to the `ForkchoiceTask`). This allows to refactors both calls to the `FCU` inside the `BuildTask` using the `ForkchoiceTask` and avoids manually handling the forkchoice updates - Moves the `PayloadStatus` verification logic to the `ForkchoiceTask` to avoid having to perform the same logic in both the `BuildTask` and the `InsertUnsafeTask`, which allows to fix the sequencer kickstart issue described in #2372 Close #2372 ## Potential follow-ups - Remove the clones inside the engine tasks - Refactor the `new_payload` logic into an engine task to remove duplicate code in the `InsertUnsafe` and `Build`Tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actions responsible for building/deploying changesets have been left in place until a CircleCI implementation is built.