ops: fix chainid to work with ethers ledger#2380
Merged
mergify[bot] merged 2 commits intodevelopfrom Mar 31, 2022
Merged
Conversation
tynes
requested review from
maurelian,
mslipper,
optimisticben and
smartcontracts
as code owners
🦋 Changeset detectedLatest commit: 16486f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Previously the chainid was too large for the ledger package to work. This is due to ethers using an old version of the ledger package. There is an unresolved open issue here: https://github.com/ethers-io/ethers.js/issues/1365 This updates the chainid to 17 to get around this issue. This chain id is used by ThaiChain 2.0 ThaiFi which has very little activity. https://exp.thaifi.com/ It also lints the docker compose file to use `'` consistently
mslipper
approved these changes
Mar 31, 2022
Merged
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
Previously the chainid was too large for the ledger package to work. This is due to ethers using an old version of the ledger package. There is an unresolved open issue here: https://github.com/ethers-io/ethers.js/issues/1365 This updates the chainid to 17 to get around this issue. This chain id is used by ThaiChain 2.0 ThaiFi which has very little activity. https://exp.thaifi.com/ It also lints the docker compose file to use `'` consistently Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the chainid was too large for the ledger package to
work. This is due to ethers using an old version of the ledger
package. There is an unresolved open issue here:
ethers-io/ext-signer-ledger#6
This updates the chainid to 17 to get around this issue.
This chain id is used by ThaiChain 2.0 ThaiFi which
has very little activity.
https://exp.thaifi.com/
It also lints the docker compose file to use
'consistently