fix(cmn): have BaseService throw on missing options#2366
Merged
smartcontracts merged 1 commit intodevelopfrom Mar 25, 2022
Merged
fix(cmn): have BaseService throw on missing options#2366smartcontracts merged 1 commit intodevelopfrom
smartcontracts merged 1 commit intodevelopfrom
Conversation
smartcontracts
changed the title
Fixes a bug where BaseServiceV2 was not properly throwing when options were missing.
smartcontracts
force-pushed
the
sc/fix-base-service-options
branch
from
167d8b4 to
51673b9
Compare
🦋 Changeset detectedLatest commit: 51673b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2366 +/- ##
========================================
Coverage 80.14% 80.14%
========================================
Files 77 77
Lines 2458 2458
Branches 450 450
========================================
Hits 1970 1970
Misses 488 488
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tynes
approved these changes
Mar 25, 2022
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where BaseServiceV2 was not properly throwing when options
were missing.