Conversation
This commit places the batch sequencer tx size check inside of a for loop so that the we can continue to whittle away batch tx sizes until satisfying the configured maximum. This doesn't result in a behavioral change, as the for loop exits after the first iteration. This is done to make the behavioral changes more apparent in subsequent commits.
..by breaking its require(ments)
..by breaking its require(ments). RLP tests from https://github.com/ethereum/tests/tree/develop/RLPTests
… example output. This is a WIP commit with the purpose of quick feedback on the result.
…e are any missing Natspec comments. Still WIP. Better console formatting + configurations is next :)
- within fraud proof window - not batchheader timestamp equal zero
Create a setup script for the integration tests
feat: implement getMessageReceipt and tests
feat: L2Provider test scaffold
feat: implement clear pending txs for go batch submitter
Fixes a bug where both the sequencer and proposer main loops were attempting to clear the pending transactions from the batch-tx submitter's wallet. The impact is that we may have been overspending on fees due to conflicting/reverting state batches. However the impact overall should be minor given the relative size of state batches in comparison to tx-batches.
fix(batch-submitter): clear state root batches
The current interface supports only one method for both crafting and publishing a batch transaction, SubmitBatchTx. Currently this is being executed on each new gas price that the txmgr commands, implying we are doing a lot of extra work to rederive batches. In addition, much our instrumentation lives inside this method, meaning that the they are also being recorded multiple times per transaction. When we get to processing larger batches on Kovan and Mainnet, this could also become a resource bottleneck. This commit remedies all of the above issues by splitting out the transaction crafting process from the publication. A new method, CraftBatchTx, is added to the Driver interface. This method is responsible for creating a fully formed transaction, but does not publish it. The responsibility of SubmitBatchTx is now modified to take an predefined transaction, i.e. created by CraftBatchTx, overwrite the supplied gas price, and publish. In this way, this expensive call to build batches can be done once before handing the transaction of the txmgr.
Previously it was being logged every time we modified the gas price. Additionally, we log the raw byte length rather than tx.Size(). The latter returns a float value of type StorageSize, which explains why the metrics haven't been indicating actual byte values.
bss: split up SubmitBatchTx method in Driver iface
We need to manually include musl headers and GCC now that proxyd has a geth dependency and needs CGO.
Fix proxyd build
fixed file extensions in integration tests
🦋 Changeset detectedLatest commit: 3174f03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-op-batcher
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…s to a given peer (#2025) ## Description This PR fixes the gossip stability issues we've experience on initial connections to the `op-node`s by preventing `kona-node`s from redialing already connected peers, or peers that have been already dialed. With that fix on, we're not experiencing the peer drops in kurtosis anymore On a side note: this PR also increases the log levels of some gossip events. ## Explanation My understanding of the situation: - The libp2p library imposes a substream limit for outgoing connections (constant, equal to 5). This is to prevent DOS vectors when creating new connections - It seems that every dial call will open a new outbound substream. - Since we're dialing peers quite often in the discovery layer, we're causing the libp2p library to reach the substream limit - When we reach the substream limit, the protocol gets disconnected and we're not advertising it to peers anymore. This causes the gossip connection to drop Relevant piece of code in libp2p : https://github.com/libp2p/rust-libp2p/blob/d3e88cfc2ec944c3e6beb7117a762452cb855e38/protocols/gossipsub/src/handler.rs#L499-L511. In our case, the outbound event is consistently the ConnectionEvent::FullyNegotiatedOutbound event, which happens on every new dial. ## Development - Close #1854
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Develop -> Master