Skip to content

feat: implement clear pending txs for go batch submitter#2003

Merged
mslipper merged 4 commits intoethereum-optimism:developfrom
cfromknecht:bss-pending-tx
Jan 14, 2022
Merged

feat: implement clear pending txs for go batch submitter#2003
mslipper merged 4 commits intoethereum-optimism:developfrom
cfromknecht:bss-pending-tx

Conversation

@cfromknecht
Copy link
Contributor

Description
This PR adds logic to the Go Batch Submitter, allowing it to clear any pending transactions from the mempool that may have been left from a prior running instance. It does so by sending a 0-value tx to itself, and waiting until either the transaction confirms or a different transaction at the same nonce has confirmed. After ensuring that the mempool state is in a safe state to proceed, the batch submitter begins operation as before.

In addition, this PR begins the process of mocking out the L1 backend, in a way that can be reused across the project/packages. Continuing this approach will allow us to extensively test for behavior under network-level failures.

Metadata

  • Fixes ENG-1887

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2022

⚠️ No Changeset found

Latest commit: 15252dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #2003 (15252dd) into develop (0f5c810) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2003   +/-   ##
========================================
  Coverage    74.58%   74.58%           
========================================
  Files           79       79           
  Lines         2554     2554           
  Branches       401      401           
========================================
  Hits          1905     1905           
  Misses         649      649           
Flag Coverage Δ
batch-submitter 62.50% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 88.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5c810...15252dd. Read the comment docs.

@cfromknecht cfromknecht force-pushed the bss-pending-tx branch 3 times, most recently from a031617 to c10dd53 Compare January 13, 2022 17:38
@mslipper mslipper merged commit 5599aed into ethereum-optimism:develop Jan 14, 2022
@cfromknecht cfromknecht deleted the bss-pending-tx branch January 14, 2022 19:30
theochap pushed a commit that referenced this pull request Dec 10, 2025
### Description

Adds more pipeline metrics.

Closes #2002
Closes #2003
Closes #2004
Closes #2005
theochap pushed a commit that referenced this pull request Jan 14, 2026
### Description

Adds more pipeline metrics.

Closes #2002
Closes #2003
Closes #2004
Closes #2005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants