bss: split up SubmitBatchTx method in Driver iface#2008
Merged
mslipper merged 3 commits intoethereum-optimism:developfrom Jan 14, 2022
Merged
bss: split up SubmitBatchTx method in Driver iface#2008mslipper merged 3 commits intoethereum-optimism:developfrom
mslipper merged 3 commits intoethereum-optimism:developfrom
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #2008 +/- ##
========================================
Coverage 74.58% 74.58%
========================================
Files 79 79
Lines 2554 2554
Branches 401 401
========================================
Hits 1905 1905
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cfromknecht
force-pushed
the
bss-craft-then-send-tx
branch
2 times, most recently
from
a96bc0b to
ae414aa
Compare
mslipper
approved these changes
Jan 14, 2022
cfromknecht
force-pushed
the
bss-craft-then-send-tx
branch
from
ae414aa to
a051271
Compare
The current interface supports only one method for both crafting and publishing a batch transaction, SubmitBatchTx. Currently this is being executed on each new gas price that the txmgr commands, implying we are doing a lot of extra work to rederive batches. In addition, much our instrumentation lives inside this method, meaning that the they are also being recorded multiple times per transaction. When we get to processing larger batches on Kovan and Mainnet, this could also become a resource bottleneck. This commit remedies all of the above issues by splitting out the transaction crafting process from the publication. A new method, CraftBatchTx, is added to the Driver interface. This method is responsible for creating a fully formed transaction, but does not publish it. The responsibility of SubmitBatchTx is now modified to take an predefined transaction, i.e. created by CraftBatchTx, overwrite the supplied gas price, and publish. In this way, this expensive call to build batches can be done once before handing the transaction of the txmgr.
Previously it was being logged every time we modified the gas price. Additionally, we log the raw byte length rather than tx.Size(). The latter returns a float value of type StorageSize, which explains why the metrics haven't been indicating actual byte values.
cfromknecht
force-pushed
the
bss-craft-then-send-tx
branch
from
a051271 to
961dfe2
Compare
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current
Driverinterface supports only one method for both crafting andpublishing a batch transaction,
SubmitBatchTx. Currently this is beingexecuted on each new gas price that the
txmgrcommands, implying we aredoing a lot of extra work to rederive batches. In addition, much our
instrumentation lives inside this method, meaning that the they are also
being recorded multiple times per transaction. When we get to
processing larger batches on Kovan and Mainnet, this could also become a
resource bottleneck.
This PR remedies all of the above issues by splitting out the
transaction crafting process from the publication. A new method,
CraftBatchTx, is added to theDriverinterface. This method isresponsible for creating a fully formed transaction, but does not
publish it. The responsibility of
SubmitBatchTxis now modified to takean predefined transaction, i.e. created by
CraftBatchTx, overwrite thesupplied gas price, and publish. In this way, this expensive call to
build batches can be done once before handing the transaction of the
txmgr.Additionally, we now log the raw byte length for the
batch_tx_sizemetricrather than tx.Size(). The latter returns a float value of type
StorageSize,which explains why the metrics haven't been indicating the actual byte values.
These commits are carried over from prior work done on #1993.
Builds on
Metadata