feat: implement getMessageReceipt and tests#1955
Conversation
|
|
With all of the todos, is this a draft or ready for review? |
Codecov Report
@@ Coverage Diff @@
## develop #1955 +/- ##
===========================================
+ Coverage 73.13% 75.61% +2.47%
===========================================
Files 79 57 -22
Lines 2520 1993 -527
Branches 387 294 -93
===========================================
- Hits 1843 1507 -336
+ Misses 677 486 -191
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
The TODOs are mainly just notes for myself in the future, nothing blocking this PR. Going to run over all of the TODOs later and make tickets out of them if they're actually worth doing. |
There was a problem hiding this comment.
We need to find the first SentMessage event such that the logIndex is greater than the TokenBridgeMessage logIndex. Basically we detect TokenBridgeMessage events separately (they're usually stuff like ERC20DepositInitiated or WithdrawalInitiated). These events are then followed by a SentMessage event.
There was a problem hiding this comment.
I can add a comment here to make this more clear
There was a problem hiding this comment.
I added a detailed comment that explains what's happening here
03caf3e to
42d3e65
Compare
42d3e65 to
4b9d185
Compare
SmitV
left a comment
There was a problem hiding this comment.
Approving based on review on call. Good stuff
There was a problem hiding this comment.
Not part of the PR but I before E except after C :)
4b9d185 to
c8a68b7
Compare
### Description Bumps dependency versions to latest.
Description
Implements the getMessageReceipt function and corresponding tests. Also adds a new
toCrossChainMessagefunction that can parse aMessageLikeinto aCrossChainMessageobject.Metadata