fix(batch-submitter): clear state root batches#2006
Merged
cfromknecht merged 1 commit intoethereum-optimism:developfrom Jan 14, 2022
Merged
fix(batch-submitter): clear state root batches#2006cfromknecht merged 1 commit intoethereum-optimism:developfrom
cfromknecht merged 1 commit intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 9fe09f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2006 +/- ##
========================================
Coverage 74.58% 74.58%
========================================
Files 79 79
Lines 2554 2554
Branches 401 401
========================================
Hits 1905 1905
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cfromknecht
force-pushed
the
clear-state-batch-pending-tx
branch
from
3777101 to
3be6512
Compare
tynes
approved these changes
Jan 13, 2022
karlfloersch
approved these changes
Jan 14, 2022
Contributor
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
LGTM! Nice catch 😅😭
Fixes a bug where both the sequencer and proposer main loops were attempting to clear the pending transactions from the batch-tx submitter's wallet. The impact is that we may have been overspending on fees due to conflicting/reverting state batches. However the impact overall should be minor given the relative size of state batches in comparison to tx-batches.
cfromknecht
force-pushed
the
clear-state-batch-pending-tx
branch
from
3be6512 to
9fe09f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where both the sequencer and proposer main loops were
attempting to clear the pending transactions from the batch-tx
submitter's wallet. The impact is that we may have been overspending on
fees due to conflicting/reverting state batches. However the impact
overall should be minor given the relative size of state batches in
comparison to tx-batches.
Metadata