Conversation
|
Inphi
left a comment
There was a problem hiding this comment.
LGTM. One note; buster is a larger baseimage than alpine. Not by much though.
|
Yeah. I used buster slim for the output image to cut down on some size. Unless we pull libc into Alpine I don't see a way around this. |
Codecov Report
@@ Coverage Diff @@
## develop #2012 +/- ##
========================================
Coverage 74.58% 74.58%
========================================
Files 79 79
Lines 2554 2554
Branches 401 401
========================================
Hits 1905 1905
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Our geth image runs in alpine - https://github.com/ethereum-optimism/optimism/blob/develop/ops/docker/Dockerfile.geth Also other services with geth use alpine
Perhaps this is a versioning issue? |
|
Upstream also uses alpine https://github.com/ethereum/go-ethereum/blob/master/Dockerfile |
ab4af4b to
0e40f9f
Compare
|
Wow, well I was completely wrong. Fixed by adding musl headers to alpine. |
We need to manually include musl headers and GCC now that proxyd has a geth dependency and needs CGO.
0e40f9f to
980d0dd
Compare
Adds musl headers and GCC to the proxyd build.