Skip to content

Fix proxyd build#2012

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:bugfix/proxyd-build
Jan 15, 2022
Merged

Fix proxyd build#2012
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:bugfix/proxyd-build

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Jan 14, 2022

Adds musl headers and GCC to the proxyd build.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2022

⚠️ No Changeset found

Latest commit: 980d0dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One note; buster is a larger baseimage than alpine. Not by much though.

@mslipper
Copy link
Collaborator Author

Yeah. I used buster slim for the output image to cut down on some size. Unless we pull libc into Alpine I don't see a way around this.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #2012 (980d0dd) into develop (235c7af) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2012   +/-   ##
========================================
  Coverage    74.58%   74.58%           
========================================
  Files           79       79           
  Lines         2554     2554           
  Branches       401      401           
========================================
  Hits          1905     1905           
  Misses         649      649           
Flag Coverage Δ
batch-submitter 62.50% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 88.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235c7af...980d0dd. Read the comment docs.

@tynes
Copy link
Contributor

tynes commented Jan 14, 2022

@mslipper mslipper force-pushed the bugfix/proxyd-build branch 2 times, most recently from ab4af4b to 0e40f9f Compare January 15, 2022 01:21
@mslipper
Copy link
Collaborator Author

Wow, well I was completely wrong. Fixed by adding musl headers to alpine.

We need to manually include musl headers and GCC now that proxyd has a geth dependency and needs CGO.
@mslipper mslipper force-pushed the bugfix/proxyd-build branch from 0e40f9f to 980d0dd Compare January 15, 2022 05:01
@mslipper mslipper merged commit e634bf2 into ethereum-optimism:develop Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants