Skip to content

Create a setup script for the integration tests#1907

Merged
smartcontracts merged 2 commits intoethereum-optimism:developfrom
barrasso:integration-test-setup
Dec 21, 2021
Merged

Create a setup script for the integration tests#1907
smartcontracts merged 2 commits intoethereum-optimism:developfrom
barrasso:integration-test-setup

Conversation

@barrasso
Copy link
Contributor

@barrasso barrasso commented Dec 9, 2021

Description
Adds a test setup script, shared/setup.ts, in the integration-tests package.

Additional context
Updates the tests to import from the setup script instead of from chai and ethereum-waffle directly.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2021

⚠️ No Changeset found

Latest commit: a2ffd3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-integration Area: integration tests label Dec 9, 2021
@smartcontracts
Copy link
Contributor

Haha, glad someone is finally picking up these issues! So nice to see this code get deleted 😅

@smartcontracts
Copy link
Contributor

@barrasso would you mind just quickly rebasing this on top of the latest version of develop?

@barrasso
Copy link
Contributor Author

barrasso commented Dec 21, 2021

@barrasso would you mind just quickly rebasing this on top of the latest version of develop?

@smartcontracts Done!

@smartcontracts
Copy link
Contributor

Running CI, then let's get this merged!

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #1907 (a2ffd3a) into develop (1c4f838) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1907   +/-   ##
========================================
  Coverage    73.13%   73.13%           
========================================
  Files           79       79           
  Lines         2520     2520           
  Branches       387      387           
========================================
  Hits          1843     1843           
  Misses         677      677           
Flag Coverage Δ
batch-submitter 62.50% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 86.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4f838...a2ffd3a. Read the comment docs.

@smartcontracts smartcontracts merged commit 9f970f0 into ethereum-optimism:develop Dec 21, 2021
@barrasso barrasso deleted the integration-test-setup branch December 22, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-integration Area: integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a setup script for the integration tests

4 participants