Skip to content

[DRAFT] chore(rust/op-reth): update reth to rev 2c5d00f and bump alloy deps#19162

Closed
theochap wants to merge 597 commits intodevelopfrom
theo/pull-reth
Closed

[DRAFT] chore(rust/op-reth): update reth to rev 2c5d00f and bump alloy deps#19162
theochap wants to merge 597 commits intodevelopfrom
theo/pull-reth

Conversation

@theochap
Copy link
Member

@theochap theochap commented Feb 11, 2026

Summary

  • Update reth git dependency to rev 2c5d00f and bump alloy crates from 1.5.2 to 1.6.3
  • Fix all breaking API changes across op-reth crates (renamed methods, changed signatures, type mismatches)
  • Resolve clippy warnings (option_if_let_else, needless_return, unused crate deps)

Test plan

  • cargo check --workspace --all-features passes
  • cargo clippy --workspace --all-features passes with zero warnings
  • CI passes

🤖 Generated with Claude Code

Rimeeeeee and others added 30 commits August 13, 2025 14:25
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
…reumAddOns (paradigmxyz/reth#17693)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…h#17992)

Co-authored-by: Dharm Singh <dharmhsing@gmail.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…th#17792)

Co-authored-by: Roman Hodulák <roman.hodulak@polyglot-software.com>
mattsse and others added 16 commits January 17, 2026 15:57
…ayloadV6, BALs) (paradigmxyz/reth#21344)

Co-authored-by: Ishika Choudhury <117741714+Rimeeeeee@users.noreply.github.com>
Co-authored-by: Soubhik Singha Mahapatra <160333583+Soubhik-10@users.noreply.github.com>
…21407)

Signed-off-by: Ahsen Kamal <itsahsenkamal@gmail.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Amp <amp@ampcode.com>
…les/ (paradigmxyz/reth#21495)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Amp <amp@ampcode.com>
Update reth git dependency to rev 2c5d00f and bump alloy crates to
1.6.3 to match. Fix breaking API changes across op-reth crates:

- txpool: remove validate_transactions/validate_transactions_with_origin
  overrides (trait now has compatible defaults with IntoIterator sigs)
- flashblocks: spawn_blocking now takes FnOnce closure, not pinned future
- rpc/eth: Runtime::spawn renamed to spawn_task
- rpc/transaction: send_transaction gains origin parameter, pass through
  to add_pool_transaction
- rpc/sequencer: use alloy_transport_http::reqwest (0.12) instead of
  workspace reqwest (0.13) for type compatibility
- rpc/witness: spawn_blocking renamed to spawn_blocking_task on TaskSpawner
- node: spawn_critical renamed to spawn_critical_task
- node/utils: setup_engine returns 2-tuple (TaskManager removed)
- examples/op-db-access: open_read_only now requires Runtime arg
- Fix clippy warnings (option_if_let_else, needless_return, unused deps)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@theochap theochap requested a review from a team as a code owner February 11, 2026 19:55
@almanax-ai
Copy link
Contributor

almanax-ai bot commented Feb 11, 2026

Plan expired

Your subscription has expired. Please renew your subscription to continue using CI/CD integration and other features.

@theochap theochap force-pushed the theo/pull-reth branch 2 times, most recently from 41af990 to 33dd49b Compare February 11, 2026 21:00
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.5%. Comparing base (b5c24a6) to head (6bc39b9).
⚠️ Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
rust/op-reth/crates/rpc/src/sequencer.rs 40.0% 3 Missing ⚠️
rust/op-reth/crates/cli/src/lib.rs 0.0% 2 Missing ⚠️
rust/op-reth/crates/flashblocks/src/service.rs 0.0% 2 Missing ⚠️
rust/op-reth/crates/node/src/node.rs 0.0% 2 Missing ⚠️
...p-reth/crates/primitives/src/transaction/signed.rs 50.0% 2 Missing ⚠️
rust/op-reth/crates/rpc/src/eth/mod.rs 0.0% 2 Missing ⚠️
rust/op-reth/crates/payload/src/validator.rs 0.0% 1 Missing ⚠️
rust/op-reth/crates/rpc/src/eth/transaction.rs 66.6% 1 Missing ⚠️
rust/op-reth/crates/rpc/src/witness.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19162      +/-   ##
===========================================
- Coverage     76.3%    75.5%    -0.8%     
===========================================
  Files          188      503     +315     
  Lines        10946    60364   +49418     
===========================================
+ Hits          8360    45632   +37272     
- Misses        2440    14732   +12292     
+ Partials       146        0     -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?
unit 75.5% <48.3%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
rust/op-reth/crates/evm/src/lib.rs 99.7% <100.0%> (ø)
rust/op-reth/crates/flashblocks/src/lib.rs 0.0% <ø> (ø)
rust/op-reth/crates/flashblocks/src/sequence.rs 99.2% <ø> (ø)
rust/op-reth/crates/flashblocks/src/ws/stream.rs 79.3% <ø> (ø)
rust/op-reth/crates/hardforks/src/lib.rs 100.0% <100.0%> (ø)
rust/op-reth/crates/node/src/rpc.rs 100.0% <ø> (ø)
rust/op-reth/crates/node/src/utils.rs 100.0% <100.0%> (ø)
rust/op-reth/crates/primitives/src/receipt.rs 92.1% <100.0%> (ø)
rust/op-reth/crates/rpc/src/historical.rs 25.5% <ø> (ø)
rust/op-reth/crates/txpool/src/validator.rs 79.7% <ø> (ø)
... and 9 more

... and 672 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theochap theochap changed the title chore(rust/op-reth): update reth to rev 2c5d00f and bump alloy deps [DRAFT] chore(rust/op-reth): update reth to rev 2c5d00f and bump alloy deps Feb 13, 2026
@theochap theochap marked this pull request as draft February 13, 2026 22:02
@theochap theochap closed this Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.