feat: configurable EVM execution limits#21088
Merged
mattsse merged 48 commits intoparadigmxyz:mainfrom Jan 26, 2026
Merged
Conversation
fix comment reuse constants in revm fix: add correct overrides for EthEvmConfig and OpEvmConfig
fix and extend tests fix(evm): preserve tx_gas_limit_cap from helper and consolidate tests rename test refactor tests fix comment remove hardcoded values x fix tests extend tests consistency with tests x
Update spec.rs
mattsse
requested changes
Jan 15, 2026
crates/optimism/evm/src/lib.rs
Outdated
| self.chain_spec(), | ||
| self.chain_spec().chain().id(), | ||
| )) | ||
| ); |
Collaborator
There was a problem hiding this comment.
I'd be nicer if we can make this like .with_limits() then we dont need to duplicate all of the setters, so I'd like to move the EvmLimits type to the alloy repo instead then we can use it in evmenv and elsewhere
Contributor
Author
There was a problem hiding this comment.
Agreed that's cleaner. I'll start on it
rezzmah
commented
Jan 15, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Update transaction.rs x Update Cargo.toml fixes tests more run zepter
rezzmah
force-pushed
the
21018-configurable-evm-execution-limits
branch
from
c50b9a8 to
416142a
Compare
klkvr
force-pushed
the
21018-configurable-evm-execution-limits
branch
2 times, most recently
from
ec834fc to
ef502ec
Compare
klkvr
approved these changes
Jan 26, 2026
klkvr
force-pushed
the
21018-configurable-evm-execution-limits
branch
from
ef502ec to
aebd0b4
Compare
mattsse
approved these changes
Jan 26, 2026
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
makes sense, I think this will be easy to migrate actually
| + FromRecoveredTx<TxTy<Self::Primitives>> | ||
| + FromTxWithEncoded<TxTy<Self::Primitives>>, | ||
| Precompiles = PrecompilesMap, | ||
| Spec: Into<SpecId>, |
Collaborator
There was a problem hiding this comment.
this seems appropirate given that this is kinda enshrined by revm as well
Comment on lines
+785
to
+789
| // Get EVM limits from evm_config.evm_env() | ||
| let evm_env = self | ||
| .evm_config | ||
| .evm_env(new_tip_block) | ||
| .expect("evm_env should not fail for executed block"); |
Collaborator
There was a problem hiding this comment.
this seems fine to do on a per block basis
rakita
pushed a commit
that referenced
this pull request
Jan 26, 2026
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 29, 2026
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
klkvr
added a commit
that referenced
this pull request
Feb 13, 2026
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
klkvr
added a commit
that referenced
this pull request
Feb 13, 2026
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #21018
i.e. allows for configurable
MAX_CODE_SIZE,MAX_INITCODE_SIZE, andtx_gas_limit_capon existing chain specs.This PR doesn't implement genesis parsing into the chainspec as that requires an opinionated approach on the genesis file shape.
i realised a valid alternative is to have a custom
ChainSpecParserwhich also meets most requirementsCloses RETH-186